From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH] ivshmem: add all memzones of mempool to
	metada
Date: Fri, 3 Jun 2016 12:05:17 +0100
Message-ID: <5751646D.2080009@intel.com>
References: <1464787086-29555-1-git-send-email-ferruh.yigit@intel.com>
 <574FDA66.90909@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Cc: Anatoly Burakov <anatoly.burakov@intel.com>
To: Olivier MATZ <olivier.matz@6wind.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 1A0642C51
 for <dev@dpdk.org>; Fri,  3 Jun 2016 13:05:19 +0200 (CEST)
In-Reply-To: <574FDA66.90909@6wind.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 6/2/2016 8:04 AM, Olivier MATZ wrote:
> Hi Ferruh,
> 
> Thank you for fixing this issue.
> 
> On 06/01/2016 03:18 PM, Ferruh Yigit wrote:
>> [PATCH] ivshmem: add all memzones of mempool to metada
> 
> Minor comment: it seems the title is truncated
> 

Right, I will fix in next version of patch.

>> +static int
>> +add_mempool_to_metadata(const struct rte_mempool *mp,
>> +		struct ivshmem_config *config)
>> +{
>> +	struct rte_mempool_memhdr *memhdr;
>> +	int ret;
>> +
>> +	ret = add_mempool_memzone_to_metadata(mp, config);
>>  	if (ret < 0)
>>  		return -1;
>>  
>> +	STAILQ_FOREACH(memhdr, &mp->mem_list, next) {
>> +		ret = add_mempool_memzone_to_metadata(memhdr->addr, config);
>> +		if (ret < 0)
>> +			return -1;
>> +	}
>> +
>> +	/* mempool consists of memzone and ring */
>>  	return add_ring_to_metadata(mp->ring, config);
>>  }
>>  
> 
> In case you missed it: there is a function
> rte_mempool_mem_iter() that can be used to browse the
> memory chunks of a mempool. It's probably less convenient
> to use compared to directly browsing the list, but it
> may be more resistant to api changes.

I wasn't aware rte_mempool_mem_iter(), I will update the patch to use this.

> 
> Apart from that:
> Acked-by: Olivier Matz <olivier.matz@6wind.com>
> 
> Thanks
> 

Thanks,
ferruh