From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mail.openembedded.org (Postfix) with ESMTP id 3420477528 for ; Fri, 3 Jun 2016 13:40:41 +0000 (UTC) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP; 03 Jun 2016 06:40:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,412,1459839600"; d="asc'?scan'208";a="821002629" Received: from alimonb-mobl1.zpn.intel.com (HELO [10.219.5.164]) ([10.219.5.164]) by orsmga003.jf.intel.com with ESMTP; 03 Jun 2016 06:40:41 -0700 To: openembedded-core@lists.openembedded.org References: <1464297525-16174-1-git-send-email-anibal.limon@linux.intel.com> From: =?UTF-8?B?QW7DrWJhbCBMaW3Ds24=?= Message-ID: <57518905.7060005@linux.intel.com> Date: Fri, 3 Jun 2016 08:41:25 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1464297525-16174-1-git-send-email-anibal.limon@linux.intel.com> Subject: Re: [PATCH] dpkg: Upgrade to 1.18.7 X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Jun 2016 13:40:45 -0000 X-Groupsio-MsgNum: 83064 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="FluVgaLAuwXHJqlCu0xIMtJ9CbqC7tjan" --FluVgaLAuwXHJqlCu0xIMtJ9CbqC7tjan Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable ping On 05/26/2016 04:18 PM, An=C3=ADbal Lim=C3=B3n wrote: > Rebased patches: >=20 > 0003-Our-pre-postinsts-expect-D-to-be-set-when-running-in.patch > add_armeb_triplet_entry.patchadd_armeb_triplet_entry.patch >=20 > Patches removed already in upstream: >=20 > [1] 0001-When-running-do_package_write_deb-we-have-trees-of-h.patch > [2] fix-abs-redefine.patch >=20 > Signed-off-by: An=C3=ADbal Lim=C3=B3n >=20 > [1] https://anonscm.debian.org/cgit/dpkg/dpkg.git/commit/dpkg-deb/build= =2Ec?id=3D7a91341446851cd3594a8b752823b8c1f26d652a > [2] https://anonscm.debian.org/cgit/dpkg/dpkg.git/commit/lib/dpkg/i18n.= h?id=3Decd4baa091619cbbdd70043129dd992573580371 > --- > meta/recipes-devtools/dpkg/dpkg.inc | 2 - > ...g-do_package_write_deb-we-have-trees-of-h.patch | 71 --------------= -------- > ...tinsts-expect-D-to-be-set-when-running-in.patch | 36 +++++++---- > .../dpkg/dpkg/add_armeb_triplet_entry.patch | 22 ++++--- > .../dpkg/dpkg/fix-abs-redefine.patch | 40 ------------ > .../dpkg/{dpkg_1.18.4.bb =3D> dpkg_1.18.7.bb} | 6 +- > 6 files changed, 40 insertions(+), 137 deletions(-) > delete mode 100644 meta/recipes-devtools/dpkg/dpkg/0001-When-running-d= o_package_write_deb-we-have-trees-of-h.patch > delete mode 100644 meta/recipes-devtools/dpkg/dpkg/fix-abs-redefine.pa= tch > rename meta/recipes-devtools/dpkg/{dpkg_1.18.4.bb =3D> dpkg_1.18.7.bb}= (79%) >=20 > diff --git a/meta/recipes-devtools/dpkg/dpkg.inc b/meta/recipes-devtool= s/dpkg/dpkg.inc > index 3d9e7e3..c2215ce 100644 > --- a/meta/recipes-devtools/dpkg/dpkg.inc > +++ b/meta/recipes-devtools/dpkg/dpkg.inc > @@ -4,8 +4,6 @@ SECTION =3D "base" > =20 > SRC_URI =3D "${DEBIAN_MIRROR}/main/d/dpkg/dpkg_${PV}.tar.xz" > =20 > -SRC_URI_append_class-native =3D " file://0001-When-running-do_package_= write_deb-we-have-trees-of-h.patch" > - > DEPENDS =3D "zlib bzip2 perl ncurses" > DEPENDS_class-native =3D "bzip2-replacement-native zlib-native virtual= /update-alternatives-native gettext-native perl-native" > RDEPENDS_${PN} =3D "${VIRTUAL-RUNTIME_update-alternatives} xz run-post= insts perl" > diff --git a/meta/recipes-devtools/dpkg/dpkg/0001-When-running-do_packa= ge_write_deb-we-have-trees-of-h.patch b/meta/recipes-devtools/dpkg/dpkg/0= 001-When-running-do_package_write_deb-we-have-trees-of-h.patch > deleted file mode 100644 > index 49ef853..0000000 > --- a/meta/recipes-devtools/dpkg/dpkg/0001-When-running-do_package_writ= e_deb-we-have-trees-of-h.patch > +++ /dev/null > @@ -1,71 +0,0 @@ > -From e391bdba238d1371fc5b67cdae08b06eb5ada5c2 Mon Sep 17 00:00:00 2001= > -From: Alexander Kanavin > -Date: Wed, 26 Aug 2015 15:48:13 +0300 > -Subject: [PATCH] When running do_package_write_deb, we have trees of > - hardlinked files such as the dbg source files in ${PN}-dbg. If someth= ing > - makes another copy of one of those files (or deletes one), the number= of > - links a file has changes and tar can notice this, e.g.: > - > -| DEBUG: Executing python function do_package_deb > -| dpkg-deb: building package `sed-ptest' in `/media/build1/poky/build/= tmp/work/i586-poky-linux/sed/4.2.2-r0/deploy-debs/i586/sed-ptest_4.2.2-r0= =2E3_i386.deb'. > -| tar: ./usr/lib/sed/ptest/testsuite/tst-regex2: file changed as we re= ad it > -| dpkg-deb: error: subprocess tar -cf returned error exit status 1 > - > -Tar returns an error of 1 when files 'change' and other errors codes > -in other error cases. We tweak dpkg-deb here so that it ignores an exi= t > -code of 1 from tar. The files don't really change (and we have locking= in > -place to avoid that kind of issue). > - > -Upstream-Status: Inappropriate > -RP 2015/3/27 > ---- > - dpkg-deb/build.c | 12 ++++++++---- > - 1 file changed, 8 insertions(+), 4 deletions(-) > - > -diff --git a/dpkg-deb/build.c b/dpkg-deb/build.c > -index 2ddeec6..af363f0 100644 > ---- a/dpkg-deb/build.c > -+++ b/dpkg-deb/build.c > -@@ -452,7 +452,7 @@ static void > - tarball_pack(const char *dir, filenames_feed_func *tar_filenames_feed= er, > - struct compress_params *tar_compress_params, int fd_out)= > - { > -- int pipe_filenames[2], pipe_tarball[2]; > -+ int pipe_filenames[2], pipe_tarball[2], rc; > - pid_t pid_tar, pid_comp; > -=20 > - /* Fork off a tar. We will feed it a list of filenames on stdin lat= er. */ > -@@ -493,7 +493,9 @@ tarball_pack(const char *dir, filenames_feed_func = *tar_filenames_feeder, > - /* All done, clean up wait for tar and to finish their j= ob. */ > - close(pipe_filenames[1]); > - subproc_reap(pid_comp, _(" from tar -cf"), 0); > -- subproc_reap(pid_tar, "tar -cf", 0); > -+ rc =3D subproc_reap(pid_tar, "tar -cf", SUBPROC_RETERROR); > -+ if (rc && rc !=3D 1) > -+ ohshite(_("subprocess %s returned error exit status %d"), "tar -c= f", rc); > - } > -=20 > - /** > -@@ -509,7 +511,7 @@ do_build(const char *const *argv) > - char *debar; > - char *tfbuf; > - int arfd; > -- int p1[2], gzfd; > -+ int p1[2], gzfd, rc; > - pid_t c1, c2; > -=20 > - /* Decode our arguments. */ > -@@ -590,7 +592,9 @@ do_build(const char *const *argv) > - } > - close(p1[0]); > - subproc_reap(c2, _(" from tar -cf"), 0); > -- subproc_reap(c1, "tar -cf", 0); > -+ rc =3D subproc_reap(c1, "tar -cf", SUBPROC_RETERROR); > -+ if (rc && rc !=3D 1) > -+ ohshite(_("subprocess %s returned error exit status %d"), "tar -c= f", rc); > -=20 > - if (lseek(gzfd, 0, SEEK_SET)) > - ohshite(_("failed to rewind temporary file (%s)"), _("control mem= ber")); > ---=20 > -2.7.0 > - > diff --git a/meta/recipes-devtools/dpkg/dpkg/0003-Our-pre-postinsts-exp= ect-D-to-be-set-when-running-in.patch b/meta/recipes-devtools/dpkg/dpkg/0= 003-Our-pre-postinsts-expect-D-to-be-set-when-running-in.patch > index 9f77c6c..80504ce 100644 > --- a/meta/recipes-devtools/dpkg/dpkg/0003-Our-pre-postinsts-expect-D-t= o-be-set-when-running-in.patch > +++ b/meta/recipes-devtools/dpkg/dpkg/0003-Our-pre-postinsts-expect-D-t= o-be-set-when-running-in.patch > @@ -8,30 +8,41 @@ Subject: [PATCH 3/5] Our pre/postinsts expect $D to b= e set when running in a > Upstream-Status: Inappropriate [OE Specific] > =20 > RP 2011/12/07 > +ALIMON 2016/05/26 > + > --- > - src/script.c | 31 ++----------------------------- > - 1 file changed, 2 insertions(+), 29 deletions(-) > + src/script.c | 39 +++------------------------------------ > + 1 file changed, 3 insertions(+), 36 deletions(-) > =20 > diff --git a/src/script.c b/src/script.c > -index a958145..24c49f9 100644 > +index 3c88be8..ce66a86 100644 > --- a/src/script.c > +++ b/src/script.c > -@@ -100,36 +100,9 @@ maintscript_pre_exec(struct command *cmd) > - size_t instdirl =3D strlen(instdir); > -=20 > - if (*instdir) { > +@@ -97,43 +97,10 @@ setexecute(const char *path, struct stat *stab) > + static const char * > + maintscript_pre_exec(struct command *cmd) > + { > +- const char *admindir =3D dpkg_db_get_dir(); > +- const char *changedir =3D fc_script_chrootless ? instdir : "/"; > +- size_t instdirl =3D strlen(instdir); > +- > +- if (*instdir && !fc_script_chrootless) { > - if (strncmp(admindir, instdir, instdirl) !=3D 0) > - ohshit(_("admindir must be inside instdir for dpkg to work properl= y")); > - if (setenv("DPKG_ADMINDIR", admindir + instdirl, 1) < 0) > - ohshite(_("unable to setenv for subprocesses")); > +- if (setenv("DPKG_ROOT", "", 1) < 0) > +- ohshite(_("unable to setenv for subprocesses")); > - > - if (chroot(instdir)) > - ohshite(_("failed to chroot to '%.250s'"), instdir); > -- } > ++ if (*instdir) { > ++ setenv("D", instdir, 1); > + } > - /* Switch to a known good directory to give the maintainer script > - * a saner environment, also needed after the chroot(). */ > -- if (chdir("/")) > -- ohshite(_("failed to chdir to '%.255s'"), "/"); > +- if (chdir(changedir)) > +- ohshite(_("failed to chdir to '%.255s'"), changedir); > - if (debug_has_flag(dbg_scripts)) { > - struct varbuf args =3D VARBUF_INIT; > - const char **argv =3D cmd->argv; > @@ -44,9 +55,8 @@ index a958145..24c49f9 100644 > - debug(dbg_scripts, "fork/exec %s (%s )", cmd->filename, > - args.buf); > - varbuf_destroy(&args); > -+ setenv("D", instdir, 1); > - } > -- if (!instdirl) > +- } > +- if (!instdirl || fc_script_chrootless) > - return cmd->filename; > - > - assert(strlen(cmd->filename) >=3D instdirl); > diff --git a/meta/recipes-devtools/dpkg/dpkg/add_armeb_triplet_entry.pa= tch b/meta/recipes-devtools/dpkg/dpkg/add_armeb_triplet_entry.patch > index af275de..dc69eb2 100644 > --- a/meta/recipes-devtools/dpkg/dpkg/add_armeb_triplet_entry.patch > +++ b/meta/recipes-devtools/dpkg/dpkg/add_armeb_triplet_entry.patch > @@ -25,14 +25,22 @@ Upstream-Status: Pending > =20 > Signed-off-by: Krishnanjanappa, Jagadeesh > =20 > -diff -Naurp dpkg-1.17.21_org/triplettable dpkg-1.17.21/triplettable > ---- dpkg-1.17.21_org/triplettable 2015-04-08 17:08:52.370759171 +0530 > -+++ dpkg-1.17.21/triplettable 2015-04-08 17:09:12.406752081 +0530 > -@@ -9,6 +9,7 @@ musleabihf-linux-arm musl-linux-armhf > - musl-linux- musl-linux- > - gnueabihf-linux-arm armhf > +--- > + triplettable | 1 + > + 1 file changed, 1 insertion(+) > + > +diff --git a/triplettable b/triplettable > +index abe4726..1e9c247 100644 > +--- a/triplettable > ++++ b/triplettable > +@@ -11,6 +11,7 @@ gnueabihf-linux-arm armhf > gnueabi-linux-arm armel > + gnuabin32-linux-mips64r6el mipsn32r6el > + gnuabin32-linux-mips64r6 mipsn32r6 > +gnueabi-linux-armeb armeb > gnuabin32-linux-mips64el mipsn32el > gnuabin32-linux-mips64 mipsn32 > - gnuabi64-linux-mips64el mips64el > + gnuabi64-linux-mips64r6el mips64r6el > +--=20 > +2.1.4 > + > diff --git a/meta/recipes-devtools/dpkg/dpkg/fix-abs-redefine.patch b/m= eta/recipes-devtools/dpkg/dpkg/fix-abs-redefine.patch > deleted file mode 100644 > index e73311c..0000000 > --- a/meta/recipes-devtools/dpkg/dpkg/fix-abs-redefine.patch > +++ /dev/null > @@ -1,40 +0,0 @@ > -Upstream-Status: Pending > - > -dpkg defines: > -#define DPKG_BEGIN_DECLS extern "C" { > - > -That makes header cstdlib included in a extern "C" block which is not = supported > -by gcc 4.8. It fails on Fedora 19: > - > -/usr/include/c++/4.8.1/cstdlib: In function =E2=80=98long long int std= ::abs(long long int)=E2=80=99: > -/usr/include/c++/4.8.1/cstdlib:174:20: error: declaration of C functio= n =E2=80=98long long int std::abs(long long int)=E2=80=99 conflicts with > - abs(long long __x) { return __builtin_llabs (__x); } > - ^ > -/usr/include/c++/4.8.1/cstdlib:166:3: error: previous declaration =E2=80= =98long int std::abs(long int)=E2=80=99 here > - abs(long __i) { return __builtin_labs(__i); } > - ^ > - > -Move include gettext.h out of the extern "C" block to fix this issue. > - > -Signed-off-by: Kai Kang > - > ---- dpkg-1.17.1/lib/dpkg/i18n.h.orig 2013-08-13 17:31:28.870935573 +08= 00 > -+++ dpkg-1.17.1/lib/dpkg/i18n.h 2013-08-13 17:31:37.893065249 +0800 > -@@ -23,8 +23,6 @@ > -=20 > - #include > -=20 > --DPKG_BEGIN_DECLS > -- > - /** > - * @defgroup i18n Internationalization support > - * @ingroup dpkg-internal > -@@ -33,6 +31,8 @@ > -=20 > - #include > -=20 > -+DPKG_BEGIN_DECLS > -+ > - /* We need to include this because pgettext() uses LC_MESSAGES, but l= ibintl.h > - * which gets pulled by gettext.h only includes it if building optimi= zed. */ > - #include > diff --git a/meta/recipes-devtools/dpkg/dpkg_1.18.4.bb b/meta/recipes-d= evtools/dpkg/dpkg_1.18.7.bb > similarity index 79% > rename from meta/recipes-devtools/dpkg/dpkg_1.18.4.bb > rename to meta/recipes-devtools/dpkg/dpkg_1.18.7.bb > index 7876944..5375923 100644 > --- a/meta/recipes-devtools/dpkg/dpkg_1.18.4.bb > +++ b/meta/recipes-devtools/dpkg/dpkg_1.18.7.bb > @@ -4,7 +4,6 @@ LIC_FILES_CHKSUM =3D "file://COPYING;md5=3D751419260aa9= 54499f7abaabaa882bbe" > SRC_URI_append_class-native =3D" file://glibc2.5-sync_file_range.patch= " > SRC_URI +=3D "file://noman.patch \ > file://remove-tar-no-timestamp.patch \ > - file://fix-abs-redefine.patch \ > file://arch_pm.patch \ > file://dpkg-configure.service \ > file://add_armeb_triplet_entry.patch \ > @@ -15,6 +14,5 @@ SRC_URI +=3D "file://noman.patch \ > file://0006-add-musleabi-to-known-target-tripets.patch \ > " > =20 > -SRC_URI[md5sum] =3D "e95b513c89693f6ec3ab53b6b1c3defd" > -SRC_URI[sha256sum] =3D "fe89243868888ce715bf45861f26264f767d4e4dbd0d6f= 1a26ce60bbbbf106da" > - > +SRC_URI[md5sum] =3D "073dbf2129a54b0fc627464bf8af4a1b" > +SRC_URI[sha256sum] =3D "ace36d3a6dc750a42baf797f9e75ec580a21f92bb9ff96= b482100755d6d9b87b" >=20 --FluVgaLAuwXHJqlCu0xIMtJ9CbqC7tjan Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJXUYkIAAoJEGJqcE9h3glgUiYP/3gFuFFUcjqmWQE86DrtA4Fs 9ZCoKX8iKBphDlT2Hpb/ZhPVT7lYH+GiGuPJ19VXXf8XDS2PC9aPzwGXCB2y/AZZ H5JnArImkQ8wdgUohzgbqiGX7ObXVfSySL3CDSZKQkf0mUiCcE7My0jN2lSzRq3S KXC3MEY76/KRrJVPrBjXf4xsJt7Dnh7BuwjjPFfPfNsu7X1WKCKpjjJDKo9dwb/g vOY3pEIjmmo9waXMf45bN6fnpukavRSt7jovB4TuIt/h6AyGImpde8orvSuYB7sd kQJuuggDk0Xnm0CDINUnS5MRW2BgbqgnTsCAJolp6NCNymBtPRyu9gkeqAzuQ/G4 LD+3k4xrxGI+XYbXzhcTaia0NuCqQ+YSaUHSvFWKMCA0QB7L1nK/cRYEQKRPGYNr qtqUllgitzcPO0Q1CEOlDDp8zuykjjR7tElJ1Qz2gfQMZiv2b/hkW4ploFhy6GHX qxFnRnGfKt3LEh/9U9U1Yu7mvIS1+FzauPak+WmzAJjWsweHXKriXxwvr9mzSKP9 g47ePSw7GstNGC4xErYH+zlPsPN1Xrnl8AGNEaxnxxkpRtDMrxggBlYfNa0y1PSO zofx9YbXuTWU/O//09eO/LMg0U/frhZvIV9RRsqWVDW2J23OFyR8c691oytMLk7P frgQmq31fXbCBH45UHCe =Qbfv -----END PGP SIGNATURE----- --FluVgaLAuwXHJqlCu0xIMtJ9CbqC7tjan--