From: Jens Axboe <axboe@kernel.dk>
To: Baolin Wang <baolin.wang@linaro.org>,
agk@redhat.com, snitzer@redhat.com, dm-devel@redhat.com,
herbert@gondor.apana.org.au, davem@davemloft.net
Cc: ebiggers3@gmail.com, js1304@gmail.com, tadeusz.struk@intel.com,
smueller@chronox.de, standby24x7@gmail.com, shli@kernel.org,
dan.j.williams@intel.com, martin.petersen@oracle.com,
sagig@mellanox.com, kent.overstreet@gmail.com,
keith.busch@intel.com, tj@kernel.org, ming.lei@canonical.com,
broonie@kernel.org, arnd@arndb.de, linux-crypto@vger.kernel.org,
linux-block@vger.kernel.org, linux-raid@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC v2 1/3] block: Introduce blk_bio_map_sg() to map one bio
Date: Fri, 3 Jun 2016 08:38:40 -0600 [thread overview]
Message-ID: <57519670.6050306@kernel.dk> (raw)
In-Reply-To: <2f0f6811938dafd14c6c7b1dbe8fbabfdcbb19c1.1464346333.git.baolin.wang@linaro.org>
On 05/27/2016 05:11 AM, Baolin Wang wrote:
> +/*
> + * Map a bio to scatterlist, return number of sg entries setup. Caller must
> + * make sure sg can hold bio segments entries.
> + */
> +int blk_bio_map_sg(struct request_queue *q, struct bio *bio,
> + struct scatterlist *sglist)
> +{
> + struct scatterlist *sg = NULL;
> + int nsegs = 0;
> +
> + if (bio)
> + nsegs = __blk_bios_map_sg(q, bio, sglist, &sg, true);
> +
> + if (sg)
> + sg_mark_end(sg);
Put that if (sg) inside the if (bio) section, 'sg' isn't going to be
non-NULL outside of that.
Additionally, who would call this with a NULL bio? That seems odd, I'd
get rid of that check completely.
--
Jens Axboe
next prev parent reply other threads:[~2016-06-03 14:38 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-27 11:11 [RFC v2 0/3] Introduce the bulk mode method when sending request to crypto layer Baolin Wang
2016-05-27 11:11 ` [RFC v2 1/3] block: Introduce blk_bio_map_sg() to map one bio Baolin Wang
2016-06-03 14:35 ` Jens Axboe
2016-06-06 5:03 ` Baolin Wang
2016-06-06 5:03 ` Baolin Wang
2016-06-06 5:03 ` Baolin Wang
2016-06-03 14:38 ` Jens Axboe [this message]
2016-06-06 5:04 ` Baolin Wang
2016-06-06 5:04 ` Baolin Wang
2016-06-06 5:04 ` Baolin Wang
2016-05-27 11:11 ` [RFC v2 2/3] crypto: Introduce CRYPTO_ALG_BULK flag Baolin Wang
2016-06-02 8:26 ` Herbert Xu
2016-06-03 6:48 ` Baolin Wang
2016-06-03 6:48 ` Baolin Wang
2016-06-03 6:48 ` Baolin Wang
2016-06-03 6:51 ` Herbert Xu
2016-06-03 6:51 ` Herbert Xu
2016-06-03 6:51 ` Herbert Xu
2016-06-03 7:10 ` Baolin Wang
2016-06-03 7:10 ` Baolin Wang
2016-06-03 7:10 ` Baolin Wang
2016-06-03 7:54 ` Herbert Xu
2016-06-03 7:54 ` Herbert Xu
2016-06-03 7:54 ` Herbert Xu
2016-06-03 8:15 ` Baolin Wang
2016-06-03 8:15 ` Baolin Wang
2016-06-03 8:15 ` Baolin Wang
2016-06-03 8:21 ` Herbert Xu
2016-06-03 8:21 ` Herbert Xu
2016-06-03 8:21 ` Herbert Xu
2016-06-03 9:23 ` Baolin Wang
2016-06-03 9:23 ` Baolin Wang
2016-06-03 9:23 ` Baolin Wang
2016-06-03 10:09 ` Herbert Xu
2016-06-03 10:09 ` Herbert Xu
2016-06-03 10:09 ` Herbert Xu
2016-06-03 10:47 ` Baolin Wang
2016-06-03 10:47 ` Baolin Wang
2016-06-03 10:47 ` Baolin Wang
2016-05-27 11:11 ` [RFC v2 3/3] md: dm-crypt: Introduce the bulk mode method when sending request Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57519670.6050306@kernel.dk \
--to=axboe@kernel.dk \
--cc=agk@redhat.com \
--cc=arnd@arndb.de \
--cc=baolin.wang@linaro.org \
--cc=broonie@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=davem@davemloft.net \
--cc=dm-devel@redhat.com \
--cc=ebiggers3@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=js1304@gmail.com \
--cc=keith.busch@intel.com \
--cc=kent.overstreet@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@canonical.com \
--cc=sagig@mellanox.com \
--cc=shli@kernel.org \
--cc=smueller@chronox.de \
--cc=snitzer@redhat.com \
--cc=standby24x7@gmail.com \
--cc=tadeusz.struk@intel.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.