From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59224)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den@virtuozzo.com>) id 1b8qbL-00039z-JF
	for qemu-devel@nongnu.org; Fri, 03 Jun 2016 11:01:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <den@virtuozzo.com>) id 1b8qbH-0003Lv-Er
	for qemu-devel@nongnu.org; Fri, 03 Jun 2016 11:01:30 -0400
References: <1464957021-3469-1-git-send-email-kwolf@redhat.com>
	<1464957021-3469-6-git-send-email-kwolf@redhat.com>
From: "Denis V. Lunev" <den@openvz.org>
Message-ID: <57519BBE.5040204@openvz.org>
Date: Fri, 3 Jun 2016 18:01:18 +0300
MIME-Version: 1.0
In-Reply-To: <1464957021-3469-6-git-send-email-kwolf@redhat.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 5/5] qemu-img bench: Add --flush-interval
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org
Cc: mreitz@redhat.com, eblake@redhat.com, qemu-devel@nongnu.org

On 06/03/2016 03:30 PM, Kevin Wolf wrote:
> This options allows to flush the image periodically during write tests.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
This pattern could be a bit different - you wait requests to finish
and after that start flush. In this case there is no gain with my
patch ;)

You should treat flush as ordinary write request i.e. place
request immediately without waiting for writes to finish.
May be this could be specified as an operation mode.

Den