Re: [Qemu-devel] [PATCH 3/5] qcow2: Make copy_sectors() byte based

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1337 bytes --]

On 06/03/2016 11:21 AM, Kevin Wolf wrote:
> This will allow copy on write operations where the overwritten part of
> the cluster is not aligned to sector boundaries.
> 
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  block/qcow2-cluster.c | 37 +++++++++++++++++--------------------
>  1 file changed, 17 insertions(+), 20 deletions(-)
> 
> diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
> index 9fb7f9f..5d04eb7 100644
> --- a/block/qcow2-cluster.c
> +++ b/block/qcow2-cluster.c
> @@ -391,21 +391,17 @@ int qcow2_encrypt_sectors(BDRVQcow2State *s, int64_t sector_num,
>  }
>  
>  static int coroutine_fn copy_sectors(BlockDriverState *bs,
> -                                     uint64_t start_sect,
> +                                     uint64_t src_cluster_offset,
>                                       uint64_t cluster_offset,
> -                                     int n_start, int n_end)
> +                                     int offset_in_cluster,
> +                                     int bytes)

Do we still want this named copy_sectors(), now that it can copy a
sub-sector (well, when not encrypted)?

Otherwise,

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]