All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Arevalo, Mario Alfredo C" <mario.alfredo.c.arevalo@intel.com>,
	"Richardson, Bruce" <bruce.richardson@intel.com>,
	Panu Matilainen <pmatilai@redhat.com>,
	olivier.matz@6wind.com
Cc: dev@dpdk.org
Subject: Re: dpdk proposal installation process
Date: Fri, 27 Nov 2015 12:50:58 +0100	[thread overview]
Message-ID: <5752336.EctnB08yj1@xps13> (raw)
In-Reply-To: <6594B51DBE477C48AAE23675314E6C460F1B8B6E@fmsmsx107.amr.corp.intel.com>

2015-10-26 16:18, Arevalo, Mario Alfredo C:
> Hi Guys,
> 
> Thank you so much for your feedback, about your last comments,
> I understood the next:
> 
> 1)
> -"make install" using "T" variable:
> This command will use a rule for the current behaviour called "mbuild"

I think the ability of building several targets in one command make
the build system more complex than it should be.
A target should be defined by its configured options, not a default
template config.
So I suggest to drop it.

> -"make install" without "T" variable:
> This command will install everything: headers, libraries, modules, apps, docs, and
> sdk files (config files, make files, scripts and examples).
> 
> 2) About variables, you rigth, KMOD_DIR sounds better than KERNEL_DIR,
> and LIB_DIR should be /usr/lib by default.
> 
> 3)
> -To use a "prefix variable"
> -This prefix variable will be "/usr/local" by default.
> -This prefix variable can be overridden.
> 
> Example:
> $(DESTDIR)/$(PREFIX)/$(INCLUDE_DIR)

It is a good step.
In order to be more standard, we should try to comply with these guidelines:
https://www.gnu.org/prep/standards/html_node/Directory-Variables.html
https://www.gnu.org/prep/standards/html_node/DESTDIR.html

> 4) What do you think about the Bruce's proposal?

I love the idea of having a configure script.
I would add some checks to solve the dependencies (external and internal).

  parent reply	other threads:[~2015-11-27 11:52 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-20  0:21 dpdk proposal installation process Arevalo, Mario Alfredo C
2015-10-20  9:17 ` Bruce Richardson
2015-10-21 19:15   ` Olivier MATZ
2015-10-22  5:55     ` Panu Matilainen
2015-10-22 14:57       ` Bruce Richardson
2015-10-26 16:18         ` Arevalo, Mario Alfredo C
2015-10-27 14:25           ` compile and install using configure-make-make_install Bruce Richardson
2015-10-27 14:25             ` [RFC-PATCH 1/2] gen-build-mk: add "make install" option to build dir Bruce Richardson
2015-10-27 14:25             ` [RFC-PATCH 2/2] add example configure script Bruce Richardson
2015-11-03  7:35             ` compile and install using configure-make-make_install Panu Matilainen
2015-11-03 10:16               ` Bruce Richardson
2015-11-27 11:50           ` Thomas Monjalon [this message]
2015-11-27 13:16         ` dpdk proposal installation process Marc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5752336.EctnB08yj1@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=mario.alfredo.c.arevalo@intel.com \
    --cc=olivier.matz@6wind.com \
    --cc=pmatilai@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.