From: Jan Kiszka <jan.kiszka@web.de>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] rtlwifi: Change long delays to sleeps
Date: Sat, 4 Jun 2016 22:02:51 +0200 [thread overview]
Message-ID: <575333EB.1060101@web.de> (raw)
In-Reply-To: <87fusssxqn.fsf@kamboji.qca.qualcomm.com>
[-- Attachment #1.1: Type: text/plain, Size: 1034 bytes --]
On 2016-06-04 18:52, Kalle Valo wrote:
> Jan Kiszka <jan.kiszka@web.de> writes:
>
>> On 2016-02-15 23:12, Larry Finger wrote:
>>> Routine rtl_addr_delay() uses delay statements in code that can
>>> sleep. To improve system responsiveness, the various delay statements
>>> are changed.
>>>
>>> In addition, routines rtl_rfreg_delay() and rtl_bb_delay() are
>>> rewritten to use the code in rtl_addr_delay() for most of their
>>> input values.
>>>
>>> Suggested-by: Byeoungwook Kim <quddnr145@gmail.com>
>>> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
>
> [...]
>
>> This breaks spectacularly when turning on a little bit of correctness
>> checking:
>>
>> BUG: scheduling while atomic: wpa_supplicant/1116/0x00000002
>
> This should fix it:
>
> https://git.kernel.org/cgit/linux/kernel/git/kvalo/wireless-drivers.git/commit/?id=de26859dcf363d520cc44e59f6dcaf20ebe0aadf
>
Probably, will test later. But you should really work on making all
these task-context-only. Threaded IRQs?
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
prev parent reply other threads:[~2016-06-04 20:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-15 22:12 [PATCH] rtlwifi: Change long delays to sleeps Larry Finger
2016-02-16 6:17 ` Souptick Joarder
2016-02-16 16:02 ` Larry Finger
2016-02-20 5:48 ` ByeoungWook Kim
2016-02-20 14:06 ` Larry Finger
2016-02-20 14:29 ` ByeoungWook Kim
2016-03-07 12:13 ` Kalle Valo
2016-06-04 16:40 ` [PATCH] " Jan Kiszka
2016-06-04 16:52 ` Kalle Valo
2016-06-04 20:02 ` Jan Kiszka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=575333EB.1060101@web.de \
--to=jan.kiszka@web.de \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.