From: David Ranch <linux-hams@trinnet.net>
To: Basil Gunn <basil@pacabunga.com>, linux-hams@vger.kernel.org
Cc: davem@davemloft.net
Subject: Re: Can only connect to RMS gateway once
Date: Sat, 4 Jun 2016 13:57:17 -0700 [thread overview]
Message-ID: <575340AD.5090604@trinnet.net> (raw)
In-Reply-To: <20160604134348.38e3c4dd@brox.localnet>
+ David Miller for comments
I see a change on June 25, 2015, and a few others on that file that seem
like they could be the issue:
https://github.com/torvalds/linux/commits/master/net/ax25/af_ax25.c
--David
On 06/04/2016 01:43 PM, Basil Gunn wrote:
> This isn't a final solution but the problem is in:
>
> sock_set_flag(sk, SOCK_DESTROY);
>
> in routine ax25_release() in file net/ax25/af_ax25.c which does what it
> is supposed to do in kernel 4.1.21 but NOT in kernels 4.2.8 & above. It
> should destroy & free the socket when disconnecting.
>
> For my 4.2.8 kernel If I add this after the sock_set_flag() call in
> ax25_release() then the connection is released after disconnect & I can
> reconnect again.
>
> release_sock(sk);
> ax25_disconnect(ax25, 0);
> lock_sock(sk);
> ax25_destroy_socket(ax25);
>
> >From the af_ax25 code in the 4.1.21 kernel, it expects sock_set_flag(sk, SOCK_DESTROY); to
> ax25_destroy_socket
> ax25_free_sock
>
>
>> /Basil n7nix
> --
> To unsubscribe from this list: send the line "unsubscribe linux-hams" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-06-04 20:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-03 20:16 Can only connect to RMS gateway once Basil Gunn
2016-06-03 23:45 ` David Ranch
2016-06-04 20:43 ` Basil Gunn
2016-06-04 20:57 ` David Ranch [this message]
2016-06-04 21:32 ` Basil Gunn
2016-06-05 23:46 ` Basil Gunn
-- strict thread matches above, loose matches on Subject: below --
2016-06-02 19:46 Basil Gunn
2016-06-03 0:01 ` David Ranch
2016-06-03 8:19 ` Thomas Osterried
2016-06-03 15:52 ` David Ranch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=575340AD.5090604@trinnet.net \
--to=linux-hams@trinnet.net \
--cc=basil@pacabunga.com \
--cc=davem@davemloft.net \
--cc=linux-hams@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.