From: Larry Finger <Larry.Finger@lwfinger.net>
To: Guenter Roeck <linux@roeck-us.net>, Kalle Valo <kvalo@codeaurora.org>
Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org,
b43-dev@lists.infradead.org, netdev@vger.kernel.org, m@bues.ch
Subject: [PATCH v3 1/2] b43: Remove unused phy_a code
Date: Sat, 4 Jun 2016 16:23:27 -0500 [thread overview]
Message-ID: <575346CF.9040003@lwfinger.net> (raw)
In-Reply-To: <1465052053-26740-1-git-send-email-linux@roeck-us.net>
On 06/04/2016 09:54 AM, Guenter Roeck wrote:
> gcc-6 reports the following error with -Werror=unused-const-variable.
>
> drivers/net/wireless/broadcom/b43/phy_a.c:576:40: error:
> 'b43_phyops_a' defined but not used
>
> Per Michael B?sch: "All a-phy code is usused", so remove it all,
> and move the remaining Type-G initialization code into phy_g.c.
>
> Reported-by: Fengguang Wu <fengguang.wu@intel.com> [0-day test robot]
> Cc: Michael B?sch <m@bues.ch>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> v3: Do not rename b43_phy_inita()
> v2: Remove phy_a.c; move left-over code into phy_g.c
> Remove now unused data structure
These two patches have been tested on a BCM4318.
Larry
WARNING: multiple messages have this Message-ID (diff)
From: Larry Finger <Larry.Finger@lwfinger.net>
To: Guenter Roeck <linux@roeck-us.net>, Kalle Valo <kvalo@codeaurora.org>
Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org,
b43-dev@lists.infradead.org, netdev@vger.kernel.org, m@bues.ch
Subject: Re: [PATCH v3 1/2] b43: Remove unused phy_a code
Date: Sat, 4 Jun 2016 16:23:27 -0500 [thread overview]
Message-ID: <575346CF.9040003@lwfinger.net> (raw)
In-Reply-To: <1465052053-26740-1-git-send-email-linux@roeck-us.net>
On 06/04/2016 09:54 AM, Guenter Roeck wrote:
> gcc-6 reports the following error with -Werror=unused-const-variable.
>
> drivers/net/wireless/broadcom/b43/phy_a.c:576:40: error:
> 'b43_phyops_a' defined but not used
>
> Per Michael Büsch: "All a-phy code is usused", so remove it all,
> and move the remaining Type-G initialization code into phy_g.c.
>
> Reported-by: Fengguang Wu <fengguang.wu@intel.com> [0-day test robot]
> Cc: Michael Büsch <m@bues.ch>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> v3: Do not rename b43_phy_inita()
> v2: Remove phy_a.c; move left-over code into phy_g.c
> Remove now unused data structure
These two patches have been tested on a BCM4318.
Larry
next prev parent reply other threads:[~2016-06-04 21:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-04 14:54 [PATCH v3 1/2] b43: Remove unused phy_a code Guenter Roeck
2016-06-04 14:54 ` Guenter Roeck
2016-06-04 14:54 ` Guenter Roeck
2016-06-04 14:54 ` [PATCH v3 2/2] b43: Completely remove support for phy_a Guenter Roeck
2016-06-04 14:54 ` Guenter Roeck
2016-06-04 14:54 ` Guenter Roeck
2016-06-04 21:23 ` Larry Finger [this message]
2016-06-04 21:23 ` [PATCH v3 1/2] b43: Remove unused phy_a code Larry Finger
2016-06-16 15:23 ` [v3,1/2] " Kalle Valo
2016-06-16 15:23 ` Kalle Valo
2016-06-16 15:48 ` Michael Büsch
2016-06-16 15:48 ` Michael Büsch
2016-06-16 15:56 ` Kalle Valo
2016-06-16 15:56 ` Kalle Valo
2016-06-16 16:05 ` Michael Büsch
2016-06-16 16:05 ` Michael Büsch
2016-06-16 15:23 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=575346CF.9040003@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=b43-dev@lists.infradead.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=m@bues.ch \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.