All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stanislas Bach <sbach@0g.re>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] xserver_xorg-server: apply modesettings patch for 1.18.3 only
Date: Sun, 5 Jun 2016 15:54:58 -0700	[thread overview]
Message-ID: <5754ADC2.4070209@0g.re> (raw)
In-Reply-To: <87y46jl7ek.fsf@dell.be.48ers.dk>

Hello Peter,

To give more details about this patch, I found the error while trying to 
configure/compile a root-filesystem for a Tegra2 platform:
When enabling BR2_PACKAGE_NVIDIA_TEGRA23, one must select 
BR2_PACKAGE_XSERVER_XORG_SERVER_VIDEODRV_ABI_14 causing the issue.

On 06/05/2016 01:14 PM, Peter Korsgaard wrote:
>>>>>> "Stanislas" == Stanislas Bach <sbach@0g.re> writes:
>
>   > We currently have two choices for the server's version (1.18.3, and 1.14.7)
>   > but the following patch will only apply for versions >= 1.17.2.
>
>   > If 1.14.7 is selected the build will fail with the following error:
>
>   > Applying 0001-modesettings-needs-dri2.patch using patch:
>   > patching file configure.ac
>   > Hunk #1 FAILED at 2036
>
>   > So move this patch to an appropriate version folder in the package's
>   > directory. It should be good enough until this package provides more
>   > versions >= 1.17.2.
>
>   > Signed-off-by: Stanislas Bach <sbach@0g.re>
>
>   > diff --git
>   > a/package/x11r7/xserver_xorg-server/0001-modesettings-needs-dri2.patch
>   > b/package/x11r7/xserver_xorg-server/0001-modesettings-needs-dri2.patch
>
> Thanks! Your mailer unfortunately corrupted the patch so I couldn't
> apply this directly. It would also be helpful for reviews if you
> configure git to detect renames (git config --global diff.renames copy -
> Or simply upgrade your git version, as it is enabled by default
> nowadays).

Sorry, and thank you for the advice, I will be careful next time in 
order to ease your work.

> Committed with the patch fixed, thanks.

Thanks for accepting it!

-- 
Stanislas Bach
GPG / D0B7 1846 5B5F 224F AF81

      reply	other threads:[~2016-06-05 22:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-04 21:15 [Buildroot] [PATCH] xserver_xorg-server: apply modesettings patch for 1.18.3 only Stanislas Bach
2016-06-05 20:14 ` Peter Korsgaard
2016-06-05 22:54   ` Stanislas Bach [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5754ADC2.4070209@0g.re \
    --to=sbach@0g.re \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.