From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f68.google.com ([74.125.82.68]:35621 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751376AbcFFHHy (ORCPT ); Mon, 6 Jun 2016 03:07:54 -0400 Received: by mail-wm0-f68.google.com with SMTP id k184so7573564wme.2 for ; Mon, 06 Jun 2016 00:07:53 -0700 (PDT) Subject: Re: [PATCH] lightnvm: Make functions not used by ouside static To: Johannes Thumshirn References: <1464963006-22721-1-git-send-email-jthumshirn@suse.de> Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org From: =?UTF-8?Q?Matias_Bj=c3=b8rling?= Message-ID: <57552146.4010300@bjorling.me> Date: Mon, 6 Jun 2016 09:07:50 +0200 MIME-Version: 1.0 In-Reply-To: <1464963006-22721-1-git-send-email-jthumshirn@suse.de> Content-Type: text/plain; charset=windows-1252; format=flowed Sender: linux-block-owner@vger.kernel.org List-Id: linux-block@vger.kernel.org On 06/03/2016 04:10 PM, Johannes Thumshirn wrote: > Mark functions not used by ouside of thier implementing file as static. > > Signed-off-by: Johannes Thumshirn > --- > drivers/lightnvm/core.c | 2 +- > drivers/lightnvm/sysblk.c | 8 +++++--- > 2 files changed, 6 insertions(+), 4 deletions(-) > > diff --git a/drivers/lightnvm/core.c b/drivers/lightnvm/core.c > index 0dc9a80..19577df 100644 > --- a/drivers/lightnvm/core.c > +++ b/drivers/lightnvm/core.c > @@ -98,7 +98,7 @@ static struct nvmm_type *nvm_find_mgr_type(const char *name) > return NULL; > } > > -struct nvmm_type *nvm_init_mgr(struct nvm_dev *dev) > +static struct nvmm_type *nvm_init_mgr(struct nvm_dev *dev) > { > struct nvmm_type *mt; > int ret; > diff --git a/drivers/lightnvm/sysblk.c b/drivers/lightnvm/sysblk.c > index b1e1404..ba2afe9 100644 > --- a/drivers/lightnvm/sysblk.c > +++ b/drivers/lightnvm/sysblk.c > @@ -39,7 +39,8 @@ static inline int scan_ppa_idx(int row, int blkid) > return (row * MAX_BLKS_PR_SYSBLK) + blkid; > } > > -void nvm_sysblk_to_cpu(struct nvm_sb_info *info, struct nvm_system_block *sb) > +static void nvm_sysblk_to_cpu(struct nvm_sb_info *info, > + struct nvm_system_block *sb) > { > info->seqnr = be32_to_cpu(sb->seqnr); > info->erase_cnt = be32_to_cpu(sb->erase_cnt); > @@ -48,7 +49,8 @@ void nvm_sysblk_to_cpu(struct nvm_sb_info *info, struct nvm_system_block *sb) > info->fs_ppa.ppa = be64_to_cpu(sb->fs_ppa); > } > > -void nvm_cpu_to_sysblk(struct nvm_system_block *sb, struct nvm_sb_info *info) > +static void nvm_cpu_to_sysblk(struct nvm_system_block *sb, > + struct nvm_sb_info *info) > { > sb->magic = cpu_to_be32(NVM_SYSBLK_MAGIC); > sb->seqnr = cpu_to_be32(info->seqnr); > @@ -86,7 +88,7 @@ static int nvm_setup_sysblks(struct nvm_dev *dev, struct ppa_addr *sysblk_ppas) > return nr_rows; > } > > -void nvm_setup_sysblk_scan(struct nvm_dev *dev, struct sysblk_scan *s, > +static void nvm_setup_sysblk_scan(struct nvm_dev *dev, struct sysblk_scan *s, > struct ppa_addr *sysblk_ppas) > { > memset(s, 0, sizeof(struct sysblk_scan)); > Thanks Johannes. Applied for 4.8.