From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52966)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hare@suse.de>) id 1b9pwv-0008Ci-L0
	for qemu-devel@nongnu.org; Mon, 06 Jun 2016 04:31:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <hare@suse.de>) id 1b9pwr-0008LK-LB
	for qemu-devel@nongnu.org; Mon, 06 Jun 2016 04:31:53 -0400
Received: from mx2.suse.de ([195.135.220.15]:33249)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <hare@suse.de>)
	id 1b9pwr-0008LB-Eg
	for qemu-devel@nongnu.org; Mon, 06 Jun 2016 04:31:49 -0400
References: <1465200062-13824-1-git-send-email-caoj.fnst@cn.fujitsu.com>
	<1465200062-13824-14-git-send-email-caoj.fnst@cn.fujitsu.com>
From: Hannes Reinecke <hare@suse.de>
Message-ID: <575534F4.4030703@suse.de>
Date: Mon, 6 Jun 2016 10:31:48 +0200
MIME-Version: 1.0
In-Reply-To: <1465200062-13824-14-git-send-email-caoj.fnst@cn.fujitsu.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v7 13/15] megasas: remove unnecessary
 megasas_use_msi()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Cao jin <caoj.fnst@cn.fujitsu.com>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>, Markus Armbruster <armbru@redhat.com>, Marcel Apfelbaum <marcel@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>

On 06/06/2016 10:01 AM, Cao jin wrote:
> megasas overwrite user configuration when msi_init fail to reflect inte=
rnal msi
> state, which is unsuitable. megasa_use_msi() is unnecessary, we can cal=
l
> msi_uninit() when unrealize, even no bother to call msi_enabled() first=
.
>=20
> cc: Hannes Reinecke <hare@suse.de>
> cc: Paolo Bonzini <pbonzini@redhat.com>
> cc: Markus Armbruster <armbru@redhat.com>
> cc: Marcel Apfelbaum <marcel@redhat.com>
> cc: Michael S. Tsirkin <mst@redhat.com>
>=20
> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> ---
>  hw/scsi/megasas.c | 15 +++------------
>  1 file changed, 3 insertions(+), 12 deletions(-)
>=20

Acked-by: Hannes Reinecke <hare@suse.com>

Cheers,

Hannes
--=20
Dr. Hannes Reinecke		   Teamlead Storage & Networking
hare@suse.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N=FCrnberg
GF: F. Imend=F6rffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG N=FCrnberg)