From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54329) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b9q39-0003Ik-Kh for qemu-devel@nongnu.org; Mon, 06 Jun 2016 04:38:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b9q34-0001Nf-Kp for qemu-devel@nongnu.org; Mon, 06 Jun 2016 04:38:18 -0400 Received: from [59.151.112.132] (port=60623 helo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b9q33-0001Jp-TF for qemu-devel@nongnu.org; Mon, 06 Jun 2016 04:38:14 -0400 References: <1465200062-13824-1-git-send-email-caoj.fnst@cn.fujitsu.com> <1465200062-13824-10-git-send-email-caoj.fnst@cn.fujitsu.com> <575533F8.2050208@suse.de> From: Cao jin Message-ID: <575537B0.1060807@cn.fujitsu.com> Date: Mon, 6 Jun 2016 16:43:28 +0800 MIME-Version: 1.0 In-Reply-To: <575533F8.2050208@suse.de> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v7 09/15] megasas: change msi/msix property type List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hannes Reinecke , qemu-devel@nongnu.org Cc: Paolo Bonzini , "Michael S. Tsirkin" , Markus Armbruster , Marcel Apfelbaum On 06/06/2016 04:27 PM, Hannes Reinecke wrote: > On 06/06/2016 10:00 AM, Cao jin wrote: >> @@ -2422,10 +2420,8 @@ static Property megasas_properties_gen1[] = { >> MEGASAS_DEFAULT_FRAMES), >> DEFINE_PROP_STRING("hba_serial", MegasasState, hba_serial), >> DEFINE_PROP_UINT64("sas_address", MegasasState, sas_addr, 0), >> - DEFINE_PROP_BIT("use_msi", MegasasState, flags, >> - MEGASAS_FLAG_USE_MSI, false), >> - DEFINE_PROP_BIT("use_msix", MegasasState, flags, >> - MEGASAS_FLAG_USE_MSIX, false), >> + DEFINE_PROP_ON_OFF_AUTO("msi", MegasasState, msi, ON_OFF_AUTO_AUTO), >> + DEFINE_PROP_ON_OFF_AUTO("msix", MegasasState, msix, ON_OFF_AUTO_AUTO), >> DEFINE_PROP_BIT("use_jbod", MegasasState, flags, >> MEGASAS_FLAG_USE_JBOD, false), >> DEFINE_PROP_END_OF_LIST(), >> @@ -2438,10 +2434,8 @@ static Property megasas_properties_gen2[] = { >> MEGASAS_GEN2_DEFAULT_FRAMES), >> DEFINE_PROP_STRING("hba_serial", MegasasState, hba_serial), >> DEFINE_PROP_UINT64("sas_address", MegasasState, sas_addr, 0), >> - DEFINE_PROP_BIT("use_msi", MegasasState, flags, >> - MEGASAS_FLAG_USE_MSI, true), >> - DEFINE_PROP_BIT("use_msix", MegasasState, flags, >> - MEGASAS_FLAG_USE_MSIX, true), >> + DEFINE_PROP_ON_OFF_AUTO("msi", MegasasState, msi, ON_OFF_AUTO_AUTO), >> + DEFINE_PROP_ON_OFF_AUTO("msix", MegasasState, msix, ON_OFF_AUTO_AUTO), >> DEFINE_PROP_BIT("use_jbod", MegasasState, flags, >> MEGASAS_FLAG_USE_JBOD, false), >> DEFINE_PROP_END_OF_LIST(), >> > What is the default value of 'ON_OFF_AUTO_AUTO'? > Originally we've disabled MSI-X for gen1, and enabled it for gen2. > Is this behaviour carried over? > default value of auto is on. Seems the behaviour is not carried over. If it must be carried over, gen1 will be the only one exception in all devices, which seems little weird. is any special reason for gen1 to be msi/msix-incapable by default? > Cheers, > > Hannes > -- Yours Sincerely, Cao jin