From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35883) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b9qdA-0003kV-F1 for qemu-devel@nongnu.org; Mon, 06 Jun 2016 05:15:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b9qd5-0001AT-7U for qemu-devel@nongnu.org; Mon, 06 Jun 2016 05:15:31 -0400 Received: from [59.151.112.132] (port=24934 helo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b9qd3-0000qK-RJ for qemu-devel@nongnu.org; Mon, 06 Jun 2016 05:15:27 -0400 References: <1465200062-13824-1-git-send-email-caoj.fnst@cn.fujitsu.com> <1465200062-13824-12-git-send-email-caoj.fnst@cn.fujitsu.com> <57553419.7000801@suse.de> From: Cao jin Message-ID: <57554005.8070902@cn.fujitsu.com> Date: Mon, 6 Jun 2016 17:19:01 +0800 MIME-Version: 1.0 In-Reply-To: <57553419.7000801@suse.de> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v7 11/15] msi_init: change return value to 0 on success List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hannes Reinecke , qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Paolo Bonzini , Markus Armbruster , Marcel Apfelbaum On 06/06/2016 04:28 PM, Hannes Reinecke wrote: > On 06/06/2016 10:00 AM, Cao jin wrote: >> diff --git a/hw/scsi/mptsas.c b/hw/scsi/mptsas.c >> index 4ff4d06..d4773e2 100644 >> --- a/hw/scsi/mptsas.c >> +++ b/hw/scsi/mptsas.c >> @@ -1286,7 +1286,7 @@ static void mptsas_scsi_realize(PCIDevice *dev, Error **errp) >> "mptsas-diag", 0x10000); >> >> if (s->msi != ON_OFF_AUTO_OFF && >> - msi_init(dev, 0, 1, true, false) >= 0) { >> + msi_init(dev, 0, 1, true, false) > 0) { I am so sorry I made the mistake...it should be msi_init() == 0 >> /* TODO check for errors */ >> s->msi_in_use = true; >> } -- Yours Sincerely, Cao jin