From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH 07/23] drm: omapdrm: Handle FIFO underflow IRQs internally Date: Mon, 6 Jun 2016 13:50:13 +0300 Message-ID: <57555565.1020103@ti.com> References: <1461702945-14185-1-git-send-email-laurent.pinchart@ideasonboard.com> <1461702945-14185-8-git-send-email-laurent.pinchart@ideasonboard.com> <5730A1E3.9090305@ti.com> <3466075.vG1a1Uatp0@avalon> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0499975068==" Return-path: Received: from bear.ext.ti.com (bear.ext.ti.com [198.47.19.11]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4F60D6E163 for ; Mon, 6 Jun 2016 10:50:20 +0000 (UTC) In-Reply-To: <3466075.vG1a1Uatp0@avalon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0499975068== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="9Ch95BR4t1u8amlNnbc39qB5wnJJLikS3" --9Ch95BR4t1u8amlNnbc39qB5wnJJLikS3 Content-Type: multipart/mixed; boundary="G9KlLtCqh2EuoxqXCwurLfOeP7HMxfSo2" From: Tomi Valkeinen To: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org, Rob Clark Message-ID: <57555565.1020103@ti.com> Subject: Re: [PATCH 07/23] drm: omapdrm: Handle FIFO underflow IRQs internally References: <1461702945-14185-1-git-send-email-laurent.pinchart@ideasonboard.com> <1461702945-14185-8-git-send-email-laurent.pinchart@ideasonboard.com> <5730A1E3.9090305@ti.com> <3466075.vG1a1Uatp0@avalon> In-Reply-To: <3466075.vG1a1Uatp0@avalon> --G9KlLtCqh2EuoxqXCwurLfOeP7HMxfSo2 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/06/16 02:21, Laurent Pinchart wrote: >> Also, I do like it that we deal with crtc or plane interrupts in >> omap_crtc or omap_plane. Would similar approach here work as you use i= n >> the following patches, i.e. just call underflow-handler func in >> omap_plane.c directly, instead of using the registration mechanism? >=20 > I can do that, but given that all we do is just printing error messages= , it=20 > sounds a bit overkill. I propose moving FIFO underflow IRQ handling to = the=20 > CRTC and plane code later when/if we need to perform more work in the=20 > handlers. What's the overkill? Isn't it just making the function public, and calling that from omap_irq? And it's true your patch just prints an error message, but omap_irq_fifo_underflow() is still 35 lines, so it's not a one-liner. I don't feel strongly about this, though =3D). Tomi --G9KlLtCqh2EuoxqXCwurLfOeP7HMxfSo2-- --9Ch95BR4t1u8amlNnbc39qB5wnJJLikS3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXVVVlAAoJEPo9qoy8lh71290P/RbvDBBRopcgioIHndTAdZyq pBKBD3xedHKiBc0e6QxBxtViGYpX2t4LsInFLBOt/96O000QTw0Ex1GZObFvjwHT oIPluRQB/FlcnPSBVGH7pxYgamRyJSHqTst4pl5pYRedJLtMqM4bWUSY1hWOvRtJ M9R+DpGEsIPqDzq+B1sioYRzQfnubPQhfYUVNnVLIVLV4Eme0DzFa1KNnbRPjq0p O1P76u0hoZ0yIEdHnhW2ysbNJBCAs+FjdsgD55T2K2Y+bFDju8J4vOMpQaY+vZSb vMFJ0EhXlUz+e1YARM+Z3wOQDa40QThRT1wfrolFLSmMYXydIt09rh2C8VZQ1Yda datXF1Bz1RVREt/lpJIKAuRe7gDv987yIO3jjIOCvqA+2CEockHYY/pmhNm6Etg0 PGDuyWAAf5Slo5SxOwc2eVWrDVIZS4sHxR6aV/FH2n7IRDlTDIwgxGVKs8mqhuZk g4pWfc4DG24y3G3azuY6IY66Styc5Kw0KuKzKpVkEFiD7M5ecLe3CPDUxtGL4Szy 9GriM6cm7RUH6VYIO+kLeGDHrLGOvOLi+D0a2Q7Bc/qgaBpM44PyHs7hNVFES8Hk QUF363Klagjq31H5SVr+tupfyTnrqI+mRB2e93lJaEZPSe84U0TbswkI60dXU6xb cd4xPzI6uOG9ZnRy8UCK =OH/9 -----END PGP SIGNATURE----- --9Ch95BR4t1u8amlNnbc39qB5wnJJLikS3-- --===============0499975068== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0499975068==--