All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, Andrew Rybchenko <arybchenko@solarflare.com>,
	ophirmu@mellanox.com
Subject: Re: [PATCH] ethdev: fix iterator default behaviour for representors
Date: Wed, 24 Oct 2018 15:19:45 +0200	[thread overview]
Message-ID: <5755587.GAzGENloro@xps> (raw)
In-Reply-To: <20181024131321.8409-1-thomas@monjalon.net>

24/10/2018 15:13, Thomas Monjalon:
> The iterator was matching all representors if it was not specified
> in the devargs string. It was a wrong default behaviour.
> 
> If there is no representor parameter in the devargs, the iterator
> should not match any representor port.
> 
> The implementation of the default behaviour would be simpler
> if a "no match" handler is added to rte_kvargs_process().
> As it requires an API breakage, it will be reworked later.
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>

It is fixing the commit "support representor id as iterator filter"
which is in dpdk-next-net tree.
I think we should not squash them. It is fine to have both patches
separated with a clear explanation.
When the first commit will be in mainline, we could add a Fixes: tag
to this patch.

  reply	other threads:[~2018-10-24 13:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-24 13:13 [PATCH] ethdev: fix iterator default behaviour for representors Thomas Monjalon
2018-10-24 13:19 ` Thomas Monjalon [this message]
2018-10-25 12:59 ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5755587.GAzGENloro@xps \
    --to=thomas@monjalon.net \
    --cc=arybchenko@solarflare.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=ophirmu@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.