All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 4/5] armv8/ls2080: Remove workaround for erratum A008751
Date: Mon, 06 Jun 2016 14:25:08 +0200	[thread overview]
Message-ID: <57556BA4.4060601@denx.de> (raw)
In-Reply-To: <DB5PR0401MB2024C3EF170B435F1190635BF55C0@DB5PR0401MB2024.eurprd04.prod.outlook.com>

On 06/06/2016 06:23 AM, Sriram Dash wrote:
>> -----Original Message-----
>> From: Marek Vasut [mailto:marex at denx.de]
>> Sent: Thursday, June 02, 2016 6:28 PM
>> To: Sriram Dash <sriram.dash@nxp.com>; u-boot at lists.denx.de
>> Cc: york sun <york.sun@nxp.com>; albert.u.boot at aribaud.net; Rajesh Bhagat
>> <rajesh.bhagat@nxp.com>
>> Subject: Re: [PATCH v2 4/5] armv8/ls2080: Remove workaround for erratum
>> A008751
>>
>> On 06/02/2016 08:54 AM, Sriram Dash wrote:
>>> Remove the errata workaround from soc specific file for LS2080
>>
>> The commit message does not explain why this change is legal or needed.
>>
> 
> This errata a008751 is applied on Soc specific file currently.
> We are moving this errata to a a file where all the errata implementation will take Place for usb for fsl. Implementation of the errata will follow in Patch 5/5.
> 
> However, I cannot reference to the driver specific implementation till it is committed.
> So, this is just the description of removing the errata from soc specific file.

This explanation should be in the commit message.

>>> Signed-off-by: Sriram Dash <sriram.dash@nxp.com>
>>> Signed-off-by: Rajesh Bhagat <rajesh.bhagat@nxp.com>
>>> ---
>>> Changes in v2:
>>>   - No update
>>>
>>>
>>>  arch/arm/cpu/armv8/fsl-layerscape/soc.c | 10 ----------
>>>  1 file changed, 10 deletions(-)
>>>
>>> diff --git a/arch/arm/cpu/armv8/fsl-layerscape/soc.c
>>> b/arch/arm/cpu/armv8/fsl-layerscape/soc.c
>>> index 0fb5c7f..5636531 100644
>>> --- a/arch/arm/cpu/armv8/fsl-layerscape/soc.c
>>> +++ b/arch/arm/cpu/armv8/fsl-layerscape/soc.c
>>> @@ -122,15 +122,6 @@ void erratum_a009635(void)  }
>>>  #endif	/* CONFIG_SYS_FSL_ERRATUM_A009635 */
>>>
>>> -static void erratum_a008751(void)
>>> -{
>>> -#ifdef CONFIG_SYS_FSL_ERRATUM_A008751
>>> -	u32 __iomem *scfg = (u32 __iomem *)SCFG_BASE;
>>> -
>>> -	writel(0x27672b2a, scfg + SCFG_USB3PRM1CR / 4);
>>> -#endif
>>> -}
>>> -
>>>  static void erratum_rcw_src(void)
>>>  {
>>>  #if defined(CONFIG_SPL)
>>> @@ -187,7 +178,6 @@ void bypass_smmu(void)  }  void
>>> fsl_lsch3_early_init_f(void)  {
>>> -	erratum_a008751();
>>>  	erratum_rcw_src();
>>>  	init_early_memctl_regs();	/* tighten IFC timing */
>>>  	erratum_a009203();
>>>
>>
>>
>> --
>> Best regards,
>> Marek Vasut


-- 
Best regards,
Marek Vasut

  reply	other threads:[~2016-06-06 12:25 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-02  6:54 [U-Boot] [PATCH v2 0/5] Supporting ARM v8 USB errata for FSL Sriram Dash
2016-06-02  6:54 ` [U-Boot] [PATCH v2 1/5] arm64: fsl-layerscape: add get_svr and IS_SVR_REV helper Sriram Dash
2016-06-02 12:47   ` Marek Vasut
2016-06-06  4:21     ` Sriram Dash
2016-06-06 12:51       ` Marek Vasut
2016-06-08  4:12         ` Sriram Dash
2016-06-08 14:11           ` Marek Vasut
2016-06-02 12:48   ` Marek Vasut
2016-06-06  4:22     ` Sriram Dash
2016-06-02  6:54 ` [U-Boot] [PATCH v2 2/5] usb: xhci: fsl: code cleanup for device tree fixup for fsl usb controllers Sriram Dash
2016-06-02 12:55   ` Marek Vasut
2016-06-06  4:23     ` Sriram Dash
2016-06-02  6:54 ` [U-Boot] [PATCH v2 3/5] fsl: usb: make errata function common for PPC and ARM Sriram Dash
2016-06-02  6:54 ` [U-Boot] [PATCH v2 4/5] armv8/ls2080: Remove workaround for erratum A008751 Sriram Dash
2016-06-02 12:57   ` Marek Vasut
2016-06-06  4:23     ` Sriram Dash
2016-06-06 12:25       ` Marek Vasut [this message]
2016-06-02  6:54 ` [U-Boot] [PATCH v2 5/5] usb: xhci: fsl: Add workaround for USB erratum A-008751 Sriram Dash
2016-06-02 13:00   ` Marek Vasut
2016-06-06  4:24     ` Sriram Dash
2016-06-06 12:45       ` Marek Vasut
2016-06-08  4:12         ` Sriram Dash

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57556BA4.4060601@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.