From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752420AbcFFNE3 (ORCPT ); Mon, 6 Jun 2016 09:04:29 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:28806 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751965AbcFFNE0 convert rfc822-to-8bit (ORCPT ); Mon, 6 Jun 2016 09:04:26 -0400 Subject: Re: [PATCH 1/2] xen-pciback: return proper values during BAR sizing To: Jan Beulich , David Vrabel , Konrad Rzeszutek Wilk , Juergen Gross References: <57554B8D02000078000F1DE4@prv-mh.provo.novell.com> <57554C5D02000078000F1DF1@prv-mh.provo.novell.com> Cc: xen-devel , linux-kernel@vger.kernel.org From: Boris Ostrovsky Message-ID: <5755748D.6050900@oracle.com> Date: Mon, 6 Jun 2016 09:03:09 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <57554C5D02000078000F1DF1@prv-mh.provo.novell.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8BIT X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/06/2016 04:11 AM, Jan Beulich wrote: > @@ -225,38 +225,42 @@ static inline void read_dev_bar(struct p > (PCI_BASE_ADDRESS_SPACE_MEMORY | > PCI_BASE_ADDRESS_MEM_TYPE_64))) { > bar_info->val = res[pos - 1].start >> 32; > - bar_info->len_val = res[pos - 1].end >> 32; > + bar_info->len_val = -resource_size(&res[pos - 1]) >> 32; > return; > } > } > > + if (!res[pos].flags || > + (res[pos].flags & (IORESOURCE_DISABLED | IORESOURCE_UNSET | > + IORESOURCE_BUSY))) > + return; Why are you not making this check first thing in the routine? -boris From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Ostrovsky Subject: Re: [PATCH 1/2] xen-pciback: return proper values during BAR sizing Date: Mon, 6 Jun 2016 09:03:09 -0400 Message-ID: <5755748D.6050900@oracle.com> References: <57554B8D02000078000F1DE4@prv-mh.provo.novell.com> <57554C5D02000078000F1DF1@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9uBg-0006C2-B5 for xen-devel@lists.xenproject.org; Mon, 06 Jun 2016 13:03:24 +0000 In-Reply-To: <57554C5D02000078000F1DF1@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Jan Beulich , David Vrabel , Konrad Rzeszutek Wilk , Juergen Gross Cc: xen-devel , linux-kernel@vger.kernel.org List-Id: xen-devel@lists.xenproject.org T24gMDYvMDYvMjAxNiAwNDoxMSBBTSwgSmFuIEJldWxpY2ggd3JvdGU6Cj4gQEAgLTIyNSwzOCAr MjI1LDQyIEBAIHN0YXRpYyBpbmxpbmUgdm9pZCByZWFkX2Rldl9iYXIoc3RydWN0IHAKPiAgCQkJ ICAgKFBDSV9CQVNFX0FERFJFU1NfU1BBQ0VfTUVNT1JZIHwKPiAgCQkJCVBDSV9CQVNFX0FERFJF U1NfTUVNX1RZUEVfNjQpKSkgewo+ICAJCQliYXJfaW5mby0+dmFsID0gcmVzW3BvcyAtIDFdLnN0 YXJ0ID4+IDMyOwo+IC0JCQliYXJfaW5mby0+bGVuX3ZhbCA9IHJlc1twb3MgLSAxXS5lbmQgPj4g MzI7Cj4gKwkJCWJhcl9pbmZvLT5sZW5fdmFsID0gLXJlc291cmNlX3NpemUoJnJlc1twb3MgLSAx XSkgPj4gMzI7Cj4gIAkJCXJldHVybjsKPiAgCQl9Cj4gIAl9Cj4gIAo+ICsJaWYgKCFyZXNbcG9z XS5mbGFncyB8fAo+ICsJICAgIChyZXNbcG9zXS5mbGFncyAmIChJT1JFU09VUkNFX0RJU0FCTEVE IHwgSU9SRVNPVVJDRV9VTlNFVCB8Cj4gKwkJCSAgICAgICBJT1JFU09VUkNFX0JVU1kpKSkKPiAr CQlyZXR1cm47CgpXaHkgYXJlIHlvdSBub3QgbWFraW5nIHRoaXMgY2hlY2sgZmlyc3QgdGhpbmcg aW4gdGhlIHJvdXRpbmU/CgotYm9yaXMKCgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3Rz Lnhlbi5vcmcKaHR0cDovL2xpc3RzLnhlbi5vcmcveGVuLWRldmVsCg==