From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751524AbcFFNLF (ORCPT ); Mon, 6 Jun 2016 09:11:05 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:23728 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750933AbcFFNLD (ORCPT ); Mon, 6 Jun 2016 09:11:03 -0400 Subject: Re: [PATCH 3/2] xen-pciback: drop rom_init() To: Jan Beulich , David Vrabel , Konrad Rzeszutek Wilk , Juergen Gross References: <57554B8D02000078000F1DE4@prv-mh.provo.novell.com> <575554CC02000078000F1E3F@prv-mh.provo.novell.com> Cc: xen-devel , linux-kernel@vger.kernel.org From: Boris Ostrovsky Message-ID: <5755761D.4020204@oracle.com> Date: Mon, 6 Jun 2016 09:09:49 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <575554CC02000078000F1E3F@prv-mh.provo.novell.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/06/2016 04:47 AM, Jan Beulich wrote: > It's identical to bar_init() now. > > Signed-off-by: Jan Beulich > --- > I'm sorry for this 3/2 - I only now noticed that this additional > simplification is now possible. I wonder whether we should also move content of read_dev_bar() into bar_init(). Especially given that it's not really reading a BAR but rather initializing the stashed value. -boris From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Ostrovsky Subject: Re: [PATCH 3/2] xen-pciback: drop rom_init() Date: Mon, 6 Jun 2016 09:09:49 -0400 Message-ID: <5755761D.4020204@oracle.com> References: <57554B8D02000078000F1DE4@prv-mh.provo.novell.com> <575554CC02000078000F1E3F@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9uI4-0006xb-Vi for xen-devel@lists.xenproject.org; Mon, 06 Jun 2016 13:10:01 +0000 In-Reply-To: <575554CC02000078000F1E3F@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Jan Beulich , David Vrabel , Konrad Rzeszutek Wilk , Juergen Gross Cc: xen-devel , linux-kernel@vger.kernel.org List-Id: xen-devel@lists.xenproject.org T24gMDYvMDYvMjAxNiAwNDo0NyBBTSwgSmFuIEJldWxpY2ggd3JvdGU6Cj4gSXQncyBpZGVudGlj YWwgdG8gYmFyX2luaXQoKSBub3cuCj4KPiBTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJl dWxpY2hAc3VzZS5jb20+Cj4gLS0tCj4gSSdtIHNvcnJ5IGZvciB0aGlzIDMvMiAtIEkgb25seSBu b3cgbm90aWNlZCB0aGF0IHRoaXMgYWRkaXRpb25hbAo+IHNpbXBsaWZpY2F0aW9uIGlzIG5vdyBw b3NzaWJsZS4KCkkgd29uZGVyIHdoZXRoZXIgd2Ugc2hvdWxkIGFsc28gbW92ZSBjb250ZW50IG9m IHJlYWRfZGV2X2JhcigpIGludG8KYmFyX2luaXQoKS4gRXNwZWNpYWxseSBnaXZlbiB0aGF0IGl0 J3Mgbm90IHJlYWxseSByZWFkaW5nIGEgQkFSIGJ1dApyYXRoZXIgaW5pdGlhbGl6aW5nIHRoZSBz dGFzaGVkIHZhbHVlLgoKLWJvcmlzCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVu Lm9yZwpodHRwOi8vbGlzdHMueGVuLm9yZy94ZW4tZGV2ZWwK