Re: cipher, tls, and keys

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1538 bytes --]

Hi Mat,

On 06/06/2016 06:19 PM, Mat Martineau wrote:
>
> So far I've updated the asymmetric cipher code to work with the current
> version of the AF_ALG akcipher interface. This leaves the asymmetric
> cipher & tls disconnected from the new key/keyring code, which doesn't
> take advantage of the kernel's capabilities with akcipher and the keyring.
>
> We have three options:
>
> 1. The current code works, so leave it as-is. I took this approach first
> to minimize changes while I got it working.
>
> 2. Make use of the keyctl() crypto API that's under review. This has the
> clearest upstream path because it was implemented by the keyring
> maintainer. Would simplify l_asymmetric_cipher code and involve fewer
> syscalls.

I agree that keyctl is the one to use.  I would keep the asymmetric 
cipher classes the way they are, but remove the sign/verify operations. 
  Mmake tls depend on keyctl/keyring directly for sign/verify.

>
> 3. Continue with AF_ALG but make use of ALG_SET_KEY_ID and
> ALG_SET_PUB_KEY_ID to use keys already in a keyring. Would not be a big
> change, but the kernel patch set is a work in progress and much more
> uncertainty about upstream prospects / timing.

Lets follow these patches, and if they ever get upstreamed, then we can 
update the asymmetric_cipher API to support these operations, just for 
completeness sake.

>
>
> I like #2 because it makes for a clean API and simple userspace
> implementation. Anyone prefer other options?
>

Regards,
-Denis