From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark yao Subject: Re: [PATCH 1/2] drm/rockchip: vop: add uv_vir register field for RK3036 VOP Date: Tue, 7 Jun 2016 08:57:30 +0800 Message-ID: <57561BFA.5030000@rock-chips.com> References: <1465199912-20932-1-git-send-email-ykk@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1465199912-20932-1-git-send-email-ykk@rock-chips.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Yakir Yang , Mark Yao , Heiko Stuebner , David Airlie Cc: linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, tfiga@chromium.org List-Id: linux-rockchip.vger.kernel.org T24gMjAxNuW5tDA25pyIMDbml6UgMTU6NTgsIFlha2lyIFlhbmcgd3JvdGU6Cj4gVGhlIFdJTjAg b2YgUkszMDM2IFZPUCBjb3VsZCBzdXBwb3J0IFlVViBkYXRhIGZvcm1hdCwgYnV0IGRyaXZlcgo+ IGZvcmdldCB0byBhZGQgdGhlIHV2X3ZpciByZWdpc3RlciBmaWVsZCBmb3IgaXQuCj4KPiBTaWdu ZWQtb2ZmLWJ5OiBZYWtpciBZYW5nIDx5a2tAcm9jay1jaGlwcy5jb20+Cj4gLS0tCj4gICBkcml2 ZXJzL2dwdS9kcm0vcm9ja2NoaXAvcm9ja2NoaXBfdm9wX3JlZy5jIHwgMSArCj4gICAxIGZpbGUg Y2hhbmdlZCwgMSBpbnNlcnRpb24oKykKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v cm9ja2NoaXAvcm9ja2NoaXBfdm9wX3JlZy5jIGIvZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL3Jv Y2tjaGlwX3ZvcF9yZWcuYwo+IGluZGV4IDMxNjZiNDYuLjdkYTIzMTEgMTAwNjQ0Cj4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL3JvY2tjaGlwX3ZvcF9yZWcuYwo+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9yb2NrY2hpcC9yb2NrY2hpcF92b3BfcmVnLmMKPiBAQCAtMjEwLDYgKzIxMCw3 IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3Qgdm9wX3dpbl9waHkgcmszMDM2X3dpbjBfZGF0YSA9IHsK PiAgIAkueXJnYl9tc3QgPSBWT1BfUkVHKFJLMzAzNl9XSU4wX1lSR0JfTVNULCAweGZmZmZmZmZm LCAwKSwKPiAgIAkudXZfbXN0ID0gVk9QX1JFRyhSSzMwMzZfV0lOMF9DQlJfTVNULCAweGZmZmZm ZmZmLCAwKSwKPiAgIAkueXJnYl92aXIgPSBWT1BfUkVHKFJLMzAzNl9XSU4wX1ZJUiwgMHhmZmZm LCAwKSwKPiArCS51dl92aXIgPSBWT1BfUkVHKFJLMzAzNl9XSU4wX1ZJUiwgMHgxZmZmLCAxNiks Cj4gICB9Owo+ICAgCj4gICBzdGF0aWMgY29uc3Qgc3RydWN0IHZvcF93aW5fcGh5IHJrMzAzNl93 aW4xX2RhdGEgPSB7CgpUaGFua3MgZm9yIHRoaXMgZml4LCBBcHBsaWVkIHRvIG15IGRybS1maXhl cy4KCi0tIO+8rWFyayBZYW8KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2Ry aS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: mark.yao@rock-chips.com (Mark yao) Date: Tue, 7 Jun 2016 08:57:30 +0800 Subject: [PATCH 1/2] drm/rockchip: vop: add uv_vir register field for RK3036 VOP In-Reply-To: <1465199912-20932-1-git-send-email-ykk@rock-chips.com> References: <1465199912-20932-1-git-send-email-ykk@rock-chips.com> Message-ID: <57561BFA.5030000@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2016?06?06? 15:58, Yakir Yang wrote: > The WIN0 of RK3036 VOP could support YUV data format, but driver > forget to add the uv_vir register field for it. > > Signed-off-by: Yakir Yang > --- > drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_vop_reg.c b/drivers/gpu/drm/rockchip/rockchip_vop_reg.c > index 3166b46..7da2311 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_vop_reg.c > +++ b/drivers/gpu/drm/rockchip/rockchip_vop_reg.c > @@ -210,6 +210,7 @@ static const struct vop_win_phy rk3036_win0_data = { > .yrgb_mst = VOP_REG(RK3036_WIN0_YRGB_MST, 0xffffffff, 0), > .uv_mst = VOP_REG(RK3036_WIN0_CBR_MST, 0xffffffff, 0), > .yrgb_vir = VOP_REG(RK3036_WIN0_VIR, 0xffff, 0), > + .uv_vir = VOP_REG(RK3036_WIN0_VIR, 0x1fff, 16), > }; > > static const struct vop_win_phy rk3036_win1_data = { Thanks for this fix, Applied to my drm-fixes. -- ?ark Yao From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753364AbcFGA5p (ORCPT ); Mon, 6 Jun 2016 20:57:45 -0400 Received: from regular1.263xmail.com ([211.150.99.134]:48781 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753242AbcFGA5l (ORCPT ); Mon, 6 Jun 2016 20:57:41 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: mark.yao@rock-chips.com X-FST-TO: linux-arm-kernel@lists.infradead.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: mark.yao@rock-chips.com X-UNIQUE-TAG: <669c886c34a9a9f023e86dc0767123a6> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH 1/2] drm/rockchip: vop: add uv_vir register field for RK3036 VOP To: Yakir Yang , Mark Yao , Heiko Stuebner , David Airlie References: <1465199912-20932-1-git-send-email-ykk@rock-chips.com> Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, tfiga@chromium.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org From: Mark yao Message-ID: <57561BFA.5030000@rock-chips.com> Date: Tue, 7 Jun 2016 08:57:30 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1465199912-20932-1-git-send-email-ykk@rock-chips.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016年06月06日 15:58, Yakir Yang wrote: > The WIN0 of RK3036 VOP could support YUV data format, but driver > forget to add the uv_vir register field for it. > > Signed-off-by: Yakir Yang > --- > drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_vop_reg.c b/drivers/gpu/drm/rockchip/rockchip_vop_reg.c > index 3166b46..7da2311 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_vop_reg.c > +++ b/drivers/gpu/drm/rockchip/rockchip_vop_reg.c > @@ -210,6 +210,7 @@ static const struct vop_win_phy rk3036_win0_data = { > .yrgb_mst = VOP_REG(RK3036_WIN0_YRGB_MST, 0xffffffff, 0), > .uv_mst = VOP_REG(RK3036_WIN0_CBR_MST, 0xffffffff, 0), > .yrgb_vir = VOP_REG(RK3036_WIN0_VIR, 0xffff, 0), > + .uv_vir = VOP_REG(RK3036_WIN0_VIR, 0x1fff, 16), > }; > > static const struct vop_win_phy rk3036_win1_data = { Thanks for this fix, Applied to my drm-fixes. -- Ｍark Yao