From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Simek Subject: Re: [PATCH 7/9] pinctrl: zynq: make it explicitly non-modular Date: Tue, 7 Jun 2016 09:15:39 +0200 Message-ID: <5756749B.1080707@xilinx.com> References: <1465267388-17884-1-git-send-email-paul.gortmaker@windriver.com> <1465267388-17884-8-git-send-email-paul.gortmaker@windriver.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-sn1nam02on0056.outbound.protection.outlook.com ([104.47.36.56]:45242 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750893AbcFGHuI (ORCPT ); Tue, 7 Jun 2016 03:50:08 -0400 In-Reply-To: <1465267388-17884-8-git-send-email-paul.gortmaker@windriver.com> Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Paul Gortmaker , linux-kernel@vger.kernel.org Cc: Linus Walleij , Michal Simek , =?UTF-8?Q?S=c3=b6ren_Brinkmann?= , linux-gpio@vger.kernel.org On 7.6.2016 04:43, Paul Gortmaker wrote: > The Kconfig currently controlling compilation of this code is: >=20 > config PINCTRL_ZYNQ > bool "Pinctrl driver for Xilinx Zynq" >=20 > ...meaning that it currently is not being built as a module by anyone= =2E >=20 > Lets remove the modular code that is essentially orphaned, so that > when reading the driver there is no doubt it is builtin-only. >=20 > Since module_platform_driver() uses the same init level priority as > builtin_platform_driver() the init ordering remains unchanged with > this commit. >=20 > Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. >=20 > We also delete the MODULE_LICENSE tag etc. since all that information > is already contained at the top of the file in the comments. >=20 > Cc: Linus Walleij > Cc: Michal Simek > Cc: "S=C3=B6ren Brinkmann" > Cc: linux-gpio@vger.kernel.org > Signed-off-by: Paul Gortmaker > --- > drivers/pinctrl/pinctrl-zynq.c | 13 +------------ > 1 file changed, 1 insertion(+), 12 deletions(-) >=20 > diff --git a/drivers/pinctrl/pinctrl-zynq.c b/drivers/pinctrl/pinctrl= -zynq.c > index 8fdc60c5aeaf..7afdbede6823 100644 > --- a/drivers/pinctrl/pinctrl-zynq.c > +++ b/drivers/pinctrl/pinctrl-zynq.c > @@ -20,7 +20,7 @@ > */ > #include > #include > -#include > +#include > #include > #include > #include > @@ -1210,7 +1210,6 @@ static const struct of_device_id zynq_pinctrl_o= f_match[] =3D { > { .compatible =3D "xlnx,pinctrl-zynq" }, > { } > }; > -MODULE_DEVICE_TABLE(of, zynq_pinctrl_of_match); > =20 > static struct platform_driver zynq_pinctrl_driver =3D { > .driver =3D { > @@ -1225,13 +1224,3 @@ static int __init zynq_pinctrl_init(void) > return platform_driver_register(&zynq_pinctrl_driver); > } > arch_initcall(zynq_pinctrl_init); > - > -static void __exit zynq_pinctrl_exit(void) > -{ > - platform_driver_unregister(&zynq_pinctrl_driver); > -} > -module_exit(zynq_pinctrl_exit); > - > -MODULE_AUTHOR("S=C3=B6ren Brinkmann "); > -MODULE_DESCRIPTION("Xilinx Zynq pinctrl driver"); > -MODULE_LICENSE("GPL"); >=20 Acked-by: Michal Simek Thanks, Michal -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753377AbcFGHuL (ORCPT ); Tue, 7 Jun 2016 03:50:11 -0400 Received: from mail-sn1nam02on0056.outbound.protection.outlook.com ([104.47.36.56]:45242 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750893AbcFGHuI (ORCPT ); Tue, 7 Jun 2016 03:50:08 -0400 X-Greylist: delayed 2061 seconds by postgrey-1.27 at vger.kernel.org; Tue, 07 Jun 2016 03:50:08 EDT Authentication-Results: spf=pass (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; windriver.com; dkim=none (message not signed) header.d=none;windriver.com; dmarc=bestguesspass action=none header.from=xilinx.com; Subject: Re: [PATCH 7/9] pinctrl: zynq: make it explicitly non-modular To: Paul Gortmaker , References: <1465267388-17884-1-git-send-email-paul.gortmaker@windriver.com> <1465267388-17884-8-git-send-email-paul.gortmaker@windriver.com> CC: Linus Walleij , Michal Simek , =?UTF-8?Q?S=c3=b6ren_Brinkmann?= , From: Michal Simek Message-ID: <5756749B.1080707@xilinx.com> Date: Tue, 7 Jun 2016 09:15:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <1465267388-17884-8-git-send-email-paul.gortmaker@windriver.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.0.0.1202-22376.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:149.199.60.100;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(189002)(199003)(24454002)(86362001)(80316001)(106466001)(8936002)(65806001)(36756003)(4326007)(8676002)(2870700001)(64126003)(47776003)(77096005)(19580395003)(83506001)(23676002)(2950100001)(586003)(87936001)(19580405001)(50986999)(11100500001)(92566002)(65956001)(54356999)(63266004)(81156014)(81166006)(50466002)(33656002)(6806005)(2906002)(9786002)(5008740100001)(65816999)(36386004)(99136001)(59896002)(76176999)(4001350100001)(87266999)(189998001)(5001770100001)(107986001)(5001870100001);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1NAM02HT134;H:xsj-pvapsmtpgw02;FPR:;SPF:Pass;PTR:xapps1.xilinx.com,unknown-60-100.xilinx.com;MX:1;A:1;LANG:en; X-MS-Office365-Filtering-Correlation-Id: cffaae17-2ca9-42de-b2ba-08d38ea38b95 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501002);SRVR:SN1NAM02HT134; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(9452136761055)(192813158149592); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(13015025)(13023025)(13018025)(13017025)(8121501046)(5005006)(13024025)(3002001)(10201501046)(6055026);SRVR:SN1NAM02HT134;BCL:0;PCL:0;RULEID:;SRVR:SN1NAM02HT134; X-Forefront-PRVS: 09669DB681 X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2016 07:15:46.0153 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.100];Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1NAM02HT134 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7.6.2016 04:43, Paul Gortmaker wrote: > The Kconfig currently controlling compilation of this code is: > > config PINCTRL_ZYNQ > bool "Pinctrl driver for Xilinx Zynq" > > ...meaning that it currently is not being built as a module by anyone. > > Lets remove the modular code that is essentially orphaned, so that > when reading the driver there is no doubt it is builtin-only. > > Since module_platform_driver() uses the same init level priority as > builtin_platform_driver() the init ordering remains unchanged with > this commit. > > Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. > > We also delete the MODULE_LICENSE tag etc. since all that information > is already contained at the top of the file in the comments. > > Cc: Linus Walleij > Cc: Michal Simek > Cc: "Sören Brinkmann" > Cc: linux-gpio@vger.kernel.org > Signed-off-by: Paul Gortmaker > --- > drivers/pinctrl/pinctrl-zynq.c | 13 +------------ > 1 file changed, 1 insertion(+), 12 deletions(-) > > diff --git a/drivers/pinctrl/pinctrl-zynq.c b/drivers/pinctrl/pinctrl-zynq.c > index 8fdc60c5aeaf..7afdbede6823 100644 > --- a/drivers/pinctrl/pinctrl-zynq.c > +++ b/drivers/pinctrl/pinctrl-zynq.c > @@ -20,7 +20,7 @@ > */ > #include > #include > -#include > +#include > #include > #include > #include > @@ -1210,7 +1210,6 @@ static const struct of_device_id zynq_pinctrl_of_match[] = { > { .compatible = "xlnx,pinctrl-zynq" }, > { } > }; > -MODULE_DEVICE_TABLE(of, zynq_pinctrl_of_match); > > static struct platform_driver zynq_pinctrl_driver = { > .driver = { > @@ -1225,13 +1224,3 @@ static int __init zynq_pinctrl_init(void) > return platform_driver_register(&zynq_pinctrl_driver); > } > arch_initcall(zynq_pinctrl_init); > - > -static void __exit zynq_pinctrl_exit(void) > -{ > - platform_driver_unregister(&zynq_pinctrl_driver); > -} > -module_exit(zynq_pinctrl_exit); > - > -MODULE_AUTHOR("Sören Brinkmann "); > -MODULE_DESCRIPTION("Xilinx Zynq pinctrl driver"); > -MODULE_LICENSE("GPL"); > Acked-by: Michal Simek Thanks, Michal