From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH 1/4] drm: Centralize format information Date: Tue, 7 Jun 2016 12:18:34 +0300 Message-ID: <5756916A.2010301@ti.com> References: <1465255994-317-1-git-send-email-laurent.pinchart@ideasonboard.com> <1465255994-317-2-git-send-email-laurent.pinchart@ideasonboard.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1017302148==" Return-path: Received: from comal.ext.ti.com (comal.ext.ti.com [198.47.26.152]) by gabe.freedesktop.org (Postfix) with ESMTPS id 83D026E383 for ; Tue, 7 Jun 2016 09:18:41 +0000 (UTC) In-Reply-To: <1465255994-317-2-git-send-email-laurent.pinchart@ideasonboard.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart , dri-devel@lists.freedesktop.org Cc: Daniel Vetter List-Id: dri-devel@lists.freedesktop.org --===============1017302148== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="AjGt9IoimljufUvoQ5SaJS74QklQKix1x" --AjGt9IoimljufUvoQ5SaJS74QklQKix1x Content-Type: multipart/mixed; boundary="hk7OPdXClAdDxN3210BooSgu41iJa9W7v" From: Tomi Valkeinen To: Laurent Pinchart , dri-devel@lists.freedesktop.org Cc: Daniel Vetter Message-ID: <5756916A.2010301@ti.com> Subject: Re: [PATCH 1/4] drm: Centralize format information References: <1465255994-317-1-git-send-email-laurent.pinchart@ideasonboard.com> <1465255994-317-2-git-send-email-laurent.pinchart@ideasonboard.com> In-Reply-To: <1465255994-317-2-git-send-email-laurent.pinchart@ideasonboard.com> --hk7OPdXClAdDxN3210BooSgu41iJa9W7v Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/06/16 02:33, Laurent Pinchart wrote: > +/** > + * struct drm_format_info - information about a DRM format > + * @format: 4CC format identifier (DRM_FORMAT_*) > + * @depth: color depth (number of bits per pixel excluding padding bit= s) > + * @bpp: number of bits per pixel including padding > + * @num_planes: number of color planes (1 to 3) > + * @cpp: number of bytes per pixel (per plane) > + * @hsub: horizontal chroma subsampling factor > + * @vsub: vertical chroma subsampling factor > + */ > +struct drm_format_info { > + u32 format; > + unsigned int depth; > + unsigned int bpp; > + unsigned int num_planes; > + unsigned int cpp[3]; > + unsigned int hsub; > + unsigned int vsub; > +}; Any reason not to pack this a bit? All those unsigned ints would fit easily into u8. Tomi --hk7OPdXClAdDxN3210BooSgu41iJa9W7v-- --AjGt9IoimljufUvoQ5SaJS74QklQKix1x Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXVpFqAAoJEPo9qoy8lh71atUP/0TEntbnqr7bvHy2IvBUh9jH JUQNj7o3VqHOA756dszSe+TVKdXbrPI/48Bd2JdnARSk6hwVTJYjld9aPoiKNN2V 7UPCL6MPROTQFg9qD2W+gDE7i2iUuVLbvFQKgNY3t1aVtQcLGNPP1agPQEgBdVF/ FzhtUw2+pcj+wG/85YX0HXVLdFrAeMfGZAx9qpAMZeI7klIj7yVTjq8dqud+JgE8 2dO//G5EctQkxpZTYSjWO5pAy5/RvqyRjSezxFVQzWIZYgMl/aJf2G/jMgpynkdt h5mwKiSEu6PEkR+xwSaAE61TYXZVaXAYYExg50Nr1Awnhv2jZ10BBg2cRKY3sMaw QBrtz8AKfsneQlrdmkxv4n3/OdYdhxRWS4EkgNxpCQYMxkuXbuPqto20wUIA9q3G lYyMi9alYngmcYagISdEMpfuyPAxxuSrnTiJrFLmUCxRiUNNm+UU79w5Hjz1R0XP oOk+DOpz5qSqa14Jcl8CynJJoQ1xf9KmE84zMJ9op8/hd0dnDQWaIyQ6qXQNXBYM qAwfbHlBQvKej5qynnnOPXo258cmMrjaABRSz+guFy982gT8q15nJfjSs/nzX/G6 +PFbZhbt5AGWDhGs8Yuae/P9cmPCR/fzCtX7lm5BV+phE14ibcI30GkgLwYkzgUT Q9cygYqAWSQ7NHOCpL1s =mJQU -----END PGP SIGNATURE----- --AjGt9IoimljufUvoQ5SaJS74QklQKix1x-- --===============1017302148== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1017302148==--