From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 48067E00BC2; Tue, 7 Jun 2016 03:47:25 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily * valid * -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature * -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low * trust * [74.125.82.50 listed in list.dnswl.org] Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id BF0C4E00B5F for ; Tue, 7 Jun 2016 03:47:21 -0700 (PDT) Received: by mail-wm0-f50.google.com with SMTP id r5so8140825wmr.0 for ; Tue, 07 Jun 2016 03:47:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding; bh=4qrgg+wz6BWd6oSSZ+WjwaAADJNXqSPDGiM9m5ip6wA=; b=oMUpBkJs2qFxvMRxZEiyqXdirdF4SLmCGBWfDi4scfMNIJhPIAbccIbSSzkKDp2TF3 Jlh41obgyHEOIL5OprSA9CzP+Mq1wLe1QdDSamLNn2OAFCO49PlO/XKpgUFF/tvMAAlU tzPuJ98wefXVqK5IURIf87ThTskiKhjOoFiKsE1HQGmevq0EuGQ/gyYYZHUDOZ3U8qDp O/Hyk8EbfQK5B7/jpKD/Iau9nBKDkVZE4iMyzL82Bthya0Kc5ft8USjUX3brNgHwjasj q0tiYK4/YeCQ+I9b74XxoXgu8TsCQ4TdE6mkTc3mxRJ5yhRNAEtbjCw2hqQQVyWDIC9L iZtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=4qrgg+wz6BWd6oSSZ+WjwaAADJNXqSPDGiM9m5ip6wA=; b=fMh1oIb+9b4QyLeh10fcCp2KjnWO+1KsDeZvwNxm+w0lGIZqX8cfrZYj5LlC++hpmc /NRGjH7OhmKHxY5xcCx3UglSuMsBSwBOvCKF6aLYCcYK1olljYsHsx7XsOf4ghwvNHL6 HlQB4PNYIncKDgfD7Aado7He7+qT1GMtYMRHPVIvAFVUnbt4/VEraW3GxnlkocHAR3Xb xA7Ss9n7agNMUx2H88PPrKvkFIwM4h+dyRyder2Rwza0T0b3Hd7Pnbuq73T9QNqLoset mAaqtVbvuog2swONzQ8Q/hUc/6tWennwlkl+td3/lp2F3XCCV2pild2FMGKSDRerLxRM NjXA== X-Gm-Message-State: ALyK8tJ6XKBAZLnUi4weeFgPhYOvvnYoqigqLaOs4wwFpllcWuBN9w1kmccQpQYw4NW+Ef3q X-Received: by 10.194.235.193 with SMTP id uo1mr19928981wjc.1.1465296440476; Tue, 07 Jun 2016 03:47:20 -0700 (PDT) Received: from [192.168.0.78] (host109-150-165-138.range109-150.btcentralplus.com. [109.150.165.138]) by smtp.googlemail.com with ESMTPSA id n3sm4064782wjc.20.2016.06.07.03.47.19 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 07 Jun 2016 03:47:19 -0700 (PDT) To: toaster@yoctoproject.org, Elliot Smith References: <4b71309e4aa8dfdfa7a8e4e3723df8ae971f2bed.1465228580.git.ed.bartosh@linux.intel.com> From: Michael Wood Message-ID: <5756A637.70608@intel.com> Date: Tue, 7 Jun 2016 11:47:19 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <4b71309e4aa8dfdfa7a8e4e3723df8ae971f2bed.1465228580.git.ed.bartosh@linux.intel.com> Subject: Re: [PATCH 8/9] toaster-tests: fix tests for latest Selenium version X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jun 2016 10:47:25 -0000 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit On 06/06/16 17:01, Ed Bartosh wrote: > From: Elliot Smith > > Previously, we didn't specify a specific version of Selenium. > When upgrading to Python 3 and installing Selenium to work with it, > the JS unit test broke, as the report format produced by Selenium > had changed. > > Modify the test so that it works with the latest Selenium report > format. > > Add a note to the README that the given Selenium version should > be used to prevent unexpected test failures. > > Signed-off-by: Elliot Smith > Signed-off-by: Ed Bartosh > --- > bitbake/lib/toaster/tests/browser/README | 7 ++++--- > bitbake/lib/toaster/tests/browser/test_js_unit_tests.py | 8 ++++---- > 2 files changed, 8 insertions(+), 7 deletions(-) > > diff --git a/bitbake/lib/toaster/tests/browser/README b/bitbake/lib/toaster/tests/browser/README > index 63e8169..f57154e 100644 > --- a/bitbake/lib/toaster/tests/browser/README > +++ b/bitbake/lib/toaster/tests/browser/README > @@ -4,10 +4,11 @@ These tests require Selenium to be installed in your Python environment. > > The simplest way to install this is via pip: > > - pip install selenium > + pip install selenium==2.53.2 > > -Alternatively, if you used pip to install the libraries required by Toaster, > -selenium will already be installed. > +Note that if you use other versions of Selenium, some of the tests (such as > +tests.browser.test_js_unit_tests.TestJsUnitTests) may fail, as these rely on > +a Selenium test report with a version-specific format. > > To run tests against Chrome: > > diff --git a/bitbake/lib/toaster/tests/browser/test_js_unit_tests.py b/bitbake/lib/toaster/tests/browser/test_js_unit_tests.py > index e63da8e..3c0b962 100644 > --- a/bitbake/lib/toaster/tests/browser/test_js_unit_tests.py > +++ b/bitbake/lib/toaster/tests/browser/test_js_unit_tests.py > @@ -38,11 +38,11 @@ class TestJsUnitTests(SeleniumTestCase): > def test_that_js_unit_tests_pass(self): > url = reverse('js-unit-tests') > self.get(url) > - self.wait_until_present('#tests-failed') > + self.wait_until_present('#qunit-testresult .failed') > > - failed = self.find("#tests-failed").text > - passed = self.find("#tests-passed").text > - total = self.find("#tests-total").text If these elements are no longer needed, can you also remove them from the jsunit test page (static/js/tests/tests.js) thanks > + failed = self.find("#qunit-testresult .failed").text > + passed = self.find("#qunit-testresult .passed").text > + total = self.find("#qunit-testresult .total").text > > logger.info("Js unit tests completed %s out of %s passed, %s failed", > passed,