From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cumulusnetworks.com; s=google; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=dtZ1mF4hdj+0Z+hZEALFB26LiN0+tKFfPeW9FwS8rrM=; b=YMBPsEV5RZMoZOGTh+YwvyUwB+wiaTDRDpm2/AjNsI+wy9EN5RRtdL3Ajx9GeB0tO3 XQ8TY6gRPiv2SjsfY6OrpbwIRe1uDkKANqX5ZNjsya4xOfck2b3ZsUPRSSSRzib4uIw1 krVprrE5ecjDi44/8neU6V8s4fP0B7qQsSkiw= References: <1465294457-2785-1-git-send-email-makita.toshiaki@lab.ntt.co.jp> From: Nikolay Aleksandrov Message-ID: <5756AC53.70406@cumulusnetworks.com> Date: Tue, 7 Jun 2016 13:13:23 +0200 MIME-Version: 1.0 In-Reply-To: <1465294457-2785-1-git-send-email-makita.toshiaki@lab.ntt.co.jp> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Bridge] [PATCH net] bridge: Don't insert unnecessary local fdb entry on changing mac address List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Toshiaki Makita , "David S. Miller" , Stephen Hemminger Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org On 06/07/2016 12:14 PM, Toshiaki Makita wrote: > The missing br_vlan_should_use() test caused creation of an unneeded > local fdb entry on changing mac address of a bridge device when there is > a vlan which is configured on a bridge port but not on the bridge > device. > > Fixes: 2594e9064a57 ("bridge: vlan: add per-vlan struct and move to rhashtables") > Signed-off-by: Toshiaki Makita > --- Good catch, Acked-by: Nikolay Aleksandrov From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nikolay Aleksandrov via Bridge Subject: Re: [PATCH net] bridge: Don't insert unnecessary local fdb entry on changing mac address Date: Tue, 7 Jun 2016 13:13:23 +0200 Message-ID: <5756AC53.70406@cumulusnetworks.com> References: <1465294457-2785-1-git-send-email-makita.toshiaki@lab.ntt.co.jp> Reply-To: Nikolay Aleksandrov Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org To: Toshiaki Makita , "David S. Miller" , Stephen Hemminger Return-path: In-Reply-To: <1465294457-2785-1-git-send-email-makita.toshiaki@lab.ntt.co.jp> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: bridge-bounces@lists.linux-foundation.org Errors-To: bridge-bounces@lists.linux-foundation.org List-Id: netdev.vger.kernel.org On 06/07/2016 12:14 PM, Toshiaki Makita wrote: > The missing br_vlan_should_use() test caused creation of an unneeded > local fdb entry on changing mac address of a bridge device when there is > a vlan which is configured on a bridge port but not on the bridge > device. > > Fixes: 2594e9064a57 ("bridge: vlan: add per-vlan struct and move to rhashtables") > Signed-off-by: Toshiaki Makita > --- Good catch, Acked-by: Nikolay Aleksandrov