From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
John.C.Harrison@Intel.com, Intel-GFX@Lists.FreeDesktop.Org
Subject: Re: [PATCH v9 4/6] drm/i915: Interrupt driven fences
Date: Tue, 7 Jun 2016 13:19:18 +0100 [thread overview]
Message-ID: <5756BBC6.6040402@linux.intel.com> (raw)
In-Reply-To: <8acfa8c8-018c-d05b-ac8b-d92f0a91b2aa@linux.intel.com>
On 07/06/16 13:02, Maarten Lankhorst wrote:
> Op 02-06-16 om 15:25 schreef Tvrtko Ursulin:
[snip]
>>> + return;
>>> +
>>> + if (!fence_locked)
>>> + spin_lock_irqsave(&engine->fence_lock, flags);
>>
>> Not called from hard irq context so can be just spin_lock_irq.
>>
>> But if you agree to go with the tasklet it would then be spin_lock_bh.
> fence is always spin_lock_irq, if this requires _bh then it can't go into the tasklet.
No if fence API requires the _irq versions then it is fine, they
supersede the _bh variants.
Also it doesn't have to use the tasklet, I was just suggesting it as
lighter weight for lower latency since nothing seems to need
process/sleeping context anyway.
Main thing is that signaling is not serialized across engines by a
single worker.
Regards,
Tvrtko
P.S. Please try to put newlines between quoted text and your replies? It
will be easier to find your comments that way.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-06-07 12:19 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-01 17:07 [PATCH v9 0/6] Convert requests to use struct fence John.C.Harrison
2016-06-01 17:07 ` [PATCH v9 1/6] drm/i915: Add per context timelines for fence objects John.C.Harrison
2016-06-02 10:28 ` Tvrtko Ursulin
2016-06-09 16:08 ` John Harrison
2016-06-07 11:17 ` Maarten Lankhorst
2016-06-09 17:22 ` John Harrison
2016-06-01 17:07 ` [PATCH v9 2/6] drm/i915: Convert requests to use struct fence John.C.Harrison
2016-06-02 11:07 ` Tvrtko Ursulin
2016-06-07 11:42 ` Maarten Lankhorst
2016-06-07 12:11 ` Tvrtko Ursulin
2016-06-10 11:26 ` John Harrison
2016-06-13 10:16 ` Maarten Lankhorst
2016-06-01 17:07 ` [PATCH v9 3/6] drm/i915: Removed now redundant parameter to i915_gem_request_completed() John.C.Harrison
2016-06-07 12:07 ` Maarten Lankhorst
2016-06-01 17:07 ` [PATCH v9 4/6] drm/i915: Interrupt driven fences John.C.Harrison
2016-06-02 13:25 ` Tvrtko Ursulin
2016-06-07 12:02 ` Maarten Lankhorst
2016-06-07 12:19 ` Tvrtko Ursulin [this message]
2016-06-13 15:51 ` John Harrison
2016-06-14 11:35 ` Tvrtko Ursulin
2016-06-01 17:07 ` [PATCH v9 5/6] drm/i915: Updated request structure tracing John.C.Harrison
2016-06-07 12:15 ` Maarten Lankhorst
2016-06-01 17:07 ` [PATCH v9 6/6] drm/i915: Cache last IRQ seqno to reduce IRQ overhead John.C.Harrison
2016-06-07 12:47 ` Maarten Lankhorst
2016-06-16 12:10 ` John Harrison
2016-06-02 11:17 ` ✗ Ro.CI.BAT: failure for Convert requests to use struct fence (rev6) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5756BBC6.6040402@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=Intel-GFX@Lists.FreeDesktop.Org \
--cc=John.C.Harrison@Intel.com \
--cc=maarten.lankhorst@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.