From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xing Zheng Subject: Re: [PATCH v3] ASoC: rockchip: Add machine driver for MAX98357A/RT5514/DA7219 Date: Tue, 07 Jun 2016 20:47:01 +0800 Message-ID: <5756C245.7010001@rock-chips.com> References: <1464267742-15312-1-git-send-email-zhengxing@rock-chips.com> <20160601144542.GA3835@rob-hp-laptop> <5751912C.6080904@rock-chips.com> <20160606235026.GP7510@sirena.org.uk> <5756363F.40208@rock-chips.com> <20160607104711.GR7510@sirena.org.uk> <5756B22F.9000105@rock-chips.com> <20160607120647.GV7510@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from regular1.263xmail.com (regular1.263xmail.com [211.150.99.138]) by alsa0.perex.cz (Postfix) with ESMTP id C9F522605B8 for ; Tue, 7 Jun 2016 14:47:26 +0200 (CEST) In-Reply-To: <20160607120647.GV7510@sirena.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: Mark Rutland , Rob Herring , alsa-devel@alsa-project.org, heiko@sntech.de, Pawel Moll , Ian Campbell , linux-kernel@vger.kernel.org, Takashi Iwai , dianders@chromium.org, Liam Girdwood , linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, Kumar Gala , linux-arm-kernel@lists.infradead.org List-Id: alsa-devel@alsa-project.org SGkgTWFyaywKCk9uIDIwMTblubQwNuaciDA35pelIDIwOjA2LCBNYXJrIEJyb3duIHdyb3RlOgo+ IE9LLCB0aGVuIHRoZSBvcmlnaW5hbCBuYW1lIHByb2JhYmx5IG1ha2VzIHNvbWUgc2Vuc2UgdGhv dWdoIHJlYWxseQo+IHRoYXQncyBzdWNoIGFuIHVudXN1YWwgZGVzaWduIHRoYXQganVzdCBuYW1p bmcgaXQgYWZ0ZXIgdGhlIHNwZWNpZmljCj4gYm9hcmQgbWlnaHQgYmUgYmV0dGVyLCBpdCdzIG5v dCBsaWtlbHkgdG8gc2VlIGFueSByZXVzZSBJJ2QgZ3Vlc3MuClRoZXJlIGFyZSBub3Qgb25seSBv bmUgdHlwZSBvZiBib2FyZCB3aXRoIHRoaXMgYXVkaW8gY29ubmVjdGlvbiwgc28gSSAKdGhpbmsg d2UgZG9uJ3QgbmVlZCB0byBhZGQgc3BlY2lmaWMgYm9hcmQgbmFtZS4KClRoZXJlZm9yZSwgSSBp bnRlbmQgdG8gcmVjb3ZlciBvcmlnaW5hbCBuYW1lIAoocmszMzk5X21heDk4MzU3YV9ydDU1MTRf ZGE3MjE5LmMpLCBhbmQgZGVzY3JpcHRpb24gbGlrZSB0aGlzOgpzb3VuZCB7CiAgICAgY29tcGF0 aWJsZSA9ICJyb2NrY2hpcCxyazMzOTktbWF4OTgzNTdhLXJ0NTUxNC1kYTcyMTkiOwogICAgIHJv Y2tjaGlwLGNwdSA9IDwmaTJzMCAmaTJzMCAmaTJzMD47ICAgICAgICAgICAgICAgLy8gbm90ZSAo d2lsbCBub3QgCmJlIHNlbnQgdG8gdXBzdHJlYW0pOiBJbiBmdXR1cmUsIHdlIG1heSB1c2UgdGhl IGkyczEgb3IgaTJzMi4uLgogICAgIHJvY2tjaGlwLGNvZGVjID0gPCZtYXg5ODM1N2EgJmhlYWRz ZXRjb2RlYyAmY29kZWM+Owp9OwoKQ291bGQgeW91IHBsZWFzZSBhZ3JlZSB0byBkbyB0aGlzPwoK VGhhbmtzLgoKLS0gCi0gWGluZyBaaGVuZwoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCkFsc2EtZGV2ZWwgbWFpbGluZyBsaXN0CkFsc2EtZGV2ZWxAYWxz YS1wcm9qZWN0Lm9yZwpodHRwOi8vbWFpbG1hbi5hbHNhLXByb2plY3Qub3JnL21haWxtYW4vbGlz dGluZm8vYWxzYS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: zhengxing@rock-chips.com (Xing Zheng) Date: Tue, 07 Jun 2016 20:47:01 +0800 Subject: [PATCH v3] ASoC: rockchip: Add machine driver for MAX98357A/RT5514/DA7219 In-Reply-To: <20160607120647.GV7510@sirena.org.uk> References: <1464267742-15312-1-git-send-email-zhengxing@rock-chips.com> <20160601144542.GA3835@rob-hp-laptop> <5751912C.6080904@rock-chips.com> <20160606235026.GP7510@sirena.org.uk> <5756363F.40208@rock-chips.com> <20160607104711.GR7510@sirena.org.uk> <5756B22F.9000105@rock-chips.com> <20160607120647.GV7510@sirena.org.uk> Message-ID: <5756C245.7010001@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Mark, On 2016?06?07? 20:06, Mark Brown wrote: > OK, then the original name probably makes some sense though really > that's such an unusual design that just naming it after the specific > board might be better, it's not likely to see any reuse I'd guess. There are not only one type of board with this audio connection, so I think we don't need to add specific board name. Therefore, I intend to recover original name (rk3399_max98357a_rt5514_da7219.c), and description like this: sound { compatible = "rockchip,rk3399-max98357a-rt5514-da7219"; rockchip,cpu = <&i2s0 &i2s0 &i2s0>; // note (will not be sent to upstream): In future, we may use the i2s1 or i2s2... rockchip,codec = <&max98357a &headsetcodec &codec>; }; Could you please agree to do this? Thanks. -- - Xing Zheng From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932347AbcFGMrg (ORCPT ); Tue, 7 Jun 2016 08:47:36 -0400 Received: from regular1.263xmail.com ([211.150.99.138]:54219 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752023AbcFGMre (ORCPT ); Tue, 7 Jun 2016 08:47:34 -0400 X-263anti-spam: KSV:0;BIG:0;ABS:1;DNS:0;ATT:0;SPF:S; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ADDR-CHECKED: 0 X-RL-SENDER: zhengxing@rock-chips.com X-FST-TO: broonie@kernel.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: zhengxing@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <5756C245.7010001@rock-chips.com> Date: Tue, 07 Jun 2016 20:47:01 +0800 From: Xing Zheng User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120410 Thunderbird/11.0.1 MIME-Version: 1.0 To: Mark Brown CC: Rob Herring , linux-rockchip@lists.infradead.org, dianders@chromium.org, heiko@sntech.de, Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH v3] ASoC: rockchip: Add machine driver for MAX98357A/RT5514/DA7219 References: <1464267742-15312-1-git-send-email-zhengxing@rock-chips.com> <20160601144542.GA3835@rob-hp-laptop> <5751912C.6080904@rock-chips.com> <20160606235026.GP7510@sirena.org.uk> <5756363F.40208@rock-chips.com> <20160607104711.GR7510@sirena.org.uk> <5756B22F.9000105@rock-chips.com> <20160607120647.GV7510@sirena.org.uk> In-Reply-To: <20160607120647.GV7510@sirena.org.uk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mark, On 2016年06月07日 20:06, Mark Brown wrote: > OK, then the original name probably makes some sense though really > that's such an unusual design that just naming it after the specific > board might be better, it's not likely to see any reuse I'd guess. There are not only one type of board with this audio connection, so I think we don't need to add specific board name. Therefore, I intend to recover original name (rk3399_max98357a_rt5514_da7219.c), and description like this: sound { compatible = "rockchip,rk3399-max98357a-rt5514-da7219"; rockchip,cpu = <&i2s0 &i2s0 &i2s0>; // note (will not be sent to upstream): In future, we may use the i2s1 or i2s2... rockchip,codec = <&max98357a &headsetcodec &codec>; }; Could you please agree to do this? Thanks. -- - Xing Zheng