From: Ben Greear <greearb@candelatech.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: ath10k <ath10k@lists.infradead.org>
Subject: Re: Question on "ath10k: document ofdm/5ghz rate offset with a macro"
Date: Tue, 07 Jun 2016 05:57:32 -0700 [thread overview]
Message-ID: <5756C4BC.3040402@candelatech.com> (raw)
In-Reply-To: <CA+BoTQ=sGYcoHcBcPKqzqqFekbV9g23ZZ556N9+9kmtZKV=kEg@mail.gmail.com>
On 06/06/2016 11:23 PM, Michal Kazior wrote:
> On 6 June 2016 at 23:25, Ben Greear <greearb@candelatech.com> wrote:
>> While porting some patches forward, I notice the change below
>> that renamed the method to "ath10k_mac_sta_has_ofdm_only". But,
>> that is not really what that is checking, since it just throws
>> away the CCK rates (and they might have been there).
>>
>> Maybe it should just be "ath10k_mac_sta_has_ofdm()" ?
>
> Yes, this seems like an unfortunate name pick on my side. The MODE_11G
> phymode is for mixed b/g.
I think the actual code behaviour is right. I have some patches to
support G-only mode and such, and will change the name of your method
in those patches to be more clear.
Lots of other pending patches of mine before I will get to trying to push
that one upstream though.
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2016-06-07 13:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 21:25 Question on "ath10k: document ofdm/5ghz rate offset with a macro" Ben Greear
2016-06-07 6:23 ` Michal Kazior
2016-06-07 12:57 ` Ben Greear [this message]
2016-06-07 13:16 ` Michal Kazior
2016-06-07 13:19 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5756C4BC.3040402@candelatech.com \
--to=greearb@candelatech.com \
--cc=ath10k@lists.infradead.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.