From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 4C211E00C02; Tue, 7 Jun 2016 06:35:37 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low * trust * [74.125.82.43 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily * valid * -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 6F814E00BDE for ; Tue, 7 Jun 2016 06:35:33 -0700 (PDT) Received: by mail-wm0-f43.google.com with SMTP id n184so137630943wmn.1 for ; Tue, 07 Jun 2016 06:35:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=Hh748apoIJyLQnO4JcC7a0duMyQ378JlFmY3V5dFv2g=; b=0GIEg0ihotYVg0BuqQZkqgubTISJik9lA0H8NCoIUAX57BFkRdQK5lKz2i2hPJThJi ZFUYQCAyZaXkrMrEkZnXwWiaosuVdqYoMl8lUvIYyGnVOJSsYxfVDqu+x3JKk5PR1Az4 XqenLE+5M3PuPinTAApEPpyhfdKgvQmwDOTw/mwkuFFvlPVD2imwZHOhEhXvkcyltG/B ywjckNMJKVVWCT2r1aZ0yluKYJMiGu+uaXLv4RgepB1RGQeWy8ZnbLmOZOQsgaHnD7UA c8rhhJ6q5mEFpdPVLdzeqwafgdoJ3HnoVEQeHODyo4OV8QjzL+Cb3nrNTFWo5rzqG6yr 3MXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=Hh748apoIJyLQnO4JcC7a0duMyQ378JlFmY3V5dFv2g=; b=DyGGLKf7skWneSV1LQ4UKB5t9BbtPfhfWFwNLsAHhPyiq5bAQlpCDwBFgQLpNr7gXk WSfHm4M0fyUto6wdzkojTUqCmx2DZeSMp9cSqXACDH1t9j+Q8yeaTKzlQwrjILpAGy4E auTX3FlRO43cYQwcJxOzY9hCvIbr2+tcB0I3A2Ezfy123uEjm28IPMoJhJy4L4fwzQAa DtwdZDgptEkUDShin2h0kwMg5D+lRia4x+KIkvGi2s3+hCWGpDd6ypB6TdnBhBbd4BXw LQu6nvNupfXpSdma1qgLt/ZHwDt2/0wE/vyqO5gFN44P7YG+xvRJW3ho0UWWJNIvWc0b Vu1g== X-Gm-Message-State: ALyK8tLb7NgZRwhRiQ0wpCGv07LfbJyvuEfvlF6x16c3vLqHZhUx5Wy1MvcwL27ik8Y3uQEK X-Received: by 10.28.163.69 with SMTP id m66mr2905632wme.101.1465306532947; Tue, 07 Jun 2016 06:35:32 -0700 (PDT) Received: from [192.168.0.78] (host109-150-165-138.range109-150.btcentralplus.com. [109.150.165.138]) by smtp.googlemail.com with ESMTPSA id c4sm25575109wjm.24.2016.06.07.06.35.32 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 07 Jun 2016 06:35:32 -0700 (PDT) To: "Smith, Elliot" , Ed Bartosh References: From: Michael Wood Message-ID: <5756CDA3.4000300@intel.com> Date: Tue, 7 Jun 2016 14:35:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: Cc: toaster@yoctoproject.org Subject: Re: [PATCH 0/9] python 3 fixes X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jun 2016 13:35:37 -0000 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit I've looked at Elliot's patches, apart from that one little thing it looks good to me. Thanks, Michael On 07/06/16 10:42, Smith, Elliot wrote: > Thanks Ed. I've been through and reviewed your patches from this > series, and they look good to me. > > Michael has said he will review my patches in this series. > > Once they're all reviewed, I'll pull them into toaster-next. > > Elliot > > On 6 June 2016 at 17:01, Ed Bartosh > wrote: > > Hi, > > With this set of fixes I was able to run Toaster and build > core-image-minimal for 'Local Yocto Project'. > > The following changes since commit > 14d075921ef5c5577a0a0acc394399b10f4fcbe8: > > toaster: Rework displaying package dependencies across Toaster > (2016-06-06 15:25:44 +0300) > > are available in the git repository at: > > git://git.yoctoproject.org/poky-contrib > ed/toaster/python3 > http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=ed/toaster/python3 > > Ed Bartosh (6): > bitbake: toaster: use python3 explicitly > toaster: replace viewkeys() -> keys() > toaster: fix migrations > toaster: decode response content > toaster: fix incorrect file mode > toaster: fix test_toaster_tables > > Elliot Smith (3): > toaster: fix broken reference to urllib > toaster-tests: fix tests for latest Selenium version > toaster: open image files in binary mode when sending in response > > bitbake/bin/toaster | 4 +- > bitbake/lib/bb/ui/buildinfohelper.py | 2 +- > .../migrations/0004_auto_20160523_1446.py | 34 +++++++++ > .../orm/migrations/0007_auto_20160523_1446.py | 89 > ++++++++++++++++++++++ > bitbake/lib/toaster/tests/browser/README | 7 +- > .../toaster/tests/browser/test_js_unit_tests.py | 8 +- > bitbake/lib/toaster/toastergui/tests.py | 46 +++++------ > bitbake/lib/toaster/toastergui/views.py | 2 +- > bitbake/lib/toaster/toastergui/widgets.py | 2 +- > 9 files changed, 156 insertions(+), 38 deletions(-) > create mode 100644 > bitbake/lib/toaster/bldcontrol/migrations/0004_auto_20160523_1446.py > create mode 100644 > bitbake/lib/toaster/orm/migrations/0007_auto_20160523_1446.py > > -- > Regards, > Ed > > -- > _______________________________________________ > toaster mailing list > toaster@yoctoproject.org > https://lists.yoctoproject.org/listinfo/toaster > > > > > -- > Elliot Smith > Software Engineer > Intel Open Source Technology Centre > >