Re: [PATCH] OvmfPkg: Add ACPI support for Virt Xen ARM

[Julien Grall <julien.grall@arm.com>]

Hello Shannon,

On 31/05/16 05:59, Shannon Zhao wrote:
> +EFI_STATUS
> +EFIAPI
> +GetXenArmAcpiRsdp (
> +  OUT   EFI_ACPI_2_0_ROOT_SYSTEM_DESCRIPTION_POINTER   **RsdpPtr
> +  )
> +{
> +  VOID                                           *Hob;
> +  EFI_ACPI_2_0_ROOT_SYSTEM_DESCRIPTION_POINTER   *RsdpStructurePtr;
> +  VOID                                           *DeviceTreeBase;
> +  INT32                                          Node, Depth, Len;
> +  CONST CHAR8                                    *Type;
> +  CONST VOID                                     *RegProp;
> +
> +  RsdpStructurePtr = NULL;
> +  //
> +  // Get the RSDP structure address from DeviceTree
> +  //
> +  Hob = GetFirstGuidHob(&gFdtHobGuid);
> +  if (Hob == NULL || GET_GUID_HOB_DATA_SIZE (Hob) != sizeof (UINT64)) {
> +    DEBUG ((EFI_D_ERROR, "%a: Failed to get Fdt Hob\n", __FUNCTION__));
> +    return EFI_NOT_FOUND;
> +  }
> +  DeviceTreeBase = (VOID *)(UINTN)*(UINT64 *)GET_GUID_HOB_DATA (Hob);
> +
> +  if (fdt_check_header (DeviceTreeBase) != 0) {
> +    DEBUG ((EFI_D_ERROR, "%a: No DTB found @ 0x%p\n", __FUNCTION__, DeviceTreeBase));
> +    return EFI_NOT_FOUND;
> +  }
> +
> +  Node = fdt_path_offset(DeviceTreeBase, "/chosen/modules");

I am not sure if we want to mandate the modules to live in "/chosen". 
Would it be possible to look by compatible instead?

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel