From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Jan Beulich <JBeulich@suse.com>,
David Vrabel <david.vrabel@citrix.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Juergen Gross <JGross@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] xen-pciback: return proper values during BAR sizing
Date: Tue, 7 Jun 2016 10:06:44 -0400 [thread overview]
Message-ID: <5756D4F4.7070802@oracle.com> (raw)
In-Reply-To: <5756864102000078000F269A@prv-mh.provo.novell.com>
On 06/07/2016 02:30 AM, Jan Beulich wrote:
> Reads following writes with all address bits set to 1 should return all
> changeable address bits as one, not the BAR size (nor, as was the case
> for the upper half of 64-bit BARs, the high half of the region's end
> address). Presumably this didn't cause any problems so far because
> consumers use the value to calculate the size (usually via val & -val),
> and do nothing else with it.
>
> But also consider the exception here: Unimplemented BARs should always
> return all zeroes.
>
> And finally, the check for whether to return the sizing address on read
> for the ROM BAR should ignore all non-address bits, not just the ROM
> Enable one.
Should this go to stable trees as well?
-boris
next prev parent reply other threads:[~2016-06-07 14:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 6:27 [PATCH v2 0/2] xen-pciback: correct and clean up BAR handling Jan Beulich
2016-06-07 6:30 ` [PATCH v2 1/2] xen-pciback: return proper values during BAR sizing Jan Beulich
2016-06-07 14:06 ` Boris Ostrovsky [this message]
2016-06-07 14:14 ` Jan Beulich
2016-06-07 14:14 ` Jan Beulich
2016-06-07 14:06 ` Boris Ostrovsky
2016-06-24 9:13 ` [PATCH v3 " Jan Beulich
2016-06-24 14:08 ` David Vrabel
2016-06-24 14:08 ` [Xen-devel] " David Vrabel
2016-06-24 9:13 ` Jan Beulich
2016-06-07 6:30 ` [PATCH v2 " Jan Beulich
2016-06-07 6:31 ` [PATCH v2 2/2] xen-pciback: clean up {bar,rom}_init() Jan Beulich
2016-06-07 6:31 ` Jan Beulich
2016-06-07 14:06 ` Boris Ostrovsky
2016-06-07 14:06 ` [PATCH v2 2/2] xen-pciback: clean up {bar, rom}_init() Boris Ostrovsky
2016-06-24 15:01 ` David Vrabel
2016-06-24 15:01 ` [Xen-devel] [PATCH v2 2/2] xen-pciback: clean up {bar,rom}_init() David Vrabel
2016-06-27 7:24 ` Jan Beulich
2016-06-29 12:42 ` [Xen-devel] [PATCH v2 2/2] xen-pciback: clean up {bar, rom}_init() David Vrabel
2016-06-29 12:42 ` David Vrabel
2016-06-27 7:24 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5756D4F4.7070802@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=JBeulich@suse.com \
--cc=JGross@suse.com \
--cc=david.vrabel@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.