From mboxrd@z Thu Jan 1 00:00:00 1970 From: robin.murphy@arm.com (Robin Murphy) Date: Tue, 7 Jun 2016 15:11:14 +0100 Subject: HDLCD crashes with 6d910bfa809e In-Reply-To: <20160607133535.GA1165@e106497-lin.cambridge.arm.com> References: <5756B8A8.8000902@arm.com> <20160607133535.GA1165@e106497-lin.cambridge.arm.com> Message-ID: <5756D602.4090305@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Liviu, On 07/06/16 14:35, liviu.dudau at arm.com wrote: > On Tue, Jun 07, 2016 at 01:06:00PM +0100, Robin Murphy wrote: >> Having just inadvertently merged -next into my working branch, I find >> dev6d910bfa809e ("drm/hlcd: Use lockless gem BO free callback") adversely >> affecting my board's ability to boot ;) >> >> Since I (intentionally) don't have sufficient CMA to create a framebuffer, >> drm_gem_cma_create() fails, unconditionally calls the now-NULL >> drm->driver->gem_free_object() in its cleanup path, and fiery death >> ensues... > > Thanks for reporting this. What other changes other than reducing the CMA > allocation size do you have that I might need in order to reproduce this? I've just confirmed a plain checkout of next-20160602, using arm64 defconfig + DRM + HDLCD + TDA998X and CMA_SIZE_MBYTES=1, booted on a Juno, does the job: [ 3.032402] hdlcd 7ff60000.hdlcd: bound 0-0070 (ops tda998x_ops) [ 3.038388] [drm] Supports vblank timestamp caching Rev 2 (21.10.2013). [ 3.044970] [drm] No driver support for vblank timestamp query. [ 3.076973] hdlcd 7ff60000.hdlcd: failed to allocate buffer with size 7680000 [ 3.084081] Bad mode in Synchronous Abort handler detected, code 0x86000004 -- IABT (current EL) [ 3.092815] CPU: 3 PID: 6 Comm: kworker/u12:0 Not tainted 4.7.0-rc1-next-20160602 #686 [ 3.100682] Hardware name: ARM Juno development board (r1) (DT) [ 3.106567] Workqueue: deferwq deferred_probe_work_func [ 3.111761] task: ffff8009768a3e80 ti: ffff8009768e8000 task.ti: ffff8009768e8000 [ 3.119198] PC is at 0x0 [ 3.121720] LR is at drm_gem_cma_create+0x128/0x130 ...and so on. Today's -next, on the other hand, dodges the bullet entirely: [ 2.903645] [drm] found ARM HDLCD version r0p0 [ 2.908122] hdlcd 7ff60000.hdlcd: master bind failed: -22 [ 2.913505] tda998x: probe of 0-0070 failed with error -22 [ 2.919141] [drm] found ARM HDLCD version r0p0 [ 2.923609] hdlcd 7ff50000.hdlcd: master bind failed: -22 [ 2.928991] tda998x: probe of 0-0071 failed with error -22 Oh well... Robin. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robin Murphy Subject: Re: HDLCD crashes with 6d910bfa809e Date: Tue, 7 Jun 2016 15:11:14 +0100 Message-ID: <5756D602.4090305@arm.com> References: <5756B8A8.8000902@arm.com> <20160607133535.GA1165@e106497-lin.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from foss.arm.com (foss.arm.com [217.140.101.70]) by gabe.freedesktop.org (Postfix) with ESMTP id 8CB396E099 for ; Tue, 7 Jun 2016 14:11:16 +0000 (UTC) In-Reply-To: <20160607133535.GA1165@e106497-lin.cambridge.arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: liviu.dudau@arm.com Cc: daniel.vetter@ffwll.ch, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgTGl2aXUsCgpPbiAwNy8wNi8xNiAxNDozNSwgbGl2aXUuZHVkYXVAYXJtLmNvbSB3cm90ZToK PiBPbiBUdWUsIEp1biAwNywgMjAxNiBhdCAwMTowNjowMFBNICswMTAwLCBSb2JpbiBNdXJwaHkg d3JvdGU6Cj4+IEhhdmluZyBqdXN0IGluYWR2ZXJ0ZW50bHkgbWVyZ2VkIC1uZXh0IGludG8gbXkg d29ya2luZyBicmFuY2gsIEkgZmluZAo+PiBkZXY2ZDkxMGJmYTgwOWUgKCJkcm0vaGxjZDogVXNl IGxvY2tsZXNzIGdlbSBCTyBmcmVlIGNhbGxiYWNrIikgYWR2ZXJzZWx5Cj4+IGFmZmVjdGluZyBt eSBib2FyZCdzIGFiaWxpdHkgdG8gYm9vdCA7KQo+Pgo+PiBTaW5jZSBJIChpbnRlbnRpb25hbGx5 KSBkb24ndCBoYXZlIHN1ZmZpY2llbnQgQ01BIHRvIGNyZWF0ZSBhIGZyYW1lYnVmZmVyLAo+PiBk cm1fZ2VtX2NtYV9jcmVhdGUoKSBmYWlscywgdW5jb25kaXRpb25hbGx5IGNhbGxzIHRoZSBub3ct TlVMTAo+PiBkcm0tPmRyaXZlci0+Z2VtX2ZyZWVfb2JqZWN0KCkgaW4gaXRzIGNsZWFudXAgcGF0 aCwgYW5kIGZpZXJ5IGRlYXRoCj4+IGVuc3Vlcy4uLgo+Cj4gVGhhbmtzIGZvciByZXBvcnRpbmcg dGhpcy4gV2hhdCBvdGhlciBjaGFuZ2VzIG90aGVyIHRoYW4gcmVkdWNpbmcgdGhlIENNQQo+IGFs bG9jYXRpb24gc2l6ZSBkbyB5b3UgaGF2ZSB0aGF0IEkgbWlnaHQgbmVlZCBpbiBvcmRlciB0byBy ZXByb2R1Y2UgdGhpcz8KCkkndmUganVzdCBjb25maXJtZWQgYSBwbGFpbiBjaGVja291dCBvZiBu ZXh0LTIwMTYwNjAyLCB1c2luZyBhcm02NCAKZGVmY29uZmlnICsgRFJNICsgSERMQ0QgKyBUREE5 OThYIGFuZCBDTUFfU0laRV9NQllURVM9MSwgYm9vdGVkIG9uIGEgCkp1bm8sIGRvZXMgdGhlIGpv YjoKClsgICAgMy4wMzI0MDJdIGhkbGNkIDdmZjYwMDAwLmhkbGNkOiBib3VuZCAwLTAwNzAgKG9w cyB0ZGE5OTh4X29wcykKWyAgICAzLjAzODM4OF0gW2RybV0gU3VwcG9ydHMgdmJsYW5rIHRpbWVz dGFtcCBjYWNoaW5nIFJldiAyICgyMS4xMC4yMDEzKS4KWyAgICAzLjA0NDk3MF0gW2RybV0gTm8g ZHJpdmVyIHN1cHBvcnQgZm9yIHZibGFuayB0aW1lc3RhbXAgcXVlcnkuClsgICAgMy4wNzY5NzNd IGhkbGNkIDdmZjYwMDAwLmhkbGNkOiBmYWlsZWQgdG8gYWxsb2NhdGUgYnVmZmVyIHdpdGggc2l6 ZSAKNzY4MDAwMApbICAgIDMuMDg0MDgxXSBCYWQgbW9kZSBpbiBTeW5jaHJvbm91cyBBYm9ydCBo YW5kbGVyIGRldGVjdGVkLCBjb2RlIAoweDg2MDAwMDA0IC0tIElBQlQgKGN1cnJlbnQgRUwpClsg ICAgMy4wOTI4MTVdIENQVTogMyBQSUQ6IDYgQ29tbToga3dvcmtlci91MTI6MCBOb3QgdGFpbnRl ZCAKNC43LjAtcmMxLW5leHQtMjAxNjA2MDIgIzY4NgpbICAgIDMuMTAwNjgyXSBIYXJkd2FyZSBu YW1lOiBBUk0gSnVubyBkZXZlbG9wbWVudCBib2FyZCAocjEpIChEVCkKWyAgICAzLjEwNjU2N10g V29ya3F1ZXVlOiBkZWZlcndxIGRlZmVycmVkX3Byb2JlX3dvcmtfZnVuYwpbICAgIDMuMTExNzYx XSB0YXNrOiBmZmZmODAwOTc2OGEzZTgwIHRpOiBmZmZmODAwOTc2OGU4MDAwIHRhc2sudGk6IApm ZmZmODAwOTc2OGU4MDAwClsgICAgMy4xMTkxOThdIFBDIGlzIGF0IDB4MApbICAgIDMuMTIxNzIw XSBMUiBpcyBhdCBkcm1fZ2VtX2NtYV9jcmVhdGUrMHgxMjgvMHgxMzAKLi4uYW5kIHNvIG9uLgoK VG9kYXkncyAtbmV4dCwgb24gdGhlIG90aGVyIGhhbmQsIGRvZGdlcyB0aGUgYnVsbGV0IGVudGly ZWx5OgoKWyAgICAyLjkwMzY0NV0gW2RybV0gZm91bmQgQVJNIEhETENEIHZlcnNpb24gcjBwMApb ICAgIDIuOTA4MTIyXSBoZGxjZCA3ZmY2MDAwMC5oZGxjZDogbWFzdGVyIGJpbmQgZmFpbGVkOiAt MjIKWyAgICAyLjkxMzUwNV0gdGRhOTk4eDogcHJvYmUgb2YgMC0wMDcwIGZhaWxlZCB3aXRoIGVy cm9yIC0yMgpbICAgIDIuOTE5MTQxXSBbZHJtXSBmb3VuZCBBUk0gSERMQ0QgdmVyc2lvbiByMHAw ClsgICAgMi45MjM2MDldIGhkbGNkIDdmZjUwMDAwLmhkbGNkOiBtYXN0ZXIgYmluZCBmYWlsZWQ6 IC0yMgpbICAgIDIuOTI4OTkxXSB0ZGE5OTh4OiBwcm9iZSBvZiAwLTAwNzEgZmFpbGVkIHdpdGgg ZXJyb3IgLTIyCgpPaCB3ZWxsLi4uCgpSb2Jpbi4KCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxp c3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2RyaS1kZXZlbAo=