From: John Fastabend <john.fastabend@gmail.com>
To: Amir Vadai <amir@vadai.me>, "David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org, Jiri Pirko <jiri@mellanox.com>,
Or Gerlitz <ogerlitz@mellanox.com>,
Hadar Har-Zion <hadarh@mellanox.com>,
Amir Vadai <amirva@mellanox.com>
Subject: Re: [PATCH net-next] net/sched: cls_flower: Introduce support in SKIP SW flag
Date: Tue, 7 Jun 2016 08:37:40 -0700 [thread overview]
Message-ID: <5756EA44.7050301@gmail.com> (raw)
In-Reply-To: <20160605141118.10986-1-amir@vadai.me>
On 16-06-05 07:11 AM, Amir Vadai wrote:
> From: Amir Vadai <amirva@mellanox.com>
>
> In order to make a filter processed only by hardware, skip_sw flag
> should be supplied. This is an addition to the already existing skip_hw
> flag (filter will be processed by software only). If no flag is
> specified, filter will be processed by both software and hardware.
>
> If only hardware offloaded filters exist, fl_classify() will return
> without doing anything.
>
> A following userspace patch will be sent once kernel patch is accepted.
>
> Example:
>
> tc filter add dev enp0s9 protocol ip prio 20 parent ffff: \
> flower \
> ip_proto 6 \
> indev enp0s9 \
> skip_sw \
> action skbedit mark 0x1234
>
> Signed-off-by: Amir Vadai <amirva@mellanox.com>
> ---
Looks good to me. Although we need to do the same error propagation in
flower that Jakub just added to cls_u32.
Acked-by: John Fastabend <john.r.fastabend@intel.com>
next prev parent reply other threads:[~2016-06-07 15:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-05 14:11 [PATCH net-next] net/sched: cls_flower: Introduce support in SKIP SW flag Amir Vadai
2016-06-07 12:14 ` Jiri Pirko
2016-06-07 15:37 ` John Fastabend [this message]
2016-06-08 6:04 ` Amir Vadai
2016-06-07 22:50 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2016-06-13 8:58 Amir Vadai
2016-06-13 9:03 ` Amir Vadai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5756EA44.7050301@gmail.com \
--to=john.fastabend@gmail.com \
--cc=amir@vadai.me \
--cc=amirva@mellanox.com \
--cc=davem@davemloft.net \
--cc=hadarh@mellanox.com \
--cc=jiri@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.