From: Logan Gunthorpe <logang@deltatee.com>
To: Jon Mason <jdmason@kudzu.us>
Cc: Dave Jiang <dave.jiang@intel.com>,
Allen Hubbe <Allen.Hubbe@emc.com>,
John Kading <john.kading@gd-ms.com>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
linux-ntb@googlegroups.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] ntb_transport: Check the number of spads the hardware supports
Date: Tue, 7 Jun 2016 11:15:43 -0600 [thread overview]
Message-ID: <5757013F.2090401@deltatee.com> (raw)
In-Reply-To: <20160604154035.GA11597@kudzu.us>
Hi Jon,
Thanks for the feedback. I'll send an updated patch in a moment.
On 04/06/16 09:40 AM, Jon Mason wrote:
> Nit, please add spaces around '*' (per checkpatch)
I'll change this, but I did run it through checkpatch and it did not
warn about this.
> Please explicitly point out that this is being modified in the commit
> message. I don't see them being used, so probably not a big deal
> (unless Dave Jiang has something queued that will use it).
Done. I feel like he can always add them back in when he adds the
functionality. This way, when he does, MAX_SPAD will be updated and the
check will still be correct.
> Move this check above the dev_to_node assignment above.
Done.
Logan
next prev parent reply other threads:[~2016-06-07 17:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-03 20:50 [PATCH 0/3] ntb: Fixes and enhancements to ntb tools Logan Gunthorpe
2016-06-03 20:50 ` [PATCH 1/3] ntb_perf: Allow limiting the size of the memory windows Logan Gunthorpe
2016-06-03 21:03 ` Jiang, Dave
2016-06-04 15:25 ` Jon Mason
2016-06-03 20:50 ` [PATCH 2/3] ntb_transport: Check the number of spads the hardware supports Logan Gunthorpe
2016-06-04 15:40 ` Jon Mason
2016-06-07 17:15 ` Logan Gunthorpe [this message]
2016-06-07 17:20 ` [PATCH v2 " Logan Gunthorpe
2016-06-07 17:24 ` Jiang, Dave
2016-06-09 14:51 ` Jon Mason
2016-06-03 20:50 ` [PATCH 3/3] ntb_tool: Add memory window debug support Logan Gunthorpe
2016-06-03 21:20 ` Allen Hubbe
2016-06-03 21:20 ` Allen Hubbe
2016-06-04 15:25 ` Jon Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5757013F.2090401@deltatee.com \
--to=logang@deltatee.com \
--cc=Allen.Hubbe@emc.com \
--cc=arnd@arndb.de \
--cc=dave.jiang@intel.com \
--cc=jdmason@kudzu.us \
--cc=john.kading@gd-ms.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ntb@googlegroups.com \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.