From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC][PATCH] arm: rk: Drop SYS_MALLOC_F and SPL_SYS_MALLOC_SIMPLE
Date: Wed, 08 Jun 2016 05:02:03 +0200 [thread overview]
Message-ID: <57578AAB.9090908@denx.de> (raw)
In-Reply-To: <CAPnjgZ0fn1wKrhffcpR63rP4_2uoFs_fHXCQYdgxH4bgxytvWA@mail.gmail.com>
On 06/08/2016 04:43 AM, Simon Glass wrote:
> Hi Marek,
Hi!
> On 25 May 2016 at 05:26, Marek Vasut <marex@denx.de> wrote:
>> On 05/25/2016 05:29 AM, Simon Glass wrote:
>>> Hi Marek,
>>>
>>> On 24 May 2016 at 18:15, Marek Vasut <marex@denx.de> wrote:
>>>> Both SYS_MALLOC_F and SPL_SYS_MALLOC_SIMPLE are generic config options,
>>>> drop them from the rockchip-specific Kconfig file.
>>>>
>>>> Signed-off-by: Marek Vasut <marex@denx.de>
>>>> Cc: Tom Rini <trini@konsulko.com>
>>>> Cc: Simon Glass <sjg@chromium.org>
>>>> ---
>>>> arch/arm/mach-rockchip/Kconfig | 6 ------
>>>> 1 file changed, 6 deletions(-)
>>>>
>>>> diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig
>>>> index d3bddb7..5f6046a 100644
>>>> --- a/arch/arm/mach-rockchip/Kconfig
>>>> +++ b/arch/arm/mach-rockchip/Kconfig
>>>> @@ -17,12 +17,6 @@ config ROCKCHIP_RK3036
>>>> and video codec support. Peripherals include Gigabit Ethernet,
>>>> USB2 host and OTG, SDIO, I2S, UART, SPI, I2C and PWMs.
>>>>
>>>> -config SYS_MALLOC_F
>>>> - default y
>>>> -
>>>> -config SPL_SYS_MALLOC_SIMPLE
>>>> - default y
>>>> -
>>>> config SPL_DM
>>>> default y
>>>>
>>>> --
>>>> 2.7.0
>>>>
>>>
>>> Will these still be enabled some other way?
>>
>> That's why it's RFC, I believe the rockchip platforms would need to add
>> those to their defconfig, right ?
>
> Well, Rockchip boards cannot work without these, which is why they default to y.
I understand that, but these Kconfig options are generic, so they
shouldn't be defined in the mach-rockchip/Kconfig file, but in some
generic Kconfig file and then selected by ARCH_ROCKCHIP symbol or in
some defconfig , right ?
--
Best regards,
Marek Vasut
next prev parent reply other threads:[~2016-06-08 3:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-25 0:15 [U-Boot] [RFC][PATCH] arm: rk: Drop SYS_MALLOC_F and SPL_SYS_MALLOC_SIMPLE Marek Vasut
2016-05-25 3:29 ` Simon Glass
2016-05-25 12:26 ` Marek Vasut
2016-06-08 2:43 ` Simon Glass
2016-06-08 3:02 ` Marek Vasut [this message]
2016-06-08 4:44 ` Simon Glass
2016-06-08 13:18 ` Marek Vasut
2016-06-10 0:34 ` Simon Glass
2016-06-10 0:59 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57578AAB.9090908@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.