From: Grygorii Strashko <grygorii.strashko@ti.com>
To: Linus Walleij <linus.walleij@linaro.org>,
Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>,
Roger Quadros <rogerq@ti.com>
Cc: Alexandre Courbot <gnurou@gmail.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] gpiolib: Fix NULL pointer deference
Date: Wed, 8 Jun 2016 12:46:42 +0300 [thread overview]
Message-ID: <5757E982.1040902@ti.com> (raw)
In-Reply-To: <CACRpkdZ42659nZnKaahFDahLY1Ey4dtTGt2nY69se=pu=jnpFw@mail.gmail.com>
On 06/08/2016 11:39 AM, Linus Walleij wrote:
> On Fri, Jun 3, 2016 at 7:10 PM, Ricardo Ribalda Delgado
> <ricardo.ribalda@gmail.com> wrote:
>
>> Under some circumstances, a gpiochip might be half cleaned from the
>> gpio_device list.
>>
>> This patch makes sure that the chip pointer is still valid, before
>> calling the match function.
>>
>> [ 104.088296] BUG: unable to handle kernel NULL pointer dereference at
>> 0000000000000090
>> [ 104.089772] IP: [<ffffffff813d2045>] of_gpiochip_find_and_xlate+0x15/0x80
>> [ 104.128273] Call Trace:
>> [ 104.129802] [<ffffffff813d2030>] ? of_parse_own_gpio+0x1f0/0x1f0
>> [ 104.131353] [<ffffffff813cd910>] gpiochip_find+0x60/0x90
>> [ 104.132868] [<ffffffff813d21ba>] of_get_named_gpiod_flags+0x9a/0x120
>> ...
>> [ 104.141586] [<ffffffff8163d12b>] gpio_led_probe+0x11b/0x360
>>
>> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
>
> Oh there is the fix that Roger and Grygorii needs.
>
> Applied to fixes and tagged for stable.
>
> Sorry for screwing things up :(
>
Np. :)
--
regards,
-grygorii
prev parent reply other threads:[~2016-06-08 9:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-03 17:10 [PATCH 1/2] gpiolib: Fix NULL pointer deference Ricardo Ribalda Delgado
2016-06-03 17:10 ` [PATCH 2/2] gpiolib: Fix unaligned used of reference counters Ricardo Ribalda Delgado
2016-06-08 8:41 ` Linus Walleij
2016-06-08 8:39 ` [PATCH 1/2] gpiolib: Fix NULL pointer deference Linus Walleij
2016-06-08 9:46 ` Grygorii Strashko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5757E982.1040902@ti.com \
--to=grygorii.strashko@ti.com \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ricardo.ribalda@gmail.com \
--cc=rogerq@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.