From mboxrd@z Thu Jan 1 00:00:00 1970 From: Archit Taneja Subject: Re: [PATCH v2 08/20] drm: msm: Rely on the default ->best_encoder() behavior where appropriate Date: Wed, 8 Jun 2016 15:39:03 +0530 Message-ID: <5757EEBF.1010501@codeaurora.org> References: <1465300095-16971-1-git-send-email-boris.brezillon@free-electrons.com> <1465300095-16971-9-git-send-email-boris.brezillon@free-electrons.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1465300095-16971-9-git-send-email-boris.brezillon@free-electrons.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Boris Brezillon , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, Daniel Vetter Cc: Krzysztof Kozlowski , Heiko Stuebner , Stefan Agner , virtualization@lists.linux-foundation.org, Thierry Reding , Laurent Pinchart , Benjamin Gaignard , Alexandre Courbot , linux-samsung-soc@vger.kernel.org, Joonyoung Shim , Alexey Brodkin , Kyungmin Park , linux-rockchip@lists.infradead.org, Chen-Yu Tsai , Kukjin Kim , linux-tegra@vger.kernel.org, Stephen Warren , linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, Inki Dae , linux-mediatek@lists.infradead.org, Matthias Brugger , Vincent Abriou List-Id: linux-arm-msm@vger.kernel.org SGksCgpPbiAwNi8wNy8yMDE2IDA1OjE4IFBNLCBCb3JpcyBCcmV6aWxsb24gd3JvdGU6Cj4gRm9y IGFsbCBvdXRwdXRzIGV4Y2VwdCBEU0kgd2UgaGF2ZSBhIDE6MSByZWxhdGlvbnNoaXAgYmV0d2Vl biBjb25uZWN0b3JzCj4gYW5kIGVuY29kZXJzIGFuZCB0aGUgZHJpdmVyIGlzIHJlbHlpbmcgb24g dGhlIGF0b21pYyBoZWxwZXJzOiB3ZSBjYW4KPiBkcm9wIHRoZSBjdXN0b20gLT5iZXN0X2VuY29k ZXIoKSBhbmQgbGV0IHRoZSBjb3JlIGNhbGwKPiBkcm1fYXRvbWljX2hlbHBlcl9iZXN0X2VuY29k ZXIoKSBmb3IgdXMuCgpXb3JrcyBmaW5lIHdpdGggbXNtLgoKVGVzdGVkLWJ5OiBBcmNoaXQgVGFu ZWphIDxhcmNoaXR0QGNvZGVhdXJvcmEub3JnPgoKVGhhbmtzLApBcmNoaXQKCj4KPiBTaWduZWQt b2ZmLWJ5OiBCb3JpcyBCcmV6aWxsb24gPGJvcmlzLmJyZXppbGxvbkBmcmVlLWVsZWN0cm9ucy5j b20+Cj4gLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vbXNtL2VkcC9lZHBfY29ubmVjdG9yLmMgICAg ICAgICAgICB8IDEwIC0tLS0tLS0tLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9tc20vaGRtaS9oZG1p X2Nvbm5lY3Rvci5jICAgICAgICAgIHwgIDggLS0tLS0tLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9t c20vbWRwL21kcDQvbWRwNF9sdmRzX2Nvbm5lY3Rvci5jIHwgIDkgLS0tLS0tLS0tCj4gICAzIGZp bGVzIGNoYW5nZWQsIDI3IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9tc20vZWRwL2VkcF9jb25uZWN0b3IuYyBiL2RyaXZlcnMvZ3B1L2RybS9tc20vZWRwL2Vk cF9jb25uZWN0b3IuYwo+IGluZGV4IDcyMzYwY2QuLjU5NjA2MjggMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL21zbS9lZHAvZWRwX2Nvbm5lY3Rvci5jCj4gKysrIGIvZHJpdmVycy9ncHUv ZHJtL21zbS9lZHAvZWRwX2Nvbm5lY3Rvci5jCj4gQEAgLTkxLDE1ICs5MSw2IEBAIHN0YXRpYyBp bnQgZWRwX2Nvbm5lY3Rvcl9tb2RlX3ZhbGlkKHN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0 b3IsCj4gICAJcmV0dXJuIE1PREVfT0s7Cj4gICB9Cj4KPiAtc3RhdGljIHN0cnVjdCBkcm1fZW5j b2RlciAqCj4gLWVkcF9jb25uZWN0b3JfYmVzdF9lbmNvZGVyKHN0cnVjdCBkcm1fY29ubmVjdG9y ICpjb25uZWN0b3IpCj4gLXsKPiAtCXN0cnVjdCBlZHBfY29ubmVjdG9yICplZHBfY29ubmVjdG9y ID0gdG9fZWRwX2Nvbm5lY3Rvcihjb25uZWN0b3IpOwo+IC0KPiAtCURCRygiIik7Cj4gLQlyZXR1 cm4gZWRwX2Nvbm5lY3Rvci0+ZWRwLT5lbmNvZGVyOwo+IC19Cj4gLQo+ICAgc3RhdGljIGNvbnN0 IHN0cnVjdCBkcm1fY29ubmVjdG9yX2Z1bmNzIGVkcF9jb25uZWN0b3JfZnVuY3MgPSB7Cj4gICAJ LmRwbXMgPSBkcm1fYXRvbWljX2hlbHBlcl9jb25uZWN0b3JfZHBtcywKPiAgIAkuZGV0ZWN0ID0g ZWRwX2Nvbm5lY3Rvcl9kZXRlY3QsCj4gQEAgLTExMyw3ICsxMDQsNiBAQCBzdGF0aWMgY29uc3Qg c3RydWN0IGRybV9jb25uZWN0b3JfZnVuY3MgZWRwX2Nvbm5lY3Rvcl9mdW5jcyA9IHsKPiAgIHN0 YXRpYyBjb25zdCBzdHJ1Y3QgZHJtX2Nvbm5lY3Rvcl9oZWxwZXJfZnVuY3MgZWRwX2Nvbm5lY3Rv cl9oZWxwZXJfZnVuY3MgPSB7Cj4gICAJLmdldF9tb2RlcyA9IGVkcF9jb25uZWN0b3JfZ2V0X21v ZGVzLAo+ICAgCS5tb2RlX3ZhbGlkID0gZWRwX2Nvbm5lY3Rvcl9tb2RlX3ZhbGlkLAo+IC0JLmJl c3RfZW5jb2RlciA9IGVkcF9jb25uZWN0b3JfYmVzdF9lbmNvZGVyLAo+ICAgfTsKPgo+ICAgLyog aW5pdGlhbGl6ZSBjb25uZWN0b3IgKi8KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL21z bS9oZG1pL2hkbWlfY29ubmVjdG9yLmMgYi9kcml2ZXJzL2dwdS9kcm0vbXNtL2hkbWkvaGRtaV9j b25uZWN0b3IuYwo+IGluZGV4IGIxNWQ3MjYuLmEyNTE1YjQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVy cy9ncHUvZHJtL21zbS9oZG1pL2hkbWlfY29ubmVjdG9yLmMKPiArKysgYi9kcml2ZXJzL2dwdS9k cm0vbXNtL2hkbWkvaGRtaV9jb25uZWN0b3IuYwo+IEBAIC00MDYsMTMgKzQwNiw2IEBAIHN0YXRp YyBpbnQgbXNtX2hkbWlfY29ubmVjdG9yX21vZGVfdmFsaWQoc3RydWN0IGRybV9jb25uZWN0b3Ig KmNvbm5lY3RvciwKPiAgIAlyZXR1cm4gMDsKPiAgIH0KPgo+IC1zdGF0aWMgc3RydWN0IGRybV9l bmNvZGVyICoKPiAtbXNtX2hkbWlfY29ubmVjdG9yX2Jlc3RfZW5jb2RlcihzdHJ1Y3QgZHJtX2Nv bm5lY3RvciAqY29ubmVjdG9yKQo+IC17Cj4gLQlzdHJ1Y3QgaGRtaV9jb25uZWN0b3IgKmhkbWlf Y29ubmVjdG9yID0gdG9faGRtaV9jb25uZWN0b3IoY29ubmVjdG9yKTsKPiAtCXJldHVybiBoZG1p X2Nvbm5lY3Rvci0+aGRtaS0+ZW5jb2RlcjsKPiAtfQo+IC0KPiAgIHN0YXRpYyBjb25zdCBzdHJ1 Y3QgZHJtX2Nvbm5lY3Rvcl9mdW5jcyBoZG1pX2Nvbm5lY3Rvcl9mdW5jcyA9IHsKPiAgIAkuZHBt cyA9IGRybV9hdG9taWNfaGVscGVyX2Nvbm5lY3Rvcl9kcG1zLAo+ICAgCS5kZXRlY3QgPSBoZG1p X2Nvbm5lY3Rvcl9kZXRlY3QsCj4gQEAgLTQyNiw3ICs0MTksNiBAQCBzdGF0aWMgY29uc3Qgc3Ry dWN0IGRybV9jb25uZWN0b3JfZnVuY3MgaGRtaV9jb25uZWN0b3JfZnVuY3MgPSB7Cj4gICBzdGF0 aWMgY29uc3Qgc3RydWN0IGRybV9jb25uZWN0b3JfaGVscGVyX2Z1bmNzIG1zbV9oZG1pX2Nvbm5l Y3Rvcl9oZWxwZXJfZnVuY3MgPSB7Cj4gICAJLmdldF9tb2RlcyA9IG1zbV9oZG1pX2Nvbm5lY3Rv cl9nZXRfbW9kZXMsCj4gICAJLm1vZGVfdmFsaWQgPSBtc21faGRtaV9jb25uZWN0b3JfbW9kZV92 YWxpZCwKPiAtCS5iZXN0X2VuY29kZXIgPSBtc21faGRtaV9jb25uZWN0b3JfYmVzdF9lbmNvZGVy LAo+ICAgfTsKPgo+ICAgLyogaW5pdGlhbGl6ZSBjb25uZWN0b3IgKi8KPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL21zbS9tZHAvbWRwNC9tZHA0X2x2ZHNfY29ubmVjdG9yLmMgYi9kcml2 ZXJzL2dwdS9kcm0vbXNtL21kcC9tZHA0L21kcDRfbHZkc19jb25uZWN0b3IuYwo+IGluZGV4IDI2 NDhjZDcuLjM1MzQyOWIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL21zbS9tZHAvbWRw NC9tZHA0X2x2ZHNfY29ubmVjdG9yLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vbXNtL21kcC9t ZHA0L21kcDRfbHZkc19jb25uZWN0b3IuYwo+IEBAIC05MCwxNCArOTAsNiBAQCBzdGF0aWMgaW50 IG1kcDRfbHZkc19jb25uZWN0b3JfbW9kZV92YWxpZChzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29u bmVjdG9yLAo+ICAgCXJldHVybiBNT0RFX09LOwo+ICAgfQo+Cj4gLXN0YXRpYyBzdHJ1Y3QgZHJt X2VuY29kZXIgKgo+IC1tZHA0X2x2ZHNfY29ubmVjdG9yX2Jlc3RfZW5jb2RlcihzdHJ1Y3QgZHJt X2Nvbm5lY3RvciAqY29ubmVjdG9yKQo+IC17Cj4gLQlzdHJ1Y3QgbWRwNF9sdmRzX2Nvbm5lY3Rv ciAqbWRwNF9sdmRzX2Nvbm5lY3RvciA9Cj4gLQkJCXRvX21kcDRfbHZkc19jb25uZWN0b3IoY29u bmVjdG9yKTsKPiAtCXJldHVybiBtZHA0X2x2ZHNfY29ubmVjdG9yLT5lbmNvZGVyOwo+IC19Cj4g LQo+ICAgc3RhdGljIGNvbnN0IHN0cnVjdCBkcm1fY29ubmVjdG9yX2Z1bmNzIG1kcDRfbHZkc19j b25uZWN0b3JfZnVuY3MgPSB7Cj4gICAJLmRwbXMgPSBkcm1fYXRvbWljX2hlbHBlcl9jb25uZWN0 b3JfZHBtcywKPiAgIAkuZGV0ZWN0ID0gbWRwNF9sdmRzX2Nvbm5lY3Rvcl9kZXRlY3QsCj4gQEAg LTExMSw3ICsxMDMsNiBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IGRybV9jb25uZWN0b3JfZnVuY3Mg bWRwNF9sdmRzX2Nvbm5lY3Rvcl9mdW5jcyA9IHsKPiAgIHN0YXRpYyBjb25zdCBzdHJ1Y3QgZHJt X2Nvbm5lY3Rvcl9oZWxwZXJfZnVuY3MgbWRwNF9sdmRzX2Nvbm5lY3Rvcl9oZWxwZXJfZnVuY3Mg PSB7Cj4gICAJLmdldF9tb2RlcyA9IG1kcDRfbHZkc19jb25uZWN0b3JfZ2V0X21vZGVzLAo+ICAg CS5tb2RlX3ZhbGlkID0gbWRwNF9sdmRzX2Nvbm5lY3Rvcl9tb2RlX3ZhbGlkLAo+IC0JLmJlc3Rf ZW5jb2RlciA9IG1kcDRfbHZkc19jb25uZWN0b3JfYmVzdF9lbmNvZGVyLAo+ICAgfTsKPgo+ICAg LyogaW5pdGlhbGl6ZSBjb25uZWN0b3IgKi8KPgoKLS0gClRoZSBRdWFsY29tbSBJbm5vdmF0aW9u IENlbnRlciwgSW5jLiBpcyBhIG1lbWJlciBvZiB0aGUgQ29kZSBBdXJvcmEgCkZvcnVtLCBob3N0 ZWQgYnkgVGhlIExpbnV4IEZvdW5kYXRpb24KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vaW50ZWwtZ2Z4Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Subject: Re: [PATCH v2 08/20] drm: msm: Rely on the default ->best_encoder() behavior where appropriate To: Boris Brezillon , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, Daniel Vetter References: <1465300095-16971-1-git-send-email-boris.brezillon@free-electrons.com> <1465300095-16971-9-git-send-email-boris.brezillon@free-electrons.com> Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Kukjin Kim , Krzysztof Kozlowski , linux-samsung-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org, Jani Nikula , Alexey Brodkin , Inki Dae , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Stefan Agner , Alison Wang , Matthias Brugger , Rob Clark , Laurent Pinchart , Mark Yao , Heiko Stuebner , Benjamin Gaignard , Vincent Abriou , Maxime Ripard , Chen-Yu Tsai , Thierry Reding , Stephen Warren , Alexandre Courbot , Eric Anholt , Gerd Hoffmann , linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org, virtualization@lists.linux-foundation.org From: Archit Taneja Message-ID: <5757EEBF.1010501@codeaurora.org> Date: Wed, 8 Jun 2016 15:39:03 +0530 MIME-Version: 1.0 In-Reply-To: <1465300095-16971-9-git-send-email-boris.brezillon@free-electrons.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: Hi, On 06/07/2016 05:18 PM, Boris Brezillon wrote: > For all outputs except DSI we have a 1:1 relationship between connectors > and encoders and the driver is relying on the atomic helpers: we can > drop the custom ->best_encoder() and let the core call > drm_atomic_helper_best_encoder() for us. Works fine with msm. Tested-by: Archit Taneja Thanks, Archit > > Signed-off-by: Boris Brezillon > --- > drivers/gpu/drm/msm/edp/edp_connector.c | 10 ---------- > drivers/gpu/drm/msm/hdmi/hdmi_connector.c | 8 -------- > drivers/gpu/drm/msm/mdp/mdp4/mdp4_lvds_connector.c | 9 --------- > 3 files changed, 27 deletions(-) > > diff --git a/drivers/gpu/drm/msm/edp/edp_connector.c b/drivers/gpu/drm/msm/edp/edp_connector.c > index 72360cd..5960628 100644 > --- a/drivers/gpu/drm/msm/edp/edp_connector.c > +++ b/drivers/gpu/drm/msm/edp/edp_connector.c > @@ -91,15 +91,6 @@ static int edp_connector_mode_valid(struct drm_connector *connector, > return MODE_OK; > } > > -static struct drm_encoder * > -edp_connector_best_encoder(struct drm_connector *connector) > -{ > - struct edp_connector *edp_connector = to_edp_connector(connector); > - > - DBG(""); > - return edp_connector->edp->encoder; > -} > - > static const struct drm_connector_funcs edp_connector_funcs = { > .dpms = drm_atomic_helper_connector_dpms, > .detect = edp_connector_detect, > @@ -113,7 +104,6 @@ static const struct drm_connector_funcs edp_connector_funcs = { > static const struct drm_connector_helper_funcs edp_connector_helper_funcs = { > .get_modes = edp_connector_get_modes, > .mode_valid = edp_connector_mode_valid, > - .best_encoder = edp_connector_best_encoder, > }; > > /* initialize connector */ > diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_connector.c b/drivers/gpu/drm/msm/hdmi/hdmi_connector.c > index b15d726..a2515b4 100644 > --- a/drivers/gpu/drm/msm/hdmi/hdmi_connector.c > +++ b/drivers/gpu/drm/msm/hdmi/hdmi_connector.c > @@ -406,13 +406,6 @@ static int msm_hdmi_connector_mode_valid(struct drm_connector *connector, > return 0; > } > > -static struct drm_encoder * > -msm_hdmi_connector_best_encoder(struct drm_connector *connector) > -{ > - struct hdmi_connector *hdmi_connector = to_hdmi_connector(connector); > - return hdmi_connector->hdmi->encoder; > -} > - > static const struct drm_connector_funcs hdmi_connector_funcs = { > .dpms = drm_atomic_helper_connector_dpms, > .detect = hdmi_connector_detect, > @@ -426,7 +419,6 @@ static const struct drm_connector_funcs hdmi_connector_funcs = { > static const struct drm_connector_helper_funcs msm_hdmi_connector_helper_funcs = { > .get_modes = msm_hdmi_connector_get_modes, > .mode_valid = msm_hdmi_connector_mode_valid, > - .best_encoder = msm_hdmi_connector_best_encoder, > }; > > /* initialize connector */ > diff --git a/drivers/gpu/drm/msm/mdp/mdp4/mdp4_lvds_connector.c b/drivers/gpu/drm/msm/mdp/mdp4/mdp4_lvds_connector.c > index 2648cd7..353429b 100644 > --- a/drivers/gpu/drm/msm/mdp/mdp4/mdp4_lvds_connector.c > +++ b/drivers/gpu/drm/msm/mdp/mdp4/mdp4_lvds_connector.c > @@ -90,14 +90,6 @@ static int mdp4_lvds_connector_mode_valid(struct drm_connector *connector, > return MODE_OK; > } > > -static struct drm_encoder * > -mdp4_lvds_connector_best_encoder(struct drm_connector *connector) > -{ > - struct mdp4_lvds_connector *mdp4_lvds_connector = > - to_mdp4_lvds_connector(connector); > - return mdp4_lvds_connector->encoder; > -} > - > static const struct drm_connector_funcs mdp4_lvds_connector_funcs = { > .dpms = drm_atomic_helper_connector_dpms, > .detect = mdp4_lvds_connector_detect, > @@ -111,7 +103,6 @@ static const struct drm_connector_funcs mdp4_lvds_connector_funcs = { > static const struct drm_connector_helper_funcs mdp4_lvds_connector_helper_funcs = { > .get_modes = mdp4_lvds_connector_get_modes, > .mode_valid = mdp4_lvds_connector_mode_valid, > - .best_encoder = mdp4_lvds_connector_best_encoder, > }; > > /* initialize connector */ > -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation From mboxrd@z Thu Jan 1 00:00:00 1970 From: architt@codeaurora.org (Archit Taneja) Date: Wed, 8 Jun 2016 15:39:03 +0530 Subject: [PATCH v2 08/20] drm: msm: Rely on the default ->best_encoder() behavior where appropriate In-Reply-To: <1465300095-16971-9-git-send-email-boris.brezillon@free-electrons.com> References: <1465300095-16971-1-git-send-email-boris.brezillon@free-electrons.com> <1465300095-16971-9-git-send-email-boris.brezillon@free-electrons.com> Message-ID: <5757EEBF.1010501@codeaurora.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On 06/07/2016 05:18 PM, Boris Brezillon wrote: > For all outputs except DSI we have a 1:1 relationship between connectors > and encoders and the driver is relying on the atomic helpers: we can > drop the custom ->best_encoder() and let the core call > drm_atomic_helper_best_encoder() for us. Works fine with msm. Tested-by: Archit Taneja Thanks, Archit > > Signed-off-by: Boris Brezillon > --- > drivers/gpu/drm/msm/edp/edp_connector.c | 10 ---------- > drivers/gpu/drm/msm/hdmi/hdmi_connector.c | 8 -------- > drivers/gpu/drm/msm/mdp/mdp4/mdp4_lvds_connector.c | 9 --------- > 3 files changed, 27 deletions(-) > > diff --git a/drivers/gpu/drm/msm/edp/edp_connector.c b/drivers/gpu/drm/msm/edp/edp_connector.c > index 72360cd..5960628 100644 > --- a/drivers/gpu/drm/msm/edp/edp_connector.c > +++ b/drivers/gpu/drm/msm/edp/edp_connector.c > @@ -91,15 +91,6 @@ static int edp_connector_mode_valid(struct drm_connector *connector, > return MODE_OK; > } > > -static struct drm_encoder * > -edp_connector_best_encoder(struct drm_connector *connector) > -{ > - struct edp_connector *edp_connector = to_edp_connector(connector); > - > - DBG(""); > - return edp_connector->edp->encoder; > -} > - > static const struct drm_connector_funcs edp_connector_funcs = { > .dpms = drm_atomic_helper_connector_dpms, > .detect = edp_connector_detect, > @@ -113,7 +104,6 @@ static const struct drm_connector_funcs edp_connector_funcs = { > static const struct drm_connector_helper_funcs edp_connector_helper_funcs = { > .get_modes = edp_connector_get_modes, > .mode_valid = edp_connector_mode_valid, > - .best_encoder = edp_connector_best_encoder, > }; > > /* initialize connector */ > diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_connector.c b/drivers/gpu/drm/msm/hdmi/hdmi_connector.c > index b15d726..a2515b4 100644 > --- a/drivers/gpu/drm/msm/hdmi/hdmi_connector.c > +++ b/drivers/gpu/drm/msm/hdmi/hdmi_connector.c > @@ -406,13 +406,6 @@ static int msm_hdmi_connector_mode_valid(struct drm_connector *connector, > return 0; > } > > -static struct drm_encoder * > -msm_hdmi_connector_best_encoder(struct drm_connector *connector) > -{ > - struct hdmi_connector *hdmi_connector = to_hdmi_connector(connector); > - return hdmi_connector->hdmi->encoder; > -} > - > static const struct drm_connector_funcs hdmi_connector_funcs = { > .dpms = drm_atomic_helper_connector_dpms, > .detect = hdmi_connector_detect, > @@ -426,7 +419,6 @@ static const struct drm_connector_funcs hdmi_connector_funcs = { > static const struct drm_connector_helper_funcs msm_hdmi_connector_helper_funcs = { > .get_modes = msm_hdmi_connector_get_modes, > .mode_valid = msm_hdmi_connector_mode_valid, > - .best_encoder = msm_hdmi_connector_best_encoder, > }; > > /* initialize connector */ > diff --git a/drivers/gpu/drm/msm/mdp/mdp4/mdp4_lvds_connector.c b/drivers/gpu/drm/msm/mdp/mdp4/mdp4_lvds_connector.c > index 2648cd7..353429b 100644 > --- a/drivers/gpu/drm/msm/mdp/mdp4/mdp4_lvds_connector.c > +++ b/drivers/gpu/drm/msm/mdp/mdp4/mdp4_lvds_connector.c > @@ -90,14 +90,6 @@ static int mdp4_lvds_connector_mode_valid(struct drm_connector *connector, > return MODE_OK; > } > > -static struct drm_encoder * > -mdp4_lvds_connector_best_encoder(struct drm_connector *connector) > -{ > - struct mdp4_lvds_connector *mdp4_lvds_connector = > - to_mdp4_lvds_connector(connector); > - return mdp4_lvds_connector->encoder; > -} > - > static const struct drm_connector_funcs mdp4_lvds_connector_funcs = { > .dpms = drm_atomic_helper_connector_dpms, > .detect = mdp4_lvds_connector_detect, > @@ -111,7 +103,6 @@ static const struct drm_connector_funcs mdp4_lvds_connector_funcs = { > static const struct drm_connector_helper_funcs mdp4_lvds_connector_helper_funcs = { > .get_modes = mdp4_lvds_connector_get_modes, > .mode_valid = mdp4_lvds_connector_mode_valid, > - .best_encoder = mdp4_lvds_connector_best_encoder, > }; > > /* initialize connector */ > -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation