From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43531) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAaRG-0001M2-86 for qemu-devel@nongnu.org; Wed, 08 Jun 2016 06:10:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bAaRC-0006dm-4D for qemu-devel@nongnu.org; Wed, 08 Jun 2016 06:10:18 -0400 Received: from [59.151.112.132] (port=51311 helo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAaRA-0006YM-PO for qemu-devel@nongnu.org; Wed, 08 Jun 2016 06:10:14 -0400 References: <1465200062-13824-1-git-send-email-caoj.fnst@cn.fujitsu.com> From: Cao jin Message-ID: <5757F038.4090702@cn.fujitsu.com> Date: Wed, 8 Jun 2016 18:15:20 +0800 MIME-Version: 1.0 In-Reply-To: <1465200062-13824-1-git-send-email-caoj.fnst@cn.fujitsu.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v7 00/15] Add param Error ** for msi_init() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Jason Wang , Markus Armbruster , Marcel Apfelbaum , Alex Williamson , Hannes Reinecke , Dmitry Fleytman , Paolo Bonzini , John Snow , Gerd Hoffmann ping~ On 06/06/2016 04:00 PM, Cao jin wrote: > v7 changelog: > 1. 4 new patches, patch 11, 13, 14, 15. previous patch 11 numbered 12 now. > 2. patch 2: remove comment of "errp", add it in patch 12 > 3. patch 4: fix commit message as sugguestion > 4. replace all "msi == ON_OFF_AUTO_ON || msi == ON_OFF_AUTO_AUTO" to > "msi != ON_OFF_AUTO_OFF", before patch 12 > 5. patch 7: correct a error in intel_hda_update_irq(), and change the > variant type from int to bool > 6. patch 13: fix the issue that code would overwrite user configuration. > patch 14&15 actually almost the same with 13, remove unnecessary flag. > 7. patch 12 use tightened error checking as suggestions, but not sure > megasas/mptsas is modified as sugguestion perfectly, RFC. > > cc: Gerd Hoffmann > cc: John Snow > cc: Dmitry Fleytman > cc: Jason Wang > cc: Michael S. Tsirkin > cc: Hannes Reinecke > cc: Paolo Bonzini > cc: Alex Williamson > cc: Markus Armbruster > cc: Marcel Apfelbaum > > Cao jin (15): > pci core: assert ENOSPC when add capability > fix some coding style problems > change pvscsi_init_msi() type to void > megasas: Fix check for msi_init() failure > mptsas: change .realize function name > usb xhci: change msi/msix property type > intel-hda: change msi property type > mptsas: change msi property type > megasas: change msi/msix property type > pci bridge dev: change msi property type > msi_init: change return value to 0 on success > pci: Convert msi_init() to Error and fix callers to check it > megasas: remove unnecessary megasas_use_msi() > mptsas: remove unnecessary internal msi state flag > vmw_pvscsi: remove unnecessary internal msi state flag > > hw/audio/intel-hda.c | 30 ++++++++++++++++---- > hw/ide/ich.c | 15 ++++++---- > hw/net/vmxnet3.c | 40 +++++++++----------------- > hw/pci-bridge/ioh3420.c | 13 +++++++-- > hw/pci-bridge/pci_bridge_dev.c | 35 +++++++++++++++++------ > hw/pci-bridge/xio3130_downstream.c | 12 ++++++-- > hw/pci-bridge/xio3130_upstream.c | 9 +++++- > hw/pci/msi.c | 27 ++++++++++++++++-- > hw/pci/pci.c | 6 ++-- > hw/scsi/megasas.c | 58 ++++++++++++++++++++------------------ > hw/scsi/mptsas.c | 40 +++++++++++++++++--------- > hw/scsi/mptsas.h | 5 ++-- > hw/scsi/vmw_pvscsi.c | 22 +++++---------- > hw/usb/hcd-xhci.c | 35 +++++++++++++++++------ > hw/vfio/pci.c | 7 +++-- > include/hw/pci/msi.h | 3 +- > 16 files changed, 226 insertions(+), 131 deletions(-) > -- Yours Sincerely, Cao jin