From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mx6qsabreauto: Avoid hardcoded RAM size
Date: Wed, 8 Jun 2016 20:42:07 +0200 [thread overview]
Message-ID: <575866FF.3070201@denx.de> (raw)
In-Reply-To: <1465409874-22030-1-git-send-email-vanessa.maegima@nxp.com>
Hi Vanessa,
On 08/06/2016 20:17, Vanessa Maegima wrote:
> Instead of passing the total RAM size via PHYS_SDRAM_SIZE option,
> we should better use imx_ddr_size() function, which automatically
> determines the RAM size.
>
> Signed-off-by: Vanessa Maegima <vanessa.maegima@nxp.com>
> ---
> board/freescale/mx6qsabreauto/mx6qsabreauto.c | 2 +-
> include/configs/mx6qsabreauto.h | 1 -
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/board/freescale/mx6qsabreauto/mx6qsabreauto.c b/board/freescale/mx6qsabreauto/mx6qsabreauto.c
> index d63a979..a3ed4cd 100644
> --- a/board/freescale/mx6qsabreauto/mx6qsabreauto.c
> +++ b/board/freescale/mx6qsabreauto/mx6qsabreauto.c
> @@ -64,7 +64,7 @@ DECLARE_GLOBAL_DATA_PTR;
>
> int dram_init(void)
> {
> - gd->ram_size = get_ram_size((void *)PHYS_SDRAM, PHYS_SDRAM_SIZE);
> + gd->ram_size = imx_ddr_size();
>
Right - this board was not yet updated.
> return 0;
> }
> diff --git a/include/configs/mx6qsabreauto.h b/include/configs/mx6qsabreauto.h
> index 6039fc4..200e468 100644
> --- a/include/configs/mx6qsabreauto.h
> +++ b/include/configs/mx6qsabreauto.h
> @@ -13,7 +13,6 @@
> #define CONFIG_MXC_UART_BASE UART4_BASE
> #define CONFIG_CONSOLE_DEV "ttymxc3"
> #define CONFIG_MMCROOT "/dev/mmcblk0p2"
> -#define PHYS_SDRAM_SIZE (2u * 1024 * 1024 * 1024)
>
> /* USB Configs */
> #define CONFIG_USB_EHCI
>
Acked-by: Stefano Babic <sbabic@denx.de>
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
next prev parent reply other threads:[~2016-06-08 18:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-08 18:17 [U-Boot] [PATCH] mx6qsabreauto: Avoid hardcoded RAM size Vanessa Maegima
2016-06-08 18:42 ` Stefano Babic [this message]
2016-06-08 20:48 ` Fabio Estevam
2016-06-18 8:54 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=575866FF.3070201@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.