Re: [Qemu-devel] [RFC PATCH] configure: Enable -Werror for MinGW builds, too

[Stefan Weil <sw@weilnetz.de>]

[-- Attachment #1: Type: text/plain, Size: 1364 bytes --]

Am 08.06.2016 um 20:55 schrieb Peter Maydell:
> On 8 June 2016 at 15:09, Stefan Hajnoczi <stefanha@redhat.com> wrote:
>> On Wed, Jun 08, 2016 at 10:13:26AM +0200, Thomas Huth wrote:
>>> MinGW seems to compile currently without warnings, so it should
>>> be safe to enable -Werror now for this environment, too.
>>>
>>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>>> ---
>>>  ... at least it compiles without errors for me here. I hope that's
>>>  also true for different versions of MinGW ... would be great if
>>>  everybody who has such a compiler installed could give it a try!
>>>
>>>  configure | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> mingw 5.2.0-1.fc23 does not produce any warnings anymore.
>>
>> Tested-by: Stefan Hajnoczi <stefanha@redhat.com>
> 
> My w32/w64 builds need -Wno-unused-local-typedefs to build
> with -Werror, but that's the fault of the glib headers I build
> against and I already configure like that in order to use -Werror.
> 
> We should check whether we can enable -Werror for OSX too.
> 
> thanks
> -- PMM

The last time when I tried OS X there were some deprecation warnings.
If those are fixed now we can enable -Werror for all target platforms
(we could do that anyway because in case of problems it's always
possible to disable it for individual builds).

Stefan




[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]