From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH] ARM: exynos_defconfig add CONFIG_EXYNOS_IOMMU in not set mode Date: Thu, 09 Jun 2016 07:04:06 +0200 Message-ID: <5758F8C6.2090700@samsung.com> References: <1465406523-7075-1-git-send-email-shuahkh@osg.samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: Received: from mailout2.w1.samsung.com ([210.118.77.12]:40206 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751354AbcFIFEN (ORCPT ); Thu, 9 Jun 2016 01:04:13 -0400 In-reply-to: <1465406523-7075-1-git-send-email-shuahkh@osg.samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Shuah Khan , linux@armlinux.org.uk, kgene@kernel.org, javier@osg.samsung.com, linux.amoon@gmail.com, m.szyprowski@samsung.com, treding@nvidia.com, b.zolnierkie@samsung.com Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org On 06/08/2016 07:22 PM, Shuah Khan wrote: > Add CONFIG_EXYNOS_IOMMU in not set mode to make it easier to enable it. Hmmm... How does it make it easier? Enabling such item is just adding new line, so what is the problem solved here? Anyway the line will disappear on first savedefconfig (because it should not be there...) so there is really no point of it. Best regards, Krzysztof > > Signed-off-by: Shuah Khan > --- > arch/arm/configs/exynos_defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig > index daf9762..16c2957 100644 > --- a/arch/arm/configs/exynos_defconfig > +++ b/arch/arm/configs/exynos_defconfig > @@ -218,6 +218,7 @@ CONFIG_CROS_EC_CHARDEV=y > CONFIG_COMMON_CLK_MAX77686=y > CONFIG_COMMON_CLK_MAX77802=y > CONFIG_COMMON_CLK_S2MPS11=y > +# CONFIG_EXYNOS_IOMMU is not set > CONFIG_EXTCON=y > CONFIG_EXTCON_MAX14577=y > CONFIG_EXTCON_MAX77693=y From mboxrd@z Thu Jan 1 00:00:00 1970 From: k.kozlowski@samsung.com (Krzysztof Kozlowski) Date: Thu, 09 Jun 2016 07:04:06 +0200 Subject: [PATCH] ARM: exynos_defconfig add CONFIG_EXYNOS_IOMMU in not set mode In-Reply-To: <1465406523-7075-1-git-send-email-shuahkh@osg.samsung.com> References: <1465406523-7075-1-git-send-email-shuahkh@osg.samsung.com> Message-ID: <5758F8C6.2090700@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 06/08/2016 07:22 PM, Shuah Khan wrote: > Add CONFIG_EXYNOS_IOMMU in not set mode to make it easier to enable it. Hmmm... How does it make it easier? Enabling such item is just adding new line, so what is the problem solved here? Anyway the line will disappear on first savedefconfig (because it should not be there...) so there is really no point of it. Best regards, Krzysztof > > Signed-off-by: Shuah Khan > --- > arch/arm/configs/exynos_defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig > index daf9762..16c2957 100644 > --- a/arch/arm/configs/exynos_defconfig > +++ b/arch/arm/configs/exynos_defconfig > @@ -218,6 +218,7 @@ CONFIG_CROS_EC_CHARDEV=y > CONFIG_COMMON_CLK_MAX77686=y > CONFIG_COMMON_CLK_MAX77802=y > CONFIG_COMMON_CLK_S2MPS11=y > +# CONFIG_EXYNOS_IOMMU is not set > CONFIG_EXTCON=y > CONFIG_EXTCON_MAX14577=y > CONFIG_EXTCON_MAX77693=y