From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 7/8] x86: Probe pinctrl driver in cpu_init_r()
Date: Thu, 9 Jun 2016 08:10:44 +0200 [thread overview]
Message-ID: <57590864.9020408@denx.de> (raw)
In-Reply-To: <1465387659-30011-8-git-send-email-bmeng.cn@gmail.com>
On 08.06.2016 14:07, Bin Meng wrote:
> At present pinctrl driver gets probed in ich6_gpio driver's probe
> routine, which has two issues:
>
> - Pin's PADs only gets configured when GPIO driver is probed, which
> is not done by default. This leaves the board in a partially
> functional state as we must initialize PADs correctly to get
> perepherals fully working.
> - The probe routine of pinctrl driver is called multiple times, as
> normally there are multiple GPIO controllers. It should really
> be called just once.
>
> Move the call to syscon_get_by_driver_data() from ich6_gpio driver
> to cpu_init_r().
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Reviewed-by: Stefan Roese <sr@denx.de>
Thanks,
Stefan
next prev parent reply other threads:[~2016-06-09 6:10 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-08 12:07 [U-Boot] [PATCH 0/8] x86: baytrail: Various fixes to pinctrl driver to enable SD in Linux Bin Meng
2016-06-08 12:07 ` [U-Boot] [PATCH 1/8] x86: ich6_gpio: Output return value of syscon_get_by_driver_data() Bin Meng
2016-06-09 5:15 ` Stefan Roese
2016-06-10 0:35 ` Simon Glass
2016-06-12 4:23 ` Bin Meng
2016-06-08 12:07 ` [U-Boot] [PATCH 2/8] x86: baytrail: Add 'reg' property in the pinctrl node Bin Meng
2016-06-09 5:15 ` Stefan Roese
2016-06-10 0:35 ` Simon Glass
2016-06-12 4:23 ` Bin Meng
2016-06-08 12:07 ` [U-Boot] [PATCH 3/8] x86: baytrail: Change fsp, emmc-boot-mode to "auto" Bin Meng
2016-06-09 6:07 ` Stefan Roese
2016-06-10 0:35 ` Simon Glass
2016-06-12 4:24 ` Bin Meng
2016-06-08 12:07 ` [U-Boot] [PATCH 4/8] x86: baytrail: Configure card detect pin of the SD controller Bin Meng
2016-06-09 6:08 ` Stefan Roese
2016-06-10 0:35 ` Simon Glass
2016-06-12 4:24 ` Bin Meng
2016-06-08 12:07 ` [U-Boot] [PATCH 5/8] x86: Update x86-pinctrl driver device-tree-bindings doc Bin Meng
2016-06-09 6:08 ` Stefan Roese
2016-06-10 0:35 ` Simon Glass
2016-06-12 4:24 ` Bin Meng
2016-06-08 12:07 ` [U-Boot] [PATCH 6/8] x86: Enable regmap and syscon for coreboot and qemu-x86 Bin Meng
2016-06-09 6:09 ` Stefan Roese
2016-06-10 0:35 ` Simon Glass
2016-06-12 4:24 ` Bin Meng
2016-06-08 12:07 ` [U-Boot] [PATCH 7/8] x86: Probe pinctrl driver in cpu_init_r() Bin Meng
2016-06-09 6:10 ` Stefan Roese [this message]
2016-06-10 0:35 ` Simon Glass
2016-06-11 0:59 ` Bin Meng
2016-06-10 18:33 ` George McCollister
2016-06-12 4:24 ` Bin Meng
2016-06-08 12:07 ` [U-Boot] [PATCH 8/8] x86: broadwell: gpio: Remove the codes to set up pin control Bin Meng
2016-06-09 6:10 ` Stefan Roese
2016-06-10 0:36 ` Simon Glass
2016-06-12 4:24 ` Bin Meng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57590864.9020408@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.