From: Daniel Borkmann <daniel@iogearbox.net>
To: Ben Dooks <ben.dooks@codethink.co.uk>,
linux-kernel@lists.codethink.co.uk
Cc: "David S. Miller" <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
James Morris <jmorris@namei.org>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Patrick McHardy <kaber@trash.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH] net: ipconfgi: add declaration for ic_addrservaddr
Date: Thu, 09 Jun 2016 14:15:43 +0200 [thread overview]
Message-ID: <57595DEF.8010105@iogearbox.net> (raw)
In-Reply-To: <ab991904-5443-1b2a-cae0-ff9697690f05@codethink.co.uk>
On 06/09/2016 02:11 PM, Ben Dooks wrote:
> On 09/06/16 12:35, Daniel Borkmann wrote:
>> On 06/09/2016 01:07 PM, Ben Dooks wrote:
>>> The symbol ic_addrservaddr is not static, but has no declaration
>>> to match. Since the similar variables are all exported, add this
>>> one to the header file as well.
>>>
>>> This fixes the following warning:
>>>
>>> net/ipv4/ipconfig.c:130:8: warning: symbol 'ic_addrservaddr' was not
>>> declared. Should it be static?
>>>
>>> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
>>
>> Well, how about making it actually static if it's only used
>> from ipconfig.c ?
>
> The only reason is that I thought someone might want to
> use it in the future. I have no particular insight though.
Usual policy is that if such thing is required, then it can be
exported along with the code that is making use of it from elsewhere.
Thanks,
Daniel
next prev parent reply other threads:[~2016-06-09 12:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-09 11:07 [PATCH] net: ipconfgi: add declaration for ic_addrservaddr Ben Dooks
2016-06-09 11:35 ` Daniel Borkmann
2016-06-09 12:11 ` Ben Dooks
2016-06-09 12:15 ` Daniel Borkmann [this message]
2016-06-09 18:45 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57595DEF.8010105@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=ben.dooks@codethink.co.uk \
--cc=davem@davemloft.net \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@lists.codethink.co.uk \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.