From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 00D47E00D4C; Thu, 9 Jun 2016 06:19:13 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low * trust * [209.85.220.53 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily * valid * -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Received: from mail-pa0-f53.google.com (mail-pa0-f53.google.com [209.85.220.53]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id EECEBE00D45 for ; Thu, 9 Jun 2016 06:19:12 -0700 (PDT) Received: by mail-pa0-f53.google.com with SMTP id b5so12854188pas.3 for ; Thu, 09 Jun 2016 06:19:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding; bh=P8yL8I5jxMD5grcJi6W+AKwlJ/P4ghoVArSD54fzOA4=; b=ebZe5zMFBP36XuW0ozgC4LoHwSa7idTzDMK3fGAoldkULzDy/RBniEyL833XjPytRJ 8kDUZ/flIK4FwNErXdt+ik8PHXhe2dZMB4EeiP1V0ojpl8LIGhevkPRt4W9HWpZVmsLB WuemadXj9uj9zw8JMqnlhsczFuP/ctYkCv2ISs01ntlH1w4fBgALuRC5p+nTuZLf4JhT kqjVEaQMQunmkAuNwLDV3TjsFjVMGlujGgZjiPz1l3lcYWL92NxtKNC8E3NltPL8txEL vx40zbfJMIBQyISkMvVsKjiWAfJPB4H8fr8u+Of1MnARsO32p1iHmSq+WO6jE/Obe7Vt K+jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=P8yL8I5jxMD5grcJi6W+AKwlJ/P4ghoVArSD54fzOA4=; b=YvGaBP8RgDg9Upa+ep5SdYQOaAqrIKG05Kx6G7BeE9HJNmq7ScFJVDATAflTL9apAs JXvV8FbH5q1cSUNajDUhRId6kSsZVTwJoFaNdu+t3VraDZJ4i51PuYzg1iEcYtiD6KRI s+TNnIPF6NX8t+Kr979eKJQawQM4+4+CY5FKBDqHYN31Zn+SdqzUE5Rfq2Pg/UzSnEJF 48y8EmsDTDggG1P5qanmS5X/u5GTd3hj0g/cwmIA2N9EwJt/SVybB7xOhMYuydcdY47H LOf+kUBsN/kfhf1tQjbVoEMC8qKoab92qjQIe1Iq6omnGczGfwr4gpssTUrWLfx3kQqv w49A== X-Gm-Message-State: ALyK8tL/Yllp/8x1xxep/dWwMFATAEJjLNFGi6ETvBXqaiCxtefgFYtw5mnTqWDtHkdkggAd X-Received: by 10.66.142.199 with SMTP id ry7mr12290259pab.14.1465478351606; Thu, 09 Jun 2016 06:19:11 -0700 (PDT) Received: from [192.168.2.143] ([83.217.123.106]) by smtp.googlemail.com with ESMTPSA id c13sm10226154pfc.40.2016.06.09.06.19.10 for (version=TLSv1/SSLv3 cipher=OTHER); Thu, 09 Jun 2016 06:19:10 -0700 (PDT) To: toaster@yoctoproject.org References: <1461687172-31204-1-git-send-email-elliot.smith@intel.com> From: Michael Wood Message-ID: <57596CCC.5040207@intel.com> Date: Thu, 9 Jun 2016 14:19:08 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: Subject: Re: [PATCH] toaster-tests: maximize browser window when running UI tests X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Jun 2016 13:19:14 -0000 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Thanks - Added to toaster-next Michael On 28/04/16 14:57, Barros Pena, Belen wrote: > > On 28/04/2016 14:31, "Smith, Elliot" wrote: > >> On 28 April 2016 at 14:23, Barros Pena, Belen >> wrote: >> >> On 26/04/2016 17:12, "toaster-bounces@yoctoproject.org on behalf of Elliot >> Smith" > elliot.smith@intel.com> wrote: >> >>> In some pages of the UI, the UI tests failed because parts of >>> the UI which should be visible were being reported as not >>> visible by the Selenium PhantomJS driver. >>> >>> On investigation, it turns out that PhantomJS uses a very narrow >>> default window. This meant that some parts of the UI were being >>> clipped and were thus not "visible" to the driver, causing test >>> failures (specifically, on the new custom image page). >> Interesting: Bootstrap is responsive, so stuff should still be visible. >> Although our implementation of the responsive layout is not very clean, >> components (with the exception of tables in very narrow viewports) should >> wrap or stack vertically. >> >> Do you happen to know what's the viewport size of the PhantomJS default >> window? Figuring out what's going on might help with the work migrating to >> Bootstrap 3. >> >> >> >> >> About 194px. I've attached a screenshot. > Excellent: so tables and modals are causing the trouble. This is good to > know. > > Thanks! > > Belén > >> >> Elliot >> >> >> >> >> Thanks! >> >> Belén >> >>> Ensure that the window is maximized before running tests to >>> prevent this happening. >>> >>> Signed-off-by: Elliot Smith >>> --- >>> bitbake/lib/toaster/tests/browser/selenium_helpers.py | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/bitbake/lib/toaster/tests/browser/selenium_helpers.py >>> b/bitbake/lib/toaster/tests/browser/selenium_helpers.py >>> index 56dbe2b..54db2e8 100644 >>> --- a/bitbake/lib/toaster/tests/browser/selenium_helpers.py >>> +++ b/bitbake/lib/toaster/tests/browser/selenium_helpers.py >>> @@ -130,6 +130,7 @@ class SeleniumTestCase(StaticLiveServerTestCase): >>> # instantiate the Selenium webdriver once for all the test >>> methods >>> # in this test case >>> cls.driver = create_selenium_driver() >>> + cls.driver.maximize_window() >>> >>> @classmethod >>> def tearDownClass(cls): >>> -- >>> 1.9.3 >>> >>> --------------------------------------------------------------------- >>> Intel Corporation (UK) Limited >>> Registered No. 1134945 (England) >>> Registered Office: Pipers Way, Swindon SN3 1RJ >>> VAT No: 860 2173 47 >>> >>> This e-mail and any attachments may contain confidential material for >>> the sole use of the intended recipient(s). Any review or distribution >>> by others is strictly prohibited. If you are not the intended >>> recipient, please contact the sender and delete all copies. >>> >> >>> -- >>> _______________________________________________ >>> toaster mailing list >>> toaster@yoctoproject.org >>> https://lists.yoctoproject.org/listinfo/toaster >> >> >> >> >> >> >> >> -- >> Elliot Smith >> Software Engineer >> Intel Open Source Technology Centre >> >> >> >>