All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcel Apfelbaum <marcel@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>,
	David Kiarie <davidkiarie4@gmail.com>
Cc: qemu-devel@nongnu.org, imammedo@redhat.com, jasowang@redhat.com,
	mst@redhat.com, pbonzini@redhat.com, jan.kiszka@web.de,
	rkrcmar@redhat.com, alex.williamson@redhat.com, wexu@redhat.com,
	valentine.sinitsyn@gmail.com, peterx@redhat.com
Subject: Re: [Qemu-devel] [RFC] Allow AMD IOMMU to have both SysBusDevice and PCIDevice properties.
Date: Thu, 9 Jun 2016 16:23:02 +0300	[thread overview]
Message-ID: <57596DB6.3080702@redhat.com> (raw)
In-Reply-To: <20160607191239.GB18662@thinpad.lan.raisama.net>

On 06/07/2016 10:12 PM, Eduardo Habkost wrote:
> Hi,
>

[...]

> [...]
>> diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c
>> index 04aae89..431eaed 100644
>> --- a/hw/i386/pc_q35.c
>> +++ b/hw/i386/pc_q35.c
>> @@ -281,6 +281,7 @@ static void pc_q35_machine_options(MachineClass *m)
>>       m->default_machine_opts = "firmware=bios-256k.bin";
>>       m->default_display = "std";
>>       m->no_floppy = 1;
>> +    m->has_dynamic_sysbus = true;
>
> Why is this needed? Is it possible to do this change before
> adding the iommu code?  Can this be done in a separate patch that
> documents why it should be changed and why it is safe to set it
> to true?
>
>>

Hi Eduardo,

I also have this change as part of '[PATCH v2 0/3] enable iommu with -device'.

Please see:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg374644.html


Thanks,
Marcel

  parent reply	other threads:[~2016-06-09 13:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-05 16:54 [Qemu-devel] [RFC] AMD IOMMU: emulate multiple devices David Kiarie
2016-06-05 16:54 ` [Qemu-devel] [RFC] Allow AMD IOMMU to have both SysBusDevice and PCIDevice properties David Kiarie
2016-06-07 19:12   ` Eduardo Habkost
2016-06-07 19:32     ` David Kiarie
2016-06-08  2:17       ` Peter Xu
2016-06-09 13:23     ` Marcel Apfelbaum [this message]
2016-06-11 12:01       ` David Kiarie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57596DB6.3080702@redhat.com \
    --to=marcel@redhat.com \
    --cc=alex.williamson@redhat.com \
    --cc=davidkiarie4@gmail.com \
    --cc=ehabkost@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=jan.kiszka@web.de \
    --cc=jasowang@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rkrcmar@redhat.com \
    --cc=valentine.sinitsyn@gmail.com \
    --cc=wexu@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.