From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 1DA41E00D4E; Thu, 9 Jun 2016 06:42:45 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low * trust * [74.125.82.49 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily * valid * -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id E3DA8E00D45 for ; Thu, 9 Jun 2016 06:42:42 -0700 (PDT) Received: by mail-wm0-f49.google.com with SMTP id v199so108185576wmv.0 for ; Thu, 09 Jun 2016 06:42:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding; bh=zqLnE6F1bxJqqGpZrIAnNJwDUTII4odi1idRDd5M3T0=; b=UnLOzzGEbK/lgMy56aFEiWeyiSJFNO2RrxLt+Gte9P+Gtrnt72mPkpIgQXNOvBHfUl OFJrlAtzlPd4lRD3PmM8MxQ6WpkEBJIiZrzSsSl1ZNBFyGfY/tnoeNx2eFFgy4sKkGaw gGgs2iI0s6eG7hRXajFSZFkeAgLiRW2kxUTqgrlbtxP2Le0NwQ2xNGsF51k0X3SpSjhW j8+tfHPf+rPQIO83/lIE5TNM3FXpc3NG7Ya10QgFlqRxRSZJXUeaU4ZYCGCbfTnfkagg GX/fDqtC/Knm2tMDFNIbd5yVgspOV672j4VurYhXnsqbW7Q4o2gkI4HThwkXl76geLVG ojiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=zqLnE6F1bxJqqGpZrIAnNJwDUTII4odi1idRDd5M3T0=; b=iJKFLOwVyqwmsK7vt98nYHTLtfHJz4mH/2UtZ8HMt5Ui2cwUblQ/B5U4mOdnhcvs1s eaHtzdZqIMyIB6ipaztJJCIK3drUfPv9AXl1KBTqUslU0Ua9TDPZ7mOvd5b4gpDd0pw8 vJOzGW6Gf9VsZlOjW0L5Eb1Lfg4eraNgmMevyITWMM0FSDl0wuMSxYHx+0xOSXAAwgKm KbxxMPmqRRpn8AoaY/DNH6HG8gV5aOZdxPXT0SHMz3LX0FN6stZkmBoei5vWOjXxMzmt 9ItNvvYE2jZlHcJOwTZk4mDc3AUTlddSNCQymsQqEwI22pwscTVzouzcAYacXsFgfIx/ g1zg== X-Gm-Message-State: ALyK8tJ2/DKDuJv8bf7pmNkKxSlOA3OKRSkATz2z82EH75whlNOI1+xPqaqKb9xdjTcrt5nt X-Received: by 10.28.169.66 with SMTP id s63mr8514815wme.87.1465479761392; Thu, 09 Jun 2016 06:42:41 -0700 (PDT) Received: from [192.168.2.143] ([83.217.123.106]) by smtp.googlemail.com with ESMTPSA id q7sm27842221wmd.3.2016.06.09.06.42.40 for (version=TLSv1/SSLv3 cipher=OTHER); Thu, 09 Jun 2016 06:42:40 -0700 (PDT) To: toaster@yoctoproject.org References: <1465313375-19742-1-git-send-email-elliot.smith@intel.com> From: Michael Wood Message-ID: <57597250.6060406@intel.com> Date: Thu, 9 Jun 2016 14:42:40 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <1465313375-19742-1-git-send-email-elliot.smith@intel.com> Subject: Re: [PATCH][v2] toaster: fix typo which prevents filters from working X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Jun 2016 13:42:45 -0000 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Thanks pushed to toaster-next On 07/06/16 16:29, Elliot Smith wrote: > 'k' was replaced by 'key' at some point but not fixed in the > body of the loop. This caused a failure when the the query > was constructed for a filtered queryset, due to the variable > not being defined. > > Signed-off-by: Elliot Smith > --- > bitbake/lib/toaster/toastergui/views.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/bitbake/lib/toaster/toastergui/views.py b/bitbake/lib/toaster/toastergui/views.py > index 16f98ee..9d06000 100755 > --- a/bitbake/lib/toaster/toastergui/views.py > +++ b/bitbake/lib/toaster/toastergui/views.py > @@ -268,7 +268,7 @@ def _get_filtering_query(filter_string): > or_values = kv[1].split(OR_VALUE_SEPARATOR) > query = None > for key, val in zip(or_keys, or_values): > - x = __get_q_for_val(k, val) > + x = __get_q_for_val(key, val) > query = query | x if query else x > > and_query = and_query & query if and_query else query