From: Michael Haggerty <mhagger@alum.mit.edu>
To: Johannes Sixt <j6t@kdbg.org>
Cc: "Junio C Hamano" <gitster@pobox.com>,
"David Turner" <dturner@twopensource.com>,
"Jeff King" <peff@peff.net>,
"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH 2/5] t1404: document function test_update_rejected
Date: Thu, 9 Jun 2016 17:45:51 +0200 [thread overview]
Message-ID: <57598F2F.9050806@alum.mit.edu> (raw)
In-Reply-To: <5756FCF3.7050509@kdbg.org>
On 06/07/2016 06:57 PM, Johannes Sixt wrote:
> Am 07.06.2016 um 13:50 schrieb Michael Haggerty:
>> test_update_rejected () {
>> + local prefix before pack create error &&
>
> Do we want to add more of unportable 'local' declarations?
Sorry, I forgot that `local` is not in the POSIX standard.
According to [1] it's nevertheless very portable. Do you object to
`local` based only on its absence from POSIX, or because it's known to
cause problems in the real world? I ask because it is a convenient
feature (and its lack is a common cause of mysterious errors), so it
would be nice if we could allow its use.
Michael
[1] http://apenwarr.ca/log/?m=201102#28
next prev parent reply other threads:[~2016-06-09 15:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 11:50 [PATCH 0/5] Improve test coverage of update-ref error messages Michael Haggerty
2016-06-07 11:50 ` [PATCH 1/5] t1404: rename file to t1404-update-ref-errors.sh Michael Haggerty
2016-06-07 11:50 ` [PATCH 2/5] t1404: document function test_update_rejected Michael Haggerty
2016-06-07 16:57 ` Johannes Sixt
2016-06-07 19:25 ` Junio C Hamano
2016-06-09 15:45 ` Michael Haggerty [this message]
2016-06-09 16:05 ` Junio C Hamano
2016-06-10 6:30 ` Michael Haggerty
2016-06-07 11:50 ` [PATCH 3/5] t1404: add more tests of update-ref error handling Michael Haggerty
2016-06-07 11:50 ` [PATCH 4/5] lock_ref_for_update(): make error handling more uniform Michael Haggerty
2016-06-07 11:50 ` [PATCH 5/5] lock_ref_for_update(): avoid a symref resolution Michael Haggerty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57598F2F.9050806@alum.mit.edu \
--to=mhagger@alum.mit.edu \
--cc=dturner@twopensource.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.