From: Jens Axboe <axboe@fb.com>
To: Omar Sandoval <osandov@osandov.com>
Cc: <linux-block@vger.kernel.org>, <kernel-team@fb.com>
Subject: Re: [PATCH] blk-mq: actually hook up defer list when running requests
Date: Thu, 9 Jun 2016 09:54:51 -0600 [thread overview]
Message-ID: <5759914B.2080806@fb.com> (raw)
In-Reply-To: <9680c9b9108376337b3c4ee1f5c282eaac8440fd.1465435173.git.osandov@fb.com>
On 06/08/2016 07:22 PM, Omar Sandoval wrote:
> From: Omar Sandoval <osandov@fb.com>
>
> If ->queue_rq() returns BLK_MQ_RQ_QUEUE_OK, we use continue and skip
> over the rest of the loop body. However, dptr is assigned later in the
> loop body, and the BLK_MQ_RQ_QUEUE_OK case is exactly the case that we'd
> want it for.
>
> NVMe isn't actually using BLK_MQ_F_DEFER_ISSUE yet, nor is any other
> in-tree driver, but if the code's going to be there, it might as well
> work.
>
> Fixes: 74c450521dd8 ("blk-mq: add a 'list' parameter to ->queue_rq()")
> Signed-off-by: Omar Sandoval <osandov@fb.com>
Thanks Omar, good catch!
--
Jens Axboe
prev parent reply other threads:[~2016-06-09 15:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-09 1:22 [PATCH] blk-mq: actually hook up defer list when running requests Omar Sandoval
2016-06-09 15:54 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5759914B.2080806@fb.com \
--to=axboe@fb.com \
--cc=kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=osandov@osandov.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.