From: "Menschel.P" <menschel.p@posteo.de>
To: Marek Vasut <marex@denx.de>, linux-can@vger.kernel.org
Subject: Re: [PATCH 4/5][RFC] can: kline: Add KLine rtnl configuration options
Date: Thu, 9 Jun 2016 22:21:33 +0200 [thread overview]
Message-ID: <5759CFCD.1050305@posteo.de> (raw)
In-Reply-To: <1465500064-5402-4-git-send-email-marex@denx.de>
[-- Attachment #1: Type: text/plain, Size: 559 bytes --]
Hello Marek,
these look like the timing parameters for KWP2000 protocol.
> +struct kline_timing {
> + __u32 w0;
> + __u32 w1;
> + __u32 w2;
> + __u32 w3;
> + __u32 w4;
> + __u32 w5;
> + __u32 p1;
> + __u32 p2_94;
> + __u32 p2_08;
> + __u32 p3;
> + __u32 p4;
> +};
The wX parameters are the wake up timings and the pX are the response
timings in between tester and ecu.
Imho the protocol needs to be separated from the device driver since
there are other protocols like kwp500 and kwp1281 that use k-line.
Regards,
Patrick
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 3709 bytes --]
next prev parent reply other threads:[~2016-06-09 20:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-09 19:21 [PATCH 1/5][RFC] can: slcan: Replace sizeof struct can_frame with CAN_MTU Marek Vasut
2016-06-09 19:21 ` [PATCH 2/5][RFC] can: Factor out alloc_socketdev() Marek Vasut
2016-06-09 19:21 ` [PATCH 3/5][RFC] can: Add register_candevice() Marek Vasut
2016-06-09 19:21 ` [PATCH 4/5][RFC] can: kline: Add KLine rtnl configuration options Marek Vasut
2016-06-09 20:21 ` Menschel.P [this message]
2016-06-11 19:40 ` Marek Vasut
2016-06-12 15:36 ` Patrick Menschel
2016-06-12 17:34 ` Marek Vasut
2016-06-09 19:21 ` [PATCH 5/5][RFC] can: kline: Add KLine ldisc Marek Vasut
2016-06-17 9:24 ` [PATCH 1/5][RFC] can: slcan: Replace sizeof struct can_frame with CAN_MTU Marc Kleine-Budde
2016-06-17 9:25 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5759CFCD.1050305@posteo.de \
--to=menschel.p@posteo.de \
--cc=linux-can@vger.kernel.org \
--cc=marex@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.