From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 2/5] usb: xhci: fsl: code cleanup for device tree fixup for fsl usb controllers
Date: Fri, 10 Jun 2016 06:08:50 +0200 [thread overview]
Message-ID: <575A3D52.1010901@denx.de> (raw)
In-Reply-To: <AM4PR0401MB2020DF8DAFC0D09BF6ABDDB0F5500@AM4PR0401MB2020.eurprd04.prod.outlook.com>
On 06/10/2016 05:47 AM, Sriram Dash wrote:
>> -----Original Message-----
>> From: Marek Vasut [mailto:marex at denx.de]
>> Sent: Thursday, June 09, 2016 7:01 PM
>> To: Sriram Dash <sriram.dash@nxp.com>; u-boot at lists.denx.de
>> Cc: york sun <york.sun@nxp.com>; albert.u.boot at aribaud.net; Rajesh Bhagat
>> <rajesh.bhagat@nxp.com>
>> Subject: Re: [PATCH v3 2/5] usb: xhci: fsl: code cleanup for device tree fixup for fsl
>> usb controllers
Would you please fix your mailer to omit this useless header ?
[...]
>>> diff --git a/include/fsl_usb.h b/include/fsl_usb.h index
>>> 187e384..882a5f5 100644
>>> --- a/include/fsl_usb.h
>>> +++ b/include/fsl_usb.h
>>> @@ -85,6 +85,12 @@ struct ccsr_usb_phy { #define
>>> CONFIG_SYS_FSL_USB_SQUELCH_PROG_MASK 0x07 #endif
>>>
>>> +/* USB Controllers */
>>> +#define FSL_USB2_MPH "fsl-usb2-mph"
>>> +#define FSL_USB2_DR "fsl-usb2-dr"
>>> +#define USB2_CI "usb2-ci"
What is this "usb2-ci" string ? Is this some DT property or DT
compatible property or just some random string?
>>> +#define SNPS_DWC3 "snps,dwc3"
>>
>> Is this needed as a global macro or can it be local to fsl-dt-fixup.c ?
>>
>
> Currently, the macro are only being used for dt fixup for fsl usb.
> However, in the near future, they might be needed for some other purpose,
> for example, board specific settings.
If they will be used for other purpose, then they can be moved. They are
local now, so keep them local.
> So, i think i will stick with the global macro.
>
>>> /* USB Erratum Checking code */
>>> #ifdef CONFIG_PPC
>>> static inline bool has_dual_phy(void)
>>>
>>
>>
>> --
>> Best regards,
>> Marek Vasut
--
Best regards,
Marek Vasut
next prev parent reply other threads:[~2016-06-10 4:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-09 12:21 [U-Boot] [PATCH v3 0/5] Supporting ARM v8 USB errata for FSL Sriram Dash
2016-06-09 12:21 ` [U-Boot] [PATCH v3 1/5] arm64: fsl-layerscape: add get_svr and IS_SVR_REV helper Sriram Dash
2016-06-09 13:28 ` Marek Vasut
2016-06-10 3:47 ` Sriram Dash
2016-06-09 12:21 ` [U-Boot] [PATCH v3 2/5] usb: xhci: fsl: code cleanup for device tree fixup for fsl usb controllers Sriram Dash
2016-06-09 13:30 ` Marek Vasut
2016-06-10 3:47 ` Sriram Dash
2016-06-10 4:08 ` Marek Vasut [this message]
2016-06-10 5:20 ` Sriram Dash
2016-06-10 5:33 ` Marek Vasut
2016-06-10 6:09 ` Sriram Dash
2016-06-09 12:21 ` [U-Boot] [PATCH v3 3/5] fsl: usb: make errata function common for PPC and ARM Sriram Dash
2016-06-09 12:21 ` [U-Boot] [PATCH v3 4/5] armv8/ls2080: Remove workaround for erratum A008751 Sriram Dash
2016-06-09 12:21 ` [U-Boot] [PATCH v3 5/5] usb: xhci: fsl: Add workaround for USB erratum A-008751 Sriram Dash
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=575A3D52.1010901@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.